Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: pytest: update depends, adopt
Date: Wed, 16 Sep 2020 03:15:41 +0200	[thread overview]
Message-ID: <20200916011541.5hO3np2YugFJs3Cv1Q_pMtgdYvyDEJqFMLGJ3dE4_DA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24929@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24929#issuecomment-693112125

Comment:
Anyway, the check is still failing because pytest people seems to assume that their tests is running with not-`dumb` terminal.
```
FAILED testing/io/test_terminalwriter.py::test_code_highlight[with markup and code_highlight]
FAILED testing/test_terminal.py::test_color_yes - Failed: fnmatch: '\x1b[[]1m...
FAILED testing/test_terminal.py::TestCodeHighlight::test_code_highlight_simple
FAILED testing/test_terminal.py::TestCodeHighlight::test_code_highlight_continuation
```

Maybe just ignore it?
```diff
diff --git a/srcpkgs/python3-pytest/template b/srcpkgs/python3-pytest/template
index 48b4d043c9..646b638731 100644
--- a/srcpkgs/python3-pytest/template
+++ b/srcpkgs/python3-pytest/template
@@ -28,7 +28,8 @@ post_patch() {
 }
 
 do_check() {
-	PYTHONPATH=$(pwd)/build/lib python3 -m pytest
+	PYTHONPATH=$(pwd)/build/lib python3 -m pytest \
+		-k 'not test_color_yes and not test_code_highlight'
 }
 
 post_install() {
```

  parent reply	other threads:[~2020-09-16  1:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 19:51 [PR PATCH] " Chocimier
2020-09-16  0:43 ` sgn
2020-09-16  0:43 ` sgn
2020-09-16  1:15 ` sgn [this message]
2020-09-16 19:26 ` [PR PATCH] [Updated] " Chocimier
2020-09-16 19:27 ` [PR PATCH] [Merged]: " Chocimier
2020-09-16 19:28 ` Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916011541.5hO3np2YugFJs3Cv1Q_pMtgdYvyDEJqFMLGJ3dE4_DA@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).