From: shizonic <shizonic@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] vscode: update to 1.49.1 + switch to electron9. [ci skip]
Date: Fri, 18 Sep 2020 10:00:15 +0200 [thread overview]
Message-ID: <20200918080015.4NRFs6goxMGubHn4Ohk7voE8Pjxt4FYcuNPUVQTneEA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24962@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
There is an updated pull request by shizonic against master on the void-packages repository
https://github.com/shizonic/void-packages vscode
https://github.com/void-linux/void-packages/pull/24962
vscode: update to 1.49.1 + switch to electron9. [ci skip]
A patch file from https://github.com/void-linux/void-packages/pull/24962.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-24962.patch --]
[-- Type: text/x-diff, Size: 2321 bytes --]
From d00427fcd5572ec9522fc9dca1bed931871e9a9e Mon Sep 17 00:00:00 2001
From: Toby Merz <realtiaz@gmail.com>
Date: Fri, 18 Sep 2020 09:49:09 +0200
Subject: [PATCH] vscode: update to 1.49.1 + switch to electron9. [ci skip]
---
srcpkgs/vscode/template | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index d7bf0acd83f..e790e4c830f 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,27 +1,26 @@
# Template file for 'vscode'
pkgname=vscode
-version=1.49.0
+version=1.49.1
revision=1
-# XXX: please update to electron9 next time you rebuild this package
-_electronver=7.3.3
+_electronver=9.2.1
hostmakedepends="pkg-config python nodejs-lts-10 yarn tar git"
-makedepends="libxkbfile-devel libsecret-devel electron7"
+makedepends="libxkbfile-devel libsecret-devel electron9"
depends="libXtst libxkbfile nss dejavu-fonts-ttf xdg-utils ripgrep electron7"
short_desc="Microsoft Code for Linux"
maintainer="shizonic <realtiaz@gmail.com>"
license="MIT"
homepage="https://code.visualstudio.com/"
distfiles="https://github.com/Microsoft/vscode/archive/${version}.tar.gz"
-checksum=b296569db14fadce08a5743a0f6628637fffb817376eb76b5c5d67fb588de29e
+checksum=0fb3829c19db0bea17cf0fd83859ff8f9aef0d092cad4abe2a4d1b26c985b628
patch_args="-Np1"
if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
broken="FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory"
fi
-+# avoid downloading electron binaries for target platform; we use
-+# the system electron, and downloading does not work for all archs
-+export ELECTRON_SKIP_BINARY_DOWNLOAD=1
+# avoid downloading electron binaries for target platform; we use
+# the system electron, and downloading does not work for all archs
+export ELECTRON_SKIP_BINARY_DOWNLOAD=1
do_configure() {
# Use yarn to install dependencies
@@ -46,7 +45,7 @@ do_build() {
export NODE_OPTIONS="${_mem_limit}"
/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
--target=$_electronver \
- --tarball=/usr/include/electron7/node_headers.tar.gz
+ --tarball=/usr/include/electron9/node_headers.tar.gz
yarn install --ignore-engines --frozen-lockfile --arch=x64
export CFLAGS="$CFLAGS -I/usr/include/node"
yarn run gulp vscode-linux-x64-min
next prev parent reply other threads:[~2020-09-18 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 7:52 [PR PATCH] " shizonic
2020-09-18 8:00 ` shizonic [this message]
2020-09-19 2:46 ` [PR REVIEW] " fosslinux
2020-09-19 3:37 ` shizonic
2020-09-20 13:56 ` Johnnynator
2020-09-20 15:34 ` Johnnynator
2020-09-21 7:13 ` [PR PATCH] [Updated] " shizonic
2020-09-21 16:06 ` [PR PATCH] [Merged]: " Johnnynator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918080015.4NRFs6goxMGubHn4Ohk7voE8Pjxt4FYcuNPUVQTneEA@z \
--to=shizonic@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).