Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: picard: update to 2.4.4
Date: Tue, 22 Sep 2020 13:35:41 +0200	[thread overview]
Message-ID: <20200922113541.i6RNWNSVL6rWWLR8md3esr5EJXv4LsJzctxNhFfHKGk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24984@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24984#issuecomment-696665008

Comment:
Sure it sounds better. But I see one random user on the internet claiming breakage (two, if you didn't also file the upstream report). How do I know you didn't misconfigure something? How do I know your patch doesn't have side effects? I've never used picard and hadn't even heard about it until reading your report.

Void defers to upstream. Whenever possible, we try not to maintain unofficial patches because it gets unwieldy. Either wait until upstream sanctions the patch by merging it (we will patch with upstream fixes that haven't yet been released, if they fix known issues), or hope another package committer uses picard and is willing to sign off on the unofficial patch.

You can maintain the patched package in your own repo until then.

> On Sep 22, 2020, at 4:29 AM, eater <notifications@github.com> wrote:
> 
> 
> we currently have a functionally broken package in our repo, having a minimally intrusive fix sounds better to than just keeping it around broken
> 
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or unsubscribe.


  parent reply	other threads:[~2020-09-22 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19 17:38 [PR PATCH] " the-eater
2020-09-19 17:55 ` [PR PATCH] [Updated] " the-eater
2020-09-22  0:51 ` ahesford
2020-09-22  8:29 ` the-eater
2020-09-22 11:35 ` ahesford [this message]
2020-10-03 14:50 ` [PR PATCH] [Closed]: " the-eater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922113541.i6RNWNSVL6rWWLR8md3esr5EJXv4LsJzctxNhFfHKGk@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).