From: PaperMountainStudio <PaperMountainStudio@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: setzer-0.3.2
Date: Fri, 25 Sep 2020 21:46:30 +0200 [thread overview]
Message-ID: <20200925194630.uNGGoldUrSU4wrTDmddRn8deN8ALlVSy9rvZoQWaiU0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25088@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
New review comment by PaperMountainStudio on void-packages repository
https://github.com/void-linux/void-packages/pull/25088#discussion_r495197695
Comment:
The README doesn't differentiate between runtime dependencies and build dependencies. These packages are not needed for the build. Move them to `depends=` if they are needed for runtime, you will have to test this.
next prev parent reply other threads:[~2020-09-25 19:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 15:13 [PR PATCH] New package: setzer Bleznudd
2020-09-25 15:53 ` [PR REVIEW] " PaperMountainStudio
2020-09-25 15:53 ` PaperMountainStudio
2020-09-25 15:53 ` PaperMountainStudio
2020-09-25 15:54 ` PaperMountainStudio
2020-09-25 15:58 ` [PR REVIEW] " PaperMountainStudio
2020-09-25 16:02 ` PaperMountainStudio
2020-09-25 16:09 ` PaperMountainStudio
2020-09-25 16:49 ` [PR PATCH] [Updated] " Bleznudd
2020-09-25 16:51 ` Bleznudd
2020-09-25 16:52 ` [PR REVIEW] " Bleznudd
2020-09-25 16:52 ` Bleznudd
2020-09-25 16:52 ` Bleznudd
2020-09-25 16:55 ` Bleznudd
2020-09-25 16:58 ` Bleznudd
2020-09-25 17:03 ` [PR REVIEW] New package: setzer-0.3.2 Bleznudd
2020-09-25 19:37 ` PaperMountainStudio
2020-09-25 19:46 ` PaperMountainStudio [this message]
2020-09-26 17:10 ` [PR PATCH] [Updated] " Bleznudd
2020-09-26 17:41 ` Bleznudd
2020-09-26 20:14 ` [PR REVIEW] " Bleznudd
2020-09-26 20:35 ` ericonr
2020-09-26 20:44 ` Bleznudd
2020-09-26 20:44 ` [PR REVIEW] " ericonr
2020-09-26 20:52 ` ericonr
2020-09-26 21:01 ` [PR PATCH] [Updated] " Bleznudd
2020-09-26 22:34 ` ericonr
2020-09-27 3:07 ` ahesford
2020-09-27 3:25 ` ericonr
2020-09-27 6:01 ` [PR REVIEW] " ericonr
2020-09-27 6:03 ` ericonr
2020-09-27 11:58 ` [PR PATCH] [Updated] " Bleznudd
2020-09-27 12:00 ` [PR REVIEW] " Bleznudd
2020-09-27 12:29 ` Bleznudd
2020-09-27 14:29 ` ericonr
2020-09-27 14:32 ` ericonr
2020-09-27 16:59 ` [PR PATCH] [Updated] " Bleznudd
2020-09-27 17:00 ` [PR REVIEW] " Bleznudd
2020-09-29 0:24 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925194630.uNGGoldUrSU4wrTDmddRn8deN8ALlVSy9rvZoQWaiU0@z \
--to=papermountainstudio@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).