Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] newsboat: update to 2.20.1.
@ 2020-09-07 21:18 daniel-eys
  2020-09-22 17:23 ` [PR PATCH] [Updated] " daniel-eys
                   ` (12 more replies)
  0 siblings, 13 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-07 21:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

There is a new pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages newsboat
https://github.com/void-linux/void-packages/pull/24742

newsboat: update to 2.20.1.
Also removed some lines in `post_install()` which are already handled by `make install`.

A patch file from https://github.com/void-linux/void-packages/pull/24742.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-24742.patch --]
[-- Type: text/x-diff, Size: 1448 bytes --]

From 75b8ae047448349398a012e515b549d678b11d81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Mon, 7 Sep 2020 22:11:09 +0200
Subject: [PATCH] newsboat: update to 2.20.1.

---
 srcpkgs/newsboat/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index 2de75817d2c..153567c5c41 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,7 +1,7 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.19
-revision=2
+version=2.20.1
+revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
@@ -16,7 +16,11 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=ba484c825bb903daf6d33d55126107b59e41111b455d368362208f1825403d1b
+checksum=82782079b75fe307f7a5a17dff9e712aa5975678fa550fb728d5a46867943566
+
+pre_build() {
+	cargo update --package openssl-sys --precise 0.9.58
+}
 
 do_check() {
 	make test
@@ -25,8 +29,4 @@ do_check() {
 
 post_install() {
 	vlicense LICENSE
-	vsconf doc/example-bookmark-plugin.sh bookmark-plugin.sh
-	mv "${DESTDIR}/usr/share/doc/newsboat/examples/config" \
-		"${DESTDIR}/usr/share/examples/newsboat"
-	vcopy contrib usr/share/examples/newsboat
 }

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] newsboat: update to 2.20.1.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
@ 2020-09-22 17:23 ` daniel-eys
  2020-09-23 11:11 ` newsboat: update to 2.21 Piraty
                   ` (11 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-22 17:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

There is an updated pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages newsboat
https://github.com/void-linux/void-packages/pull/24742

newsboat: update to 2.20.1.
Also removed some lines in `post_install()` which are already handled by `make install`.

A patch file from https://github.com/void-linux/void-packages/pull/24742.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-newsboat-24742.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]

From ab090d36ed53d97440a916780a5fe7d37e5326bf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Mon, 7 Sep 2020 22:11:09 +0200
Subject: [PATCH] newsboat: update to 2.21.

---
 srcpkgs/newsboat/template | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/newsboat/template b/srcpkgs/newsboat/template
index 2de75817d2c..e0ebdeeea50 100644
--- a/srcpkgs/newsboat/template
+++ b/srcpkgs/newsboat/template
@@ -1,7 +1,7 @@
 # Template file for 'newsboat'
 pkgname=newsboat
-version=2.19
-revision=2
+version=2.21
+revision=1
 build_style=configure
 build_helper="rust"
 configure_script="./config.sh"
@@ -16,7 +16,7 @@ license="MIT"
 homepage="https://newsboat.org/"
 changelog="https://raw.githubusercontent.com/newsboat/newsboat/master/CHANGELOG.md"
 distfiles="https://newsboat.org/releases/${version}/newsboat-${version}.tar.xz"
-checksum=ba484c825bb903daf6d33d55126107b59e41111b455d368362208f1825403d1b
+checksum=0c46b3dd46bb578dd6dd4915db4cfdffb4352ab258f251080ad14655c75a9c31
 
 do_check() {
 	make test
@@ -25,8 +25,4 @@ do_check() {
 
 post_install() {
 	vlicense LICENSE
-	vsconf doc/example-bookmark-plugin.sh bookmark-plugin.sh
-	mv "${DESTDIR}/usr/share/doc/newsboat/examples/config" \
-		"${DESTDIR}/usr/share/examples/newsboat"
-	vcopy contrib usr/share/examples/newsboat
 }

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
  2020-09-22 17:23 ` [PR PATCH] [Updated] " daniel-eys
@ 2020-09-23 11:11 ` Piraty
  2020-09-23 12:21 ` [PR REVIEW] " Piraty
                   ` (10 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-09-23 11:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-697295985

Comment:
do you care that some test fail?
```
test cases:   495 |   492 passed | 3 failed
assertions: 22478 | 22472 passed | 6 failed

=> ERROR: newsboat-2.21_1: do_check: 'TERM=$TERM TMPDIR=/dev/shm ./test' exited with 6
=> ERROR:   in do_check() at srcpkgs/newsboat/template:23
=> ERROR: newsboat-2.21_1: do_check: '( cd test && TERM=$TERM TMPDIR=/dev/shm ./test )' exited with 1
=> ERROR:   in do_check() at srcpkgs/newsboat/template:23
```

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
  2020-09-22 17:23 ` [PR PATCH] [Updated] " daniel-eys
  2020-09-23 11:11 ` newsboat: update to 2.21 Piraty
@ 2020-09-23 12:21 ` Piraty
  2020-09-23 12:41 ` daniel-eys
                   ` (9 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-09-23 12:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#discussion_r493521665

Comment:
please double-check the lines you removed from `post_install`,
for example: `diff <(xbps-query -Rf newsboat) <(fd -t f . usr | sort | sed 's/^/\//')`

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (2 preceding siblings ...)
  2020-09-23 12:21 ` [PR REVIEW] " Piraty
@ 2020-09-23 12:41 ` daniel-eys
  2020-09-23 12:41 ` daniel-eys
                   ` (8 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-23 12:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#discussion_r493541628

Comment:
This file is already at `/usr/share/doc/newsboat/examples/example-bookmark-plugin.sh`.
I made sure that no actual files were lost.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (3 preceding siblings ...)
  2020-09-23 12:41 ` daniel-eys
@ 2020-09-23 12:41 ` daniel-eys
  2020-09-24  9:54 ` [PR REVIEW] " Piraty
                   ` (7 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-23 12:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-697338294

Comment:
> do you care that some test fail?
> 
> ```
> test cases:   495 |   492 passed | 3 failed
> assertions: 22478 | 22472 passed | 6 failed
> 
> => ERROR: newsboat-2.21_1: do_check: 'TERM=$TERM TMPDIR=/dev/shm ./test' exited with 6
> => ERROR:   in do_check() at srcpkgs/newsboat/template:23
> => ERROR: newsboat-2.21_1: do_check: '( cd test && TERM=$TERM TMPDIR=/dev/shm ./test )' exited with 1
> => ERROR:   in do_check() at srcpkgs/newsboat/template:23
> ```

Strange, all tests actually passed on my machine.
```
All tests passed (22485 assertions in 495 test cases)
```
2.21 is running without any issues so far, so I guess this should be fine.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (4 preceding siblings ...)
  2020-09-23 12:41 ` daniel-eys
@ 2020-09-24  9:54 ` Piraty
  2020-09-24  9:56 ` Piraty
                   ` (6 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-09-24  9:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#discussion_r494187306

Comment:
i dind't mean that file in specific but the others. my diff has about 20 changed lines. please run my snippet (in `destdir/newsboat-...`)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (5 preceding siblings ...)
  2020-09-24  9:54 ` [PR REVIEW] " Piraty
@ 2020-09-24  9:56 ` Piraty
  2020-09-26 13:38 ` [PR REVIEW] " daniel-eys
                   ` (5 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-09-24  9:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-698243745

Comment:
> Strange, all tests actually passed on my machine.
> 
> ```
> All tests passed (22485 assertions in 495 test cases)
> ```
> 
> 2.21 is running without any issues so far, so I guess this should be fine.

did you build with `XBPS_CHECK_PKGS=yes` in etc/conf ?

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (6 preceding siblings ...)
  2020-09-24  9:56 ` Piraty
@ 2020-09-26 13:38 ` daniel-eys
  2020-09-26 13:39 ` daniel-eys
                   ` (4 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-26 13:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#discussion_r495457770

Comment:
I diffed the package contents. The `contrib` folder is currently present twice in the package, once installed by `make install` to `/usr/share/doc/newsboat/contrib` and then again by the `vcopy` to `/usr/share/examples/newsboat/contrib`. That's I was trying to fix.


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (7 preceding siblings ...)
  2020-09-26 13:38 ` [PR REVIEW] " daniel-eys
@ 2020-09-26 13:39 ` daniel-eys
  2020-10-02 19:43 ` Minoru
                   ` (3 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-09-26 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-699496948

Comment:
> > Strange, all tests actually passed on my machine.
> > ```
> > All tests passed (22485 assertions in 495 test cases)
> > ```
> > 
> > 
> > 2.21 is running without any issues so far, so I guess this should be fine.
> 
> did you build with `XBPS_CHECK_PKGS=yes` in etc/conf ?

Yes

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (8 preceding siblings ...)
  2020-09-26 13:39 ` daniel-eys
@ 2020-10-02 19:43 ` Minoru
  2020-10-04 18:17 ` Piraty
                   ` (2 subsequent siblings)
  12 siblings, 0 replies; 15+ messages in thread
From: Minoru @ 2020-10-02 19:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-702924244

Comment:
> do you care that some test fail?

I am Newsboat's maintainer, so I do :) Can I view the whole output somewhere? I don't see tests being run in the Travis logs.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (9 preceding siblings ...)
  2020-10-02 19:43 ` Minoru
@ 2020-10-04 18:17 ` Piraty
  2020-10-04 19:23 ` Minoru
  2020-10-05 19:15 ` [PR PATCH] [Closed]: " Piraty
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-10-04 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-703294602

Comment:
Tests fail when building in an x86_64-musl environment. Running tests is neither part of travis nor buildbot.

Reproduce:
```
./xbps-src zap && ./xbps-src binary-bootstrap x86_64-musl
./xbps-src -j 1 -Q pkg newsboat
```
Full log: https://termbin.com/yuj5 (might not be available after a while)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (10 preceding siblings ...)
  2020-10-04 18:17 ` Piraty
@ 2020-10-04 19:23 ` Minoru
  2020-10-05 19:15 ` [PR PATCH] [Closed]: " Piraty
  12 siblings, 0 replies; 15+ messages in thread
From: Minoru @ 2020-10-04 19:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New comment by Minoru on void-packages repository

https://github.com/void-linux/void-packages/pull/24742#issuecomment-703303194

Comment:
Thanks! We've had a few reports about problems with musl builds, but unfortunately never gotten to the bottom of the matter. I copied your output to newsboat/newsboat#1216, maybe someone will look at it after all ._.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Closed]: newsboat: update to 2.21.
  2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
                   ` (11 preceding siblings ...)
  2020-10-04 19:23 ` Minoru
@ 2020-10-05 19:15 ` Piraty
  12 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-10-05 19:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

There's a closed pull request on the void-packages repository

newsboat: update to 2.21.
https://github.com/void-linux/void-packages/pull/24742

Description:
Also removed some lines in `post_install()` which are already handled by `make install`.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: newsboat: update to 2.21.
  2020-10-02  8:05 [PR PATCH] " jbenden
@ 2020-10-02 19:16 ` daniel-eys
  0 siblings, 0 replies; 15+ messages in thread
From: daniel-eys @ 2020-10-02 19:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/25270#issuecomment-702912588

Comment:
#24742

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2020-10-05 19:15 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 21:18 [PR PATCH] newsboat: update to 2.20.1 daniel-eys
2020-09-22 17:23 ` [PR PATCH] [Updated] " daniel-eys
2020-09-23 11:11 ` newsboat: update to 2.21 Piraty
2020-09-23 12:21 ` [PR REVIEW] " Piraty
2020-09-23 12:41 ` daniel-eys
2020-09-23 12:41 ` daniel-eys
2020-09-24  9:54 ` [PR REVIEW] " Piraty
2020-09-24  9:56 ` Piraty
2020-09-26 13:38 ` [PR REVIEW] " daniel-eys
2020-09-26 13:39 ` daniel-eys
2020-10-02 19:43 ` Minoru
2020-10-04 18:17 ` Piraty
2020-10-04 19:23 ` Minoru
2020-10-05 19:15 ` [PR PATCH] [Closed]: " Piraty
2020-10-02  8:05 [PR PATCH] " jbenden
2020-10-02 19:16 ` daniel-eys

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).