From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [NOMERGE] torbrowser-launcher: fix public key and version string comparison error
Date: Tue, 29 Sep 2020 01:31:41 +0200 [thread overview]
Message-ID: <20200928233141.DK6GTKmU39lStoHQRRBQ-8ZCXjJIJ-GPIpzvdibtuhQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25106@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25106#issuecomment-700336931
Comment:
The key looks fine and so does the PR, overall. I'm willing to merge this, but given upstream's lack of response to the key change and the other patch in this PR for version checking, I believe we should seriously consider dropping this. If reasonable, perhaps a restricted torbrowser package?
next prev parent reply other threads:[~2020-09-28 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 23:23 [PR PATCH] " tibequadorian
2020-09-26 13:22 ` daniel-eys
2020-09-26 14:56 ` [PR PATCH] [Updated] " tibequadorian
2020-09-26 14:59 ` tibequadorian
2020-09-27 17:46 ` Piraty
2020-09-27 18:13 ` [NOMERGE] " tibequadorian
2020-09-27 19:41 ` [PR PATCH] [Updated] " tibequadorian
2020-09-27 20:21 ` tibequadorian
2020-09-28 21:17 ` tibequadorian
2020-09-28 21:17 ` [PR PATCH] [Closed]: " tibequadorian
2020-09-28 23:31 ` ericonr [this message]
2020-09-29 0:37 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928233141.DK6GTKmU39lStoHQRRBQ-8ZCXjJIJ-GPIpzvdibtuhQ@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).