Github messages for voidlinux
 help / color / mirror / Atom feed
From: felix <felix@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] collectd: add write_prometheus plugin
Date: Wed, 30 Sep 2020 03:51:33 +0200	[thread overview]
Message-ID: <20200930015133.XqA_ljSlYpKW9kWSlG1F_0DvD9X__iPqXO3sm87HSTU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21202@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New review comment by felix on void-packages repository

https://github.com/void-linux/void-packages/pull/21202#discussion_r497199137

Comment:
I thought the point was to ensure the dependent libraries are present if that option is selected?

  parent reply	other threads:[~2020-09-30  1:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 12:53 [PR PATCH] " felix
2020-04-30  2:04 ` [PR PATCH] [Updated] " felix
2020-09-29  1:59 ` [PR REVIEW] " ericonr
2020-09-30  1:51 ` felix [this message]
2020-09-30  2:21 ` ericonr
2020-10-01  4:13 ` [PR PATCH] [Updated] " felix
2020-10-10 22:49 ` ericonr
2020-10-12  6:04 ` felix
2020-12-20  4:09 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930015133.XqA_ljSlYpKW9kWSlG1F_0DvD9X__iPqXO3sm87HSTU@z \
    --to=felix@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).