* [PR PATCH] falkon: add KDE build option.
@ 2020-09-28 16:42 travankor
2020-09-28 19:00 ` pullmoll
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: travankor @ 2020-09-28 16:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is a new pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages falkon
https://github.com/void-linux/void-packages/pull/25156
falkon: add KDE build option.
None
A patch file from https://github.com/void-linux/void-packages/pull/25156.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-falkon-25156.patch --]
[-- Type: text/x-diff, Size: 1601 bytes --]
From 47a1668dc711843d01c50fefed0e43c6c556fa4f Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Tue, 22 Sep 2020 09:12:34 -0700
Subject: [PATCH] falkon: add KDE build option.
---
srcpkgs/falkon/template | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index 6c9f1f201ad..e4253b8c5db 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,11 +4,10 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3 kcoreaddons"
+ qt5-qmake qt5-host-tools python3"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
- qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
- kwallet-devel kio-devel purpose-devel"
+ qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel"
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -18,3 +17,14 @@ distfiles="${KDE_SITE}/falkon/${version%.*}/falkon-${version}.tar.xz"
checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
+
+build_options="kde"
+build_options_default="kde"
+desc_option_kde="KDE integration"
+
+if [ "$build_option_kde" ]; then
+ hostmakedepends+=" kcoreaddons"
+ makedepends+=" kwallet-devel kio-devel purpose-devel"
+else
+ makedepends+=" ki18n-devel xcb-util-devel"
+fi
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
@ 2020-09-28 19:00 ` pullmoll
2020-09-28 19:22 ` pullmoll
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pullmoll @ 2020-09-28 19:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700221850
Comment:
Falkon is used also as the default browser for lxqt. I believe this change may seriously increase the memory footprint for lxqt and the live images. This is bad because lxqt is usually a choice for old machines with less memory and disk space.
IMHO the `build_options_default` should be empty. The default browser for KDE is `konqueror`, or is it?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
2020-09-28 19:00 ` pullmoll
@ 2020-09-28 19:22 ` pullmoll
2020-09-28 19:22 ` pullmoll
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pullmoll @ 2020-09-28 19:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700232270
Comment:
As an alternative I think, since building `falkon` is not too heavy, i.e. doesn't take many, many hours like chromium, wbkit2gtk, or qt5-webengine (which is what it uses), we could create two versions: `falkon` and `falkon-kde` the latter built with the additional options.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
2020-09-28 19:00 ` pullmoll
2020-09-28 19:22 ` pullmoll
@ 2020-09-28 19:22 ` pullmoll
2020-09-28 23:56 ` travankor
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pullmoll @ 2020-09-28 19:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700232270
Comment:
As an alternative I think, since building `falkon` is not too heavy, i.e. doesn't take many, many hours like chromium, webkit2gtk, or qt5-webengine (which is what it uses), we could create two versions: `falkon` and `falkon-kde` the latter built with the additional options.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (2 preceding siblings ...)
2020-09-28 19:22 ` pullmoll
@ 2020-09-28 23:56 ` travankor
2020-09-28 23:57 ` travankor
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-09-28 23:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700343401
Comment:
>I believe this change may seriously increase the memory footprint for lxqt and the live images.
Do you mean building with the optional KDE integration libraries? Because that's already what's happening in the current build, so I just set the existing behaviour as the default. If not, could you explain more what you mean?
The motivation for this PR was to create a more stripped-down version of falkon that did not require optional KDE libraries.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (3 preceding siblings ...)
2020-09-28 23:56 ` travankor
@ 2020-09-28 23:57 ` travankor
2020-09-28 23:58 ` travankor
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-09-28 23:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700343401
Comment:
>I believe this change may seriously increase the memory footprint for lxqt and the live images.
Do you mean building with the optional KDE integration libraries? Because that's already what's happening in the current build, so I just set the existing behaviour as the default. If not, could you explain in more detail what you mean?
The motivation for this PR was to create a more stripped-down version of falkon that did not require optional KDE libraries.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (4 preceding siblings ...)
2020-09-28 23:57 ` travankor
@ 2020-09-28 23:58 ` travankor
2020-09-29 11:24 ` pullmoll
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-09-28 23:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
New comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700343401
Comment:
>I believe this change may seriously increase the memory footprint for lxqt and the live images.
Do you mean building with the optional KDE integration libraries? Because that's already what's happening in the current build, so I just set the existing behaviour as the default. If not, could you please explain in more detail what you mean?
The motivation for this PR was to create a more stripped-down version of falkon that did not require optional KDE libraries.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (5 preceding siblings ...)
2020-09-28 23:58 ` travankor
@ 2020-09-29 11:24 ` pullmoll
2020-09-30 18:50 ` [PR REVIEW] " Piraty
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: pullmoll @ 2020-09-29 11:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-700639523
Comment:
Uh, okay, I got that wrong. I thought you were adding new dependencies with this PR.
I'll leave this to other @void-linux/pkg-committers then.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (6 preceding siblings ...)
2020-09-29 11:24 ` pullmoll
@ 2020-09-30 18:50 ` Piraty
2020-10-01 3:05 ` [PR PATCH] [Updated] " travankor
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-09-30 18:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#discussion_r497728401
Comment:
put `_default` below `desc`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (7 preceding siblings ...)
2020-09-30 18:50 ` [PR REVIEW] " Piraty
@ 2020-10-01 3:05 ` travankor
2020-10-01 3:08 ` travankor
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-10-01 3:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages falkon
https://github.com/void-linux/void-packages/pull/25156
falkon: add KDE build option.
None
A patch file from https://github.com/void-linux/void-packages/pull/25156.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-falkon-25156.patch --]
[-- Type: text/x-diff, Size: 3285 bytes --]
From 47a1668dc711843d01c50fefed0e43c6c556fa4f Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Tue, 22 Sep 2020 09:12:34 -0700
Subject: [PATCH 1/2] falkon: add KDE build option.
---
srcpkgs/falkon/template | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index 6c9f1f201ad..e4253b8c5db 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,11 +4,10 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3 kcoreaddons"
+ qt5-qmake qt5-host-tools python3"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
- qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
- kwallet-devel kio-devel purpose-devel"
+ qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel"
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -18,3 +17,14 @@ distfiles="${KDE_SITE}/falkon/${version%.*}/falkon-${version}.tar.xz"
checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
+
+build_options="kde"
+build_options_default="kde"
+desc_option_kde="KDE integration"
+
+if [ "$build_option_kde" ]; then
+ hostmakedepends+=" kcoreaddons"
+ makedepends+=" kwallet-devel kio-devel purpose-devel"
+else
+ makedepends+=" ki18n-devel xcb-util-devel"
+fi
From 167081fc36bd268da403d44e79b2d98625a1d096 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Wed, 30 Sep 2020 19:53:07 -0700
Subject: [PATCH 2/2] falkon: add KDE build option.
This allows to build falkon without optional KDE libraries.
---
srcpkgs/falkon/template | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index e4253b8c5db..da9f55ecccf 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,10 +4,11 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3"
+ qt5-qmake qt5-host-tools python3 $(vopt_if kde kcoreaddons)"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
- qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel"
+ qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
+ $(vopt_if kde 'kwallet-devel kio-devel puprose-devel' 'ki18n-devel xcb-util-devel')
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -19,12 +20,5 @@ checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
build_options="kde"
-build_options_default="kde"
desc_option_kde="KDE integration"
-
-if [ "$build_option_kde" ]; then
- hostmakedepends+=" kcoreaddons"
- makedepends+=" kwallet-devel kio-devel purpose-devel"
-else
- makedepends+=" ki18n-devel xcb-util-devel"
-fi
+build_options_default="kde"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (8 preceding siblings ...)
2020-10-01 3:05 ` [PR PATCH] [Updated] " travankor
@ 2020-10-01 3:08 ` travankor
2020-10-01 3:09 ` travankor
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-10-01 3:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages falkon
https://github.com/void-linux/void-packages/pull/25156
falkon: add KDE build option.
None
A patch file from https://github.com/void-linux/void-packages/pull/25156.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-falkon-25156.patch --]
[-- Type: text/x-diff, Size: 3286 bytes --]
From 47a1668dc711843d01c50fefed0e43c6c556fa4f Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Tue, 22 Sep 2020 09:12:34 -0700
Subject: [PATCH 1/2] falkon: add KDE build option.
---
srcpkgs/falkon/template | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index 6c9f1f201ad..e4253b8c5db 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,11 +4,10 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3 kcoreaddons"
+ qt5-qmake qt5-host-tools python3"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
- qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
- kwallet-devel kio-devel purpose-devel"
+ qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel"
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -18,3 +17,14 @@ distfiles="${KDE_SITE}/falkon/${version%.*}/falkon-${version}.tar.xz"
checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
+
+build_options="kde"
+build_options_default="kde"
+desc_option_kde="KDE integration"
+
+if [ "$build_option_kde" ]; then
+ hostmakedepends+=" kcoreaddons"
+ makedepends+=" kwallet-devel kio-devel purpose-devel"
+else
+ makedepends+=" ki18n-devel xcb-util-devel"
+fi
From 21a483f055f62907086c98c2f3e367e34e8452ae Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Wed, 30 Sep 2020 19:53:07 -0700
Subject: [PATCH 2/2] falkon: add KDE build option.
This allows to build falkon without optional KDE libraries.
---
srcpkgs/falkon/template | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index e4253b8c5db..70d3df9a9c0 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,10 +4,11 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3"
+ qt5-qmake qt5-host-tools python3 $(vopt_if kde kcoreaddons)"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
- qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel"
+ qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
+ $(vopt_if kde 'kwallet-devel kio-devel purpose-devel' 'ki18n-devel xcb-util-devel')"
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -19,12 +20,5 @@ checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
build_options="kde"
-build_options_default="kde"
desc_option_kde="KDE integration"
-
-if [ "$build_option_kde" ]; then
- hostmakedepends+=" kcoreaddons"
- makedepends+=" kwallet-devel kio-devel purpose-devel"
-else
- makedepends+=" ki18n-devel xcb-util-devel"
-fi
+build_options_default="kde"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (9 preceding siblings ...)
2020-10-01 3:08 ` travankor
@ 2020-10-01 3:09 ` travankor
2020-10-01 3:10 ` [PR REVIEW] " travankor
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-10-01 3:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
There is an updated pull request by travankor against master on the void-packages repository
https://github.com/travankor/void-packages falkon
https://github.com/void-linux/void-packages/pull/25156
falkon: add KDE build option.
None
A patch file from https://github.com/void-linux/void-packages/pull/25156.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-falkon-25156.patch --]
[-- Type: text/x-diff, Size: 1505 bytes --]
From c09ce97f6ec93a44c5fb69e3feb3ee7545ca2972 Mon Sep 17 00:00:00 2001
From: travankor <travankor@tuta.io>
Date: Tue, 22 Sep 2020 09:12:34 -0700
Subject: [PATCH] falkon: add KDE build option.
This allows to build falkon without optional KDE libraries.
---
srcpkgs/falkon/template | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/falkon/template b/srcpkgs/falkon/template
index 6c9f1f201ad..70d3df9a9c0 100644
--- a/srcpkgs/falkon/template
+++ b/srcpkgs/falkon/template
@@ -4,11 +4,11 @@ version=3.1.0
revision=4
build_style=cmake
hostmakedepends="extra-cmake-modules gettext pkg-config
- qt5-qmake qt5-host-tools python3 kcoreaddons"
+ qt5-qmake qt5-host-tools python3 $(vopt_if kde kcoreaddons)"
makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
qt5-plugin-sqlite qt5-plugin-tds qt5-declarative-devel qt5-webchannel-devel
qt5-webengine-devel qt5-location-devel qt5-x11extras-devel qt5-tools-devel
- kwallet-devel kio-devel purpose-devel"
+ $(vopt_if kde 'kwallet-devel kio-devel purpose-devel' 'ki18n-devel xcb-util-devel')"
depends="qt5-plugin-sqlite"
short_desc="Cross-platform Qt Web Browser"
maintainer="Helmut Pozimski <helmut@pozimski.eu>"
@@ -18,3 +18,7 @@ distfiles="${KDE_SITE}/falkon/${version%.*}/falkon-${version}.tar.xz"
checksum=ce743cd80c0e2d525a784e29c9b487f73480119b0567f9ce8ef1f44cca527587
LDFLAGS="-Wl,--no-fatal-warnings"
+
+build_options="kde"
+desc_option_kde="KDE integration"
+build_options_default="kde"
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (10 preceding siblings ...)
2020-10-01 3:09 ` travankor
@ 2020-10-01 3:10 ` travankor
2020-10-09 20:18 ` ericonr
2020-10-13 20:47 ` [PR PATCH] [Merged]: " Piraty
13 siblings, 0 replies; 15+ messages in thread
From: travankor @ 2020-10-01 3:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New review comment by travankor on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#discussion_r497959797
Comment:
thanks, i didn't think to have multiple values in `vopt_if`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (11 preceding siblings ...)
2020-10-01 3:10 ` [PR REVIEW] " travankor
@ 2020-10-09 20:18 ` ericonr
2020-10-13 20:47 ` [PR PATCH] [Merged]: " Piraty
13 siblings, 0 replies; 15+ messages in thread
From: ericonr @ 2020-10-09 20:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25156#issuecomment-706383989
Comment:
@Piraty ok to merge?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: falkon: add KDE build option.
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
` (12 preceding siblings ...)
2020-10-09 20:18 ` ericonr
@ 2020-10-13 20:47 ` Piraty
13 siblings, 0 replies; 15+ messages in thread
From: Piraty @ 2020-10-13 20:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
There's a merged pull request on the void-packages repository
falkon: add KDE build option.
https://github.com/void-linux/void-packages/pull/25156
Description:
None
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-10-13 20:47 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 16:42 [PR PATCH] falkon: add KDE build option travankor
2020-09-28 19:00 ` pullmoll
2020-09-28 19:22 ` pullmoll
2020-09-28 19:22 ` pullmoll
2020-09-28 23:56 ` travankor
2020-09-28 23:57 ` travankor
2020-09-28 23:58 ` travankor
2020-09-29 11:24 ` pullmoll
2020-09-30 18:50 ` [PR REVIEW] " Piraty
2020-10-01 3:05 ` [PR PATCH] [Updated] " travankor
2020-10-01 3:08 ` travankor
2020-10-01 3:09 ` travankor
2020-10-01 3:10 ` [PR REVIEW] " travankor
2020-10-09 20:18 ` ericonr
2020-10-13 20:47 ` [PR PATCH] [Merged]: " Piraty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).