From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Packaging: get git commit sha?
Date: Sun, 04 Oct 2020 21:54:00 +0200 [thread overview]
Message-ID: <20201004195400.MoyZIoQz1lIbPuGxnQ9EcGWKRiUUR1Ijx1ZESXR3-AU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25343@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/issues/25343#issuecomment-703307116
Comment:
Hard coding is the way to go if you really want to respect their requirements, unfortunately. I'm not sure it's entirely necessary, since we would be using tagged releases, which should be directly linkable to a specific commit.
The `-X main.date=$DATE` part is bad, though, and upstream should be told not to require it (or even suggest it, for that matter). It hurts reproducible builds for no gain.
next prev parent reply other threads:[~2020-10-04 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 19:38 [ISSUE] " classabbyamp
2020-10-04 19:53 ` ericonr
2020-10-04 19:54 ` ericonr [this message]
2020-10-04 20:13 ` classabbyamp
2020-10-04 20:13 ` [ISSUE] [CLOSED] " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004195400.MoyZIoQz1lIbPuGxnQ9EcGWKRiUUR1Ijx1ZESXR3-AU@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).