From: cinerea0 <cinerea0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] network-manager-applet: add libappindicator support
Date: Mon, 05 Oct 2020 03:17:14 +0200 [thread overview]
Message-ID: <20201005011714.PNEZ6LVf2lJoZEcXJmp3vXK2ZsvMdOudeAfBYnlXauE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24497@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24497#discussion_r499310669
Comment:
That last line is a mistake and doesn't need to be there. As for the first two, the package fails to build documentation properly only on ARM architectures. Those lines install files that are only missing when built on ARM.
next prev parent reply other threads:[~2020-10-05 1:17 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 1:13 [PR PATCH] " cinerea0
2020-08-27 1:39 ` cinerea0
2020-09-09 14:07 ` sgn
2020-09-11 3:51 ` cinerea0
2020-09-11 5:41 ` CameronNemo
2020-09-11 5:42 ` CameronNemo
2020-09-11 5:44 ` CameronNemo
2020-09-11 23:24 ` cinerea0
2020-09-11 23:39 ` CameronNemo
2020-09-30 20:51 ` [PR PATCH] [Updated] " cinerea0
2020-09-30 21:15 ` cinerea0
2020-09-30 21:31 ` cinerea0
2020-09-30 23:37 ` [PR REVIEW] " CameronNemo
2020-09-30 23:37 ` CameronNemo
2020-09-30 23:37 ` CameronNemo
2020-09-30 23:37 ` CameronNemo
2020-09-30 23:54 ` [PR PATCH] [Updated] " cinerea0
2020-10-01 0:05 ` [PR REVIEW] " cinerea0
2020-10-01 0:05 ` cinerea0
2020-10-01 0:07 ` cinerea0
2020-10-01 0:08 ` cinerea0
2020-10-04 3:09 ` [PR PATCH] [Updated] " cinerea0
2020-10-04 4:57 ` cinerea0
2020-10-04 5:34 ` cinerea0
2020-10-04 23:05 ` cinerea0
2020-10-04 23:43 ` cinerea0
2020-10-05 0:17 ` cinerea0
2020-10-05 0:44 ` [PR PATCH] [Updated] " cinerea0
2020-10-05 0:48 ` [PR REVIEW] " CameronNemo
2020-10-05 1:17 ` cinerea0 [this message]
2020-10-05 1:27 ` CameronNemo
2020-10-05 1:44 ` cinerea0
2020-10-05 1:48 ` cinerea0
2020-10-05 1:51 ` CameronNemo
2020-10-05 2:20 ` cinerea0
2020-10-05 22:32 ` cinerea0
2020-10-05 22:46 ` cinerea0
2020-10-05 23:32 ` [PR PATCH] [Updated] " cinerea0
2020-10-06 2:12 ` CameronNemo
2020-10-06 2:14 ` CameronNemo
2020-10-06 2:30 ` [PR PATCH] [Updated] " cinerea0
2020-10-06 2:45 ` cinerea0
2020-10-06 3:01 ` cinerea0
2020-10-06 3:07 ` cinerea0
2020-10-06 3:16 ` CameronNemo
2020-10-06 3:28 ` cinerea0
2020-10-06 3:39 ` CameronNemo
2020-10-06 3:40 ` CameronNemo
2020-10-06 3:40 ` CameronNemo
2020-10-06 3:46 ` CameronNemo
2020-10-06 13:07 ` [PR PATCH] [Updated] " cinerea0
2020-10-06 13:23 ` cinerea0
2020-10-06 13:40 ` cinerea0
2020-10-06 14:06 ` cinerea0
2020-10-06 15:21 ` cinerea0
2020-10-06 16:34 ` cinerea0
2020-10-06 22:19 ` cinerea0
2020-10-07 0:09 ` cinerea0
2020-10-07 1:03 ` cinerea0
2020-10-07 2:30 ` cinerea0
2020-10-07 3:09 ` CameronNemo
2020-10-07 3:27 ` [PR PATCH] [Updated] " cinerea0
2020-10-07 4:17 ` cinerea0
2020-10-07 4:59 ` CameronNemo
2020-10-07 5:25 ` [PR PATCH] [Updated] " cinerea0
2020-10-07 14:29 ` cinerea0
2020-10-07 14:30 ` cinerea0
2020-10-07 16:41 ` CameronNemo
2020-10-08 0:30 ` [PR PATCH] [Updated] " cinerea0
2020-10-08 1:39 ` cinerea0
2020-10-08 3:12 ` CameronNemo
2020-10-08 5:02 ` [PR PATCH] [Updated] " cinerea0
2020-10-08 16:01 ` cinerea0
2020-10-08 21:34 ` cinerea0
2020-10-08 21:35 ` [PR PATCH] [Updated] " cinerea0
2020-10-08 22:13 ` cinerea0
2020-10-08 23:46 ` [PR PATCH] [Updated] " cinerea0
2020-10-09 1:29 ` cinerea0
2020-10-09 4:42 ` [PR PATCH] [Updated] " cinerea0
2020-10-09 6:42 ` CameronNemo
2020-10-09 16:27 ` cinerea0
2020-10-10 21:51 ` cinerea0
2020-10-10 21:51 ` [PR PATCH] [Updated] " cinerea0
2020-10-10 22:54 ` cinerea0
2020-10-13 0:53 ` [PR PATCH] [Updated] " cinerea0
2020-10-13 2:18 ` cinerea0
2020-10-15 23:51 ` cinerea0
2020-11-18 5:55 ` [PR PATCH] [Updated] New package: libnma-1.8.30; network-manager-applet: update to 1.18.0 and " cinerea0
2020-11-18 6:55 ` Piraty
2020-11-19 1:40 ` [PR PATCH] [Updated] " cinerea0
2020-11-19 5:50 ` cinerea0
2020-11-22 6:25 ` [PR PATCH] [Merged]: " the-maldridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005011714.PNEZ6LVf2lJoZEcXJmp3vXK2ZsvMdOudeAfBYnlXauE@z \
--to=cinerea0@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).