Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: epson-inkjet-printer-escpr2-1.1.15
Date: Thu, 08 Oct 2020 20:47:05 +0200	[thread overview]
Message-ID: <20201008184705.fm4SGbeKo_MqTIGNfAUe98ejtYbxw6kxf9TEihvuqYI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25421@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/25421#discussion_r501939006

Comment:
I was wrong here, `create_wrksrc` and build_wrksrc are actually needed, otherwise masterdir is not cleaned up properly. Please define them back.

  parent reply	other threads:[~2020-10-08 18:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 21:12 [PR PATCH] " motorto
2020-10-08  4:23 ` [PR REVIEW] " fosslinux
2020-10-08  4:23 ` fosslinux
2020-10-08  4:23 ` fosslinux
2020-10-08  4:23 ` fosslinux
2020-10-08  5:57 ` Chocimier
2020-10-08  5:58 ` Chocimier
2020-10-08  7:46 ` motorto
2020-10-08  7:46 ` motorto
2020-10-08  7:46 ` motorto
2020-10-08  7:47 ` motorto
2020-10-08  7:50 ` motorto
2020-10-08  8:15 ` [PR PATCH] [Updated] " motorto
2020-10-08  8:18 ` [PR REVIEW] " motorto
2020-10-08 13:43 ` motorto
2020-10-08 13:44 ` [PR PATCH] [Updated] " motorto
2020-10-08 18:22 ` motorto
2020-10-08 18:37 ` [PR REVIEW] " Chocimier
2020-10-08 18:39 ` Chocimier
2020-10-08 18:45 ` Chocimier
2020-10-08 18:47 ` Chocimier [this message]
2020-10-08 19:53 ` [PR REVIEW] " motorto
2020-10-08 19:55 ` [PR PATCH] [Updated] " motorto
2020-10-08 20:00 ` motorto
2020-10-08 20:11 ` [PR REVIEW] " motorto
2020-10-08 20:12 ` motorto
2020-10-08 20:12 ` motorto
2020-10-08 20:13 ` motorto
2020-10-08 21:14 ` motorto
2020-10-08 21:15 ` motorto
2020-10-08 22:01 ` q66
2020-10-08 22:02 ` q66
2020-10-09  8:05 ` motorto
2020-10-09  8:05 ` motorto
2020-10-09  8:06 ` [PR PATCH] [Updated] " motorto
2020-10-09  8:09 ` motorto
2020-10-10  2:28 ` [PR REVIEW] New package: epson-inkjet-printer-escpr2-1.1.22 fosslinux
2020-10-10  3:43 ` sgn
2020-10-10  8:43 ` motorto
2020-10-10  8:44 ` [PR PATCH] [Updated] " motorto
2020-10-10  9:33 ` Chocimier
2020-10-10  9:53 ` [PR PATCH] [Updated] " motorto
2020-10-10  9:56 ` motorto
2020-10-10  9:58 ` motorto
2020-10-10 10:01 ` motorto
2020-10-15 19:11 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008184705.fm4SGbeKo_MqTIGNfAUe98ejtYbxw6kxf9TEihvuqYI@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).