Re: [PR PATCH] [Updated] qemu: enable debug package

[Skirmisher <Skirmisher@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

There is an updated pull request by Skirmisher against master on the void-packages repository

https://github.com/Skirmisher/void-packages upstream-master
https://github.com/void-linux/void-packages/pull/25482

qemu: enable debug package
qemu package has had -dbg disabled for a long time (looks like an xtraeme anachronism), but the amount of space used by debuginfo is comparable to other large packages, so it seems reasonable to enable. This simplifies the template a little too.

A patch file from https://github.com/void-linux/void-packages/pull/25482.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-upstream-master-25482.patch --]
[-- Type: text/x-diff, Size: 2158 bytes --]

From 7bb40b9dae47070c0f8e9b1db4d4c6643bdc0b57 Mon Sep 17 00:00:00 2001
From: Will Springer <skirmisher@protonmail.com>
Date: Fri, 9 Oct 2020 14:22:38 -0700
Subject: [PATCH] qemu: enable debug package

Disk space used by debuginfo is comparable to other large
packages, so enabling debug package seems reasonable.

Removed now-redundant do_build().
---
 srcpkgs/qemu/template | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index 944a9bd5837..4c1a127b136 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,15 +1,16 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.1.0
-revision=3
+revision=4
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="https://www.qemu.org"
 distfiles="https://wiki.qemu.org/download/qemu-${version}.tar.bz2"
 checksum=8314b6e5fcc7bf9fa3915d504de6586a69cba30ffa27cbe9ba85d2cb9987fb3a
-
-nostrip=yes
+build_style=configure
+nostrip_files="hppa-firmware.img openbios-ppc openbios-sparc32 openbios-sparc64
+ palcode-clipper s390-ccw.img s390-netboot.img u-boot.e500"
 hostmakedepends="gettext pkg-config perl python3 automake libtool flex
  python3-Sphinx texinfo"
 makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
@@ -64,22 +65,14 @@ do_configure() {
 		--disable-xen --enable-tpm \
 		--enable-vhost-net --enable-vnc-png --enable-virtfs \
 		--enable-libusb --disable-glusterfs --enable-snappy --enable-usb-redir \
-		--enable-pie --localstatedir=/var --enable-docs \
+		--enable-pie --localstatedir=/var --enable-docs --disable-strip \
 		$(vopt_enable virgl virglrenderer) $(vopt_enable opengl) $(vopt_enable spice) \
 		${want_sdl} \
 		$(vopt_enable smartcard) \
 		$(vopt_if gtk3 "--enable-gtk") ${args}
 }
-do_build() {
-	# Remove our strip(1) wrapper... E2BIG.
-	rm -f ${XBPS_WRAPPERDIR}/strip
 
-	make ${makejobs}
-}
 do_install() {
-	# Remove our strip(1) wrapper... E2BIG.
-	rm -f ${XBPS_WRAPPERDIR}/strip
-
 	vsed -i Makefile -e 's;dtc/%:;dtc/libfdt:;'
 
 	make DESTDIR=${DESTDIR} install