Re: [PR PATCH] [Updated] pcb: remove noarch.

[fosslinux <fosslinux@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages pcb-noarch
https://github.com/void-linux/void-packages/pull/25512

pcb: remove noarch.
also note that i686 tests are borked. Didn't fix because:

1. I have no idea how `pcb` works, or ghostscript, or any of the weird formats it uses.
2. It's malformed output not a segfault/crash and I didn't feel like digging into obscure stuff like that, I'll leave that to someone more experienced.

For some reason it needed texlive to build??

A patch file from https://github.com/void-linux/void-packages/pull/25512.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pcb-noarch-25512.patch --]
[-- Type: text/x-diff, Size: 1682 bytes --]

From 9970c38c22f32596c48bdfb8c5c9646bda56dcda Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Sun, 11 Oct 2020 19:16:28 +1100
Subject: [PATCH] pcb: remove noarch.

also note that i686 tests are borked.
---
 srcpkgs/pcb-data     |  1 -
 srcpkgs/pcb/template | 15 +++++----------
 2 files changed, 5 insertions(+), 11 deletions(-)
 delete mode 120000 srcpkgs/pcb-data

diff --git a/srcpkgs/pcb-data b/srcpkgs/pcb-data
deleted file mode 120000
index 660275f2247..00000000000
--- a/srcpkgs/pcb-data
+++ /dev/null
@@ -1 +0,0 @@
-pcb
\ No newline at end of file
diff --git a/srcpkgs/pcb/template b/srcpkgs/pcb/template
index 882fffad2c7..d13a2bcc464 100644
--- a/srcpkgs/pcb/template
+++ b/srcpkgs/pcb/template
@@ -1,12 +1,12 @@
-# Template file for 'pcb'.
+# Template file for 'pcb'
 pkgname=pcb
 reverts=20140316_4
 version=4.2.2
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--disable-update-desktop-database --disable-update-mime-database"
 hostmakedepends="flex geda gerbv intltool netpbm pkg-config
- desktop-file-utils tar texinfo tk"
+ desktop-file-utils tar texinfo tk texlive"
 makedepends="gd-devel gtkglext-devel tk-devel"
 depends="pcb-data geda gerbv"
 checkdepends="ImageMagick ghostscript"
@@ -16,11 +16,6 @@ license="GPL-2.0-or-later"
 homepage="http://pcb.geda-project.org/news.html"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
 checksum=1ceeaf1bdbe0508b9b140ca421eb600836579114c04dee939341c5d594f36e5d
+replaces="pcb-data>=0"
 
-pcb-data_package() {
-	archs=noarch
-	short_desc+=" - data files"
-	pkg_install() {
-		vmove usr/share/pcb
-	}
-}
+# Tests are currently failing for i686, at least