Github messages for voidlinux
 help / color / mirror / Atom feed
From: xaltsc <xaltsc@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: tasksh-1.2.0
Date: Sun, 11 Oct 2020 12:14:09 +0200	[thread overview]
Message-ID: <20201011101409.4FizsdHnazj9AnI39db7CC_i-1dz_w-SY-CzUrgWBbU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25326@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

New review comment by xaltsc on void-packages repository

https://github.com/void-linux/void-packages/pull/25326#discussion_r502894941

Comment:
Yeah, it was definitely wrong. I changed it to `readline-devel`, however I can't figure out it the executable was built with readline. The documentation for building is scarce. But steps in the building process and generated dependencies seem to indicate that it is the case.

Nonetheless, the AUR package doesn't include readline as a dependecy.

  parent reply	other threads:[~2020-10-11 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04  6:31 [PR PATCH] " xaltsc
2020-10-09 11:53 ` [PR REVIEW] " Duncaen
2020-10-11 10:10 ` [PR PATCH] [Updated] " xaltsc
2020-10-11 10:14 ` xaltsc [this message]
2020-10-23  1:46 ` xaltsc
2020-10-25 16:26 ` [PR PATCH] [Merged]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011101409.4FizsdHnazj9AnI39db7CC_i-1dz_w-SY-CzUrgWBbU@z \
    --to=xaltsc@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).