Github messages for voidlinux
 help / color / mirror / Atom feed
From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: pinebookpro-kernel: update to 5.9
Date: Tue, 13 Oct 2020 01:49:20 +0200	[thread overview]
Message-ID: <20201012234920.715PTXoqHg7ncNUS6UZ5A1kLTmlkhLqOE6gECgezREM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25546@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/25546#issuecomment-707377637

Comment:
Build for aarch64-musl just failed for me:

```
/void-packages/srcpkgs/pinebookpro-kernel/template: line 100: cd: /destdir/aarch64-linux-musl/pinebookpro-kernel-5.9/usr/lib/modules/5.9_1: No such file or directory
=> ERROR: pinebookpro-kernel-5.9_1: do_install: 'cd ${DESTDIR}/usr/lib/modules/${_kernver}' exited with 1
=> ERROR:   in do_install() at srcpkgs/pinebookpro-kernel/template:100
```

Looking at the relevant line of `template`, I don't see anything there where musl would make a difference, but I'm building a non-musl variant now to make sure. EDIT: Same failure, will try to fix that.

The diff I applied for getting it to build:

```
diff --git a/srcpkgs/pinebookpro-kernel/template b/srcpkgs/pinebookpro-kernel/template
index 82695511b2..44709afdce 100644
--- a/srcpkgs/pinebookpro-kernel/template
+++ b/srcpkgs/pinebookpro-kernel/template
@@ -9,7 +9,7 @@ maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="GPL-2.0-only"
 homepage="https://www.kernel.org"
 distfiles="https://cdn.kernel.org/pub/linux/kernel/v5.x/linux-${version}.tar.xz"
-checksum=fad9a145afe36a27740779997720999a97dd7f58c7a60ad9b4054d94d71aaaa6
+checksum=3239a4ee1250bf2048be988cc8cb46c487b2c8a0de5b1b032d38394d5c6b1a06
 patch_args="-Np1"
 python_version=3
 
@@ -22,7 +22,7 @@ preserve=yes
 hostmakedepends="tar xz bc elfutils-devel flex gmp-devel kmod libmpc-devel
  libressl-devel perl uboot-mkimage cpio python3"
 
-_kernver="${version}_${revision}"
+_kernver="${version}.0_${revision}"
 triggers="kernel-hooks"
 kernel_hooks_version="${_kernver}"
```

It's definitely not a nice solution (having that extra `.0` in the `_kernver` var), but I'm not sure where else to introduce that where it doesn't break something else... As for the change in the checksum: This is the checksum that the kernel sources have for me, maybe the old checksum was for the rc that @CameronNemo tested with earlier?

  parent reply	other threads:[~2020-10-12 23:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 18:43 [PR PATCH] " CameronNemo
2020-10-12 22:31 ` jcgruenhage
2020-10-12 22:46 ` jcgruenhage
2020-10-12 22:47 ` jcgruenhage
2020-10-12 23:41 ` sgn
2020-10-12 23:41 ` sgn
2020-10-12 23:45 ` jcgruenhage
2020-10-12 23:49 ` jcgruenhage [this message]
2020-10-13  1:51 ` [PR PATCH] [Updated] " CameronNemo
2020-10-13  2:06 ` CameronNemo
2020-10-13 15:02 ` jcgruenhage
2020-10-13 17:16 ` jcgruenhage
2020-10-26  3:04 ` [PR PATCH] [Updated] " CameronNemo
2020-10-26  3:06 ` CameronNemo
2020-10-27  2:36 ` CameronNemo
2020-10-27  3:51 ` jcgruenhage
2020-10-27 16:24 ` CameronNemo
2020-11-02 15:47 ` [PR PATCH] [Updated] " CameronNemo
2020-11-02 17:44 ` pinebookpro-kernel: update to 5.9.3 CameronNemo
2020-11-06 19:37 ` [PR PATCH] [Updated] " CameronNemo
2020-11-21 17:22 ` [PR PATCH] [Updated] pinebookpro-kernel: update to 5.9.6 CameronNemo
2020-11-25 20:21 ` pinebookpro-kernel: update to 5.9.8 ericonr
2020-12-03  6:26 ` [PR PATCH] [Updated] " CameronNemo
2020-12-03  6:28 ` pinebookpro-kernel: update to 5.9.12 CameronNemo
2020-12-03 20:49 ` [PR PATCH] [Merged]: " ericonr
2020-12-22  8:20 ` Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012234920.715PTXoqHg7ncNUS6UZ5A1kLTmlkhLqOE6gECgezREM@z \
    --to=jcgruenhage@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).