From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-lazy-object-proxy: update to 1.5.1.
Date: Thu, 15 Oct 2020 04:36:36 +0200 [thread overview]
Message-ID: <20201015023636.qnrh0dLWmHl28tHDPqr1Xl0clwxJUwU_Y_aN9aLu0mU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25586@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25586#discussion_r505129103
Comment:
This was an attempt to stop `setuptools` from fetching dependencies at build time (see https://travis-ci.org/github/void-linux/void-packages/jobs/735601759#L570), but I missed the bad versioning in the `egg-info`. When you drop this patch, please replace the `python3-setuptools` in `hostmakedepends` with `python3-setuptools_scm`, which I added to address this problem. (That package depends on `python3-setuptools`.)
Also, it's a good idea to check whether `${wrksrc}/.eggs` exists after `xbps-src build` and, if so, what its contents are. These are eggs fetched by `setuptools` during build. This is bad, because it diminishes reproducibility, makes the build process more fragile, and is deprecated.
A couple of packages that use `setuptools_scm` also use `setuptools_scm_git_archive`, which doesn't seem to be useful in versioning. That can probably be patched out without breaking the package; see [`srcpkgs/python3-Cheroot/template`](https://github.com/void-linux/void-packages/tree/master/srcpkgs/python3-Cheroot/template).
next prev parent reply other threads:[~2020-10-15 2:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 3:02 [PR PATCH] " pbui
2020-10-15 2:36 ` ahesford [this message]
2020-10-15 3:14 ` [PR PATCH] [Updated] " pbui
2020-10-15 3:15 ` [PR REVIEW] " pbui
2020-10-15 4:07 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015023636.qnrh0dLWmHl28tHDPqr1Xl0clwxJUwU_Y_aN9aLu0mU@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).