From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-numpy-stl: update to 2.11.3.
Date: Thu, 15 Oct 2020 06:26:31 +0200 [thread overview]
Message-ID: <20201015042631.Px3-Y7JbPAG45AHpUINiWh-q5RGqZ0fhl_W2vtAVWhE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25580@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25580#issuecomment-708888843
Comment:
I didn't catch it in my earlier review, but the template [failed to cross-build the C extension](https://travis-ci.org/github/void-linux/void-packages/jobs/735919542#L606) because the host Python could not find numpy (native builds had no such issue). Setting `build_helper="numpy"` in 0ae0bf920a7a9fbbd8f6e362beb3bf23e1af522d automatically adds `python3-numpy` to `hostmakedepends` and, when cross buliding, adds the `python3-numpy` to `makedepends` and sets up the environment to make sure the compilers correctly find the target headers and libraries. The package now cross-builds the C extension.
prev parent reply other threads:[~2020-10-15 4:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 21:41 [PR PATCH] " karl-nilsson
2020-10-15 0:15 ` [PR REVIEW] " ahesford
2020-10-15 3:07 ` [PR PATCH] [Updated] " karl-nilsson
2020-10-15 3:07 ` karl-nilsson
2020-10-15 4:20 ` [PR PATCH] [Closed]: " ahesford
2020-10-15 4:26 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201015042631.Px3-Y7JbPAG45AHpUINiWh-q5RGqZ0fhl_W2vtAVWhE@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).