* [PR PATCH] gcc: fix order of postdep_objects_CXX
@ 2020-10-14 18:31 jnbr
2020-10-15 1:58 ` fosslinux
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jnbr @ 2020-10-14 18:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
There is a new pull request by jnbr against master on the void-packages repository
https://github.com/jnbr/void-packages gcc
https://github.com/void-linux/void-packages/pull/25605
gcc: fix order of postdep_objects_CXX
make sure crt* objects come after anything else
fixes #25535
[ci skip]
A patch file from https://github.com/void-linux/void-packages/pull/25605.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gcc-25605.patch --]
[-- Type: text/x-diff, Size: 1891 bytes --]
From 22e78dc1b001bf26908e1d91ab81d706fe035b60 Mon Sep 17 00:00:00 2001
From: Johannes <johannes.brechtmann@gmail.com>
Date: Wed, 14 Oct 2020 20:26:38 +0200
Subject: [PATCH] gcc: fix order of postdep_objects_CXX
make sure crt* objects come after anything else
fixes #25535
[ci skip]
---
srcpkgs/gcc/patches/fix-vtv-link-order.patch | 20 ++++++++++++++++++++
srcpkgs/gcc/template | 2 +-
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/gcc/patches/fix-vtv-link-order.patch
diff --git a/srcpkgs/gcc/patches/fix-vtv-link-order.patch b/srcpkgs/gcc/patches/fix-vtv-link-order.patch
new file mode 100644
index 00000000000..3315c3e990b
--- /dev/null
+++ b/srcpkgs/gcc/patches/fix-vtv-link-order.patch
@@ -0,0 +1,20 @@
+put vtv_end.o in front of postdep_objects_CXX
+having it after crtendS.o leads to missing zero termination in eh_frame section
+
+This is in line with comment in libgcc/vtv_end.c:
+
+ When the GCC driver inserts vtv_start.o into the link line (just
+ after crtbegin.o) it also inserts vtv_end.o into the link line,
+ just before crtend.o.
+
+--- libstdc++-v3/configure
++++ libstdc++-v3/configure
+@@ -15443,7 +15443,7 @@
+
+ if test "$enable_vtable_verify" = yes; then
+ predep_objects_CXX="${predep_objects_CXX} ${glibcxx_builddir}/../libgcc/vtv_start.o"
+- postdep_objects_CXX="${postdep_objects_CXX} ${glibcxx_builddir}/../libgcc/vtv_end.o"
++ postdep_objects_CXX="${glibcxx_builddir}/../libgcc/vtv_end.o ${postdep_objects_CXX}"
+ fi
+
+
diff --git a/srcpkgs/gcc/template b/srcpkgs/gcc/template
index ead6f05a498..f4e2f949933 100644
--- a/srcpkgs/gcc/template
+++ b/srcpkgs/gcc/template
@@ -8,7 +8,7 @@ _isl_version=0.21
pkgname=gcc
version=${_minorver}.0
-revision=6
+revision=7
short_desc="GNU Compiler Collection"
maintainer="Enno Boland <gottox@voidlinux.org>"
homepage="http://gcc.gnu.org"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
@ 2020-10-15 1:58 ` fosslinux
2020-10-15 5:20 ` jnbr
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: fosslinux @ 2020-10-15 1:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/25605#issuecomment-708845899
Comment:
Woo hoo!
Do the affected `aarch64-musl` packages require a rebuild to be fixed?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
2020-10-15 1:58 ` fosslinux
@ 2020-10-15 5:20 ` jnbr
2020-10-15 5:20 ` jnbr
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jnbr @ 2020-10-15 5:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25605#issuecomment-708903971
Comment:
> Do the affected aarch64-musl packages require a rebuild to be fixed?
No, replacing the broken `libstdc++.so.6.28` is sufficient.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
2020-10-15 1:58 ` fosslinux
2020-10-15 5:20 ` jnbr
@ 2020-10-15 5:20 ` jnbr
2020-10-16 15:09 ` sgn
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jnbr @ 2020-10-15 5:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25605#issuecomment-708903971
Comment:
> Do the affected aarch64-musl packages require a rebuild to be fixed?
No, replacing the broken `libstdc++.so.6.0.28` is sufficient.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
` (2 preceding siblings ...)
2020-10-15 5:20 ` jnbr
@ 2020-10-16 15:09 ` sgn
2020-10-16 18:20 ` jnbr
2020-10-16 18:29 ` [PR PATCH] [Merged]: " jnbr
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-10-16 15:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25605#issuecomment-710104708
Comment:
`aarch64-musl` works. Confirmed by running the check for `geos` which is crashed with old version.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
` (3 preceding siblings ...)
2020-10-16 15:09 ` sgn
@ 2020-10-16 18:20 ` jnbr
2020-10-16 18:29 ` [PR PATCH] [Merged]: " jnbr
5 siblings, 0 replies; 7+ messages in thread
From: jnbr @ 2020-10-16 18:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/25605#issuecomment-710367579
Comment:
Thank you for testing it.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Merged]: gcc: fix order of postdep_objects_CXX
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
` (4 preceding siblings ...)
2020-10-16 18:20 ` jnbr
@ 2020-10-16 18:29 ` jnbr
5 siblings, 0 replies; 7+ messages in thread
From: jnbr @ 2020-10-16 18:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
There's a merged pull request on the void-packages repository
gcc: fix order of postdep_objects_CXX
https://github.com/void-linux/void-packages/pull/25605
Description:
make sure crt* objects come after anything else
fixes #25535
[ci skip]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-16 18:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-14 18:31 [PR PATCH] gcc: fix order of postdep_objects_CXX jnbr
2020-10-15 1:58 ` fosslinux
2020-10-15 5:20 ` jnbr
2020-10-15 5:20 ` jnbr
2020-10-16 15:09 ` sgn
2020-10-16 18:20 ` jnbr
2020-10-16 18:29 ` [PR PATCH] [Merged]: " jnbr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).