Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: waypoint-0.1.2
@ 2020-10-17  3:41 nilium
  2020-10-17  4:00 ` nilium
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: nilium @ 2020-10-17  3:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

There is a new pull request by nilium against master on the void-packages repository

https://github.com/nilium/ecks-bops-packages waypoint
https://github.com/void-linux/void-packages/pull/25665

New package: waypoint-0.1.2


A patch file from https://github.com/void-linux/void-packages/pull/25665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-waypoint-25665.patch --]
[-- Type: text/x-diff, Size: 1066 bytes --]

From 47a3a3cf57857b2849c56baefbde7c3b5a75126d Mon Sep 17 00:00:00 2001
From: Noel Cower <ncower@nil.dev>
Date: Fri, 16 Oct 2020 20:28:12 -0700
Subject: [PATCH] New package: waypoint-0.1.2

---
 srcpkgs/waypoint/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/waypoint/template

diff --git a/srcpkgs/waypoint/template b/srcpkgs/waypoint/template
new file mode 100644
index 000000000000..0150225b50c5
--- /dev/null
+++ b/srcpkgs/waypoint/template
@@ -0,0 +1,18 @@
+# Template file for 'waypoint'
+pkgname=waypoint
+version=0.1.2
+revision=1
+build_style=gnu-makefile
+make_build_target=bin
+hostmakedepends="git go go-bindata"
+short_desc="Tool to build, deploy, and release any application on any platform"
+maintainer="Noel Cower <ncower@nil.dev>"
+license="MPL-2.0"
+homepage="https://www.waypointproject.io"
+distfiles="https://github.com/hashicorp/waypoint/archive/v${version}.tar.gz"
+checksum=20723ab3fd8dab0fc578f2ec2d8506eacbafe1b9837ab083c82f011ed1cdd226
+
+do_install() {
+	vlicense LICENSE
+	vbin waypoint
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
@ 2020-10-17  4:00 ` nilium
  2020-10-17  4:29 ` [PR PATCH] [Updated] " nilium
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-10-17  4:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by nilium on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-710742626

Comment:
Looks like this is having trouble with ARM when hitting cgo. Still looking at it.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Updated] New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
  2020-10-17  4:00 ` nilium
@ 2020-10-17  4:29 ` nilium
  2020-10-26 21:10 ` smorimoto
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-10-17  4:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There is an updated pull request by nilium against master on the void-packages repository

https://github.com/nilium/ecks-bops-packages waypoint
https://github.com/void-linux/void-packages/pull/25665

New package: waypoint-0.1.2


A patch file from https://github.com/void-linux/void-packages/pull/25665.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-waypoint-25665.patch --]
[-- Type: text/x-diff, Size: 1385 bytes --]

From aeaf502b030bb8f469cc9c3f117589dd49d8c512 Mon Sep 17 00:00:00 2001
From: Noel Cower <ncower@nil.dev>
Date: Fri, 16 Oct 2020 20:28:12 -0700
Subject: [PATCH] New package: waypoint-0.1.2

---
 srcpkgs/waypoint/template | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 srcpkgs/waypoint/template

diff --git a/srcpkgs/waypoint/template b/srcpkgs/waypoint/template
new file mode 100644
index 00000000000..8205eae447e
--- /dev/null
+++ b/srcpkgs/waypoint/template
@@ -0,0 +1,25 @@
+# Template file for 'waypoint'
+pkgname=waypoint
+version=0.1.2
+revision=1
+build_style=go
+go_import_path=github.com/hashicorp/waypoint
+hostmakedepends="git go-bindata make"
+short_desc="Tool to build, deploy, and release any application on any platform"
+maintainer="Noel Cower <ncower@nil.dev>"
+license="MPL-2.0"
+homepage="https://www.waypointproject.io"
+distfiles="https://github.com/hashicorp/waypoint/archive/v${version}.tar.gz"
+checksum=20723ab3fd8dab0fc578f2ec2d8506eacbafe1b9837ab083c82f011ed1cdd226
+
+do_build() {
+	# Build waypoint-entry for the host architecture:
+	go build -o ./internal/assets/ceb/ceb ./cmd/waypoint-entrypoint
+	(cd internal/assets && go-bindata -pkg assets -o prod.go -tags assetsembedded ./ceb)
+	CGO_ENABLED=0 go build -tags assetsembedded -o ./waypoint ./cmd/waypoint
+}
+
+do_install() {
+	vlicense LICENSE
+	vbin waypoint
+}

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
  2020-10-17  4:00 ` nilium
  2020-10-17  4:29 ` [PR PATCH] [Updated] " nilium
@ 2020-10-26 21:10 ` smorimoto
  2020-10-27  0:27 ` nilium
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: smorimoto @ 2020-10-26 21:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-716825632

Comment:
How about now?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (2 preceding siblings ...)
  2020-10-26 21:10 ` smorimoto
@ 2020-10-27  0:27 ` nilium
  2020-11-13  4:52 ` nilium
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-10-27  0:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

New comment by nilium on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-716899877

Comment:
The ARM build problems were due to the embedded copy of the waypoint entrypoint. I've not had as much time to look into it, but as of 0.1.2 it assumed you would target x86-64 and only provided that, so I may override that and provide the same architecture as the program when embedding the entrypoint instead of doing what Hashicorp is currently doing (since it's kind of a hack as-is). You can refer to this explanation from Mitchell on their forum for more information on the entrypoint: <https://discuss.hashicorp.com/t/waypoint-entrypoint-why-is-the-embedded-entrypoint-always-linux-amd64/16112>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (3 preceding siblings ...)
  2020-10-27  0:27 ` nilium
@ 2020-11-13  4:52 ` nilium
  2020-11-13  4:52 ` [PR PATCH] [Closed]: " nilium
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-11-13  4:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by nilium on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726510684

Comment:
Closing this for now. Not convinced yet that it's worth packaging.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PR PATCH] [Closed]: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (4 preceding siblings ...)
  2020-11-13  4:52 ` nilium
@ 2020-11-13  4:52 ` nilium
  2020-11-13  5:19 ` smorimoto
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-11-13  4:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a closed pull request on the void-packages repository

New package: waypoint-0.1.2
https://github.com/void-linux/void-packages/pull/25665

Description:


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (5 preceding siblings ...)
  2020-11-13  4:52 ` [PR PATCH] [Closed]: " nilium
@ 2020-11-13  5:19 ` smorimoto
  2020-11-13  5:21 ` nilium
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: smorimoto @ 2020-11-13  5:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726520931

Comment:
​In this case, the deployment environment is limited to linux/amd64, but the executable binary for the waypoint itself should not. ​Well, I don't think most people will use it at this point, so it doesn't make much sense to package it, but I don't think it's a problem to package it without extra hacks.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (6 preceding siblings ...)
  2020-11-13  5:19 ` smorimoto
@ 2020-11-13  5:21 ` nilium
  2020-11-13  5:26 ` smorimoto
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: nilium @ 2020-11-13  5:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New comment by nilium on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726521651

Comment:
Well, the deployment environment isn't limited in practice, so the entrypoint limitation is due to a workaround right now. I'd rather wait for it to get further along than package something that I now know I don't have a use for right now.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (7 preceding siblings ...)
  2020-11-13  5:21 ` nilium
@ 2020-11-13  5:26 ` smorimoto
  2020-11-13  6:04 ` smorimoto
  2020-11-13  6:05 ` smorimoto
  10 siblings, 0 replies; 12+ messages in thread
From: smorimoto @ 2020-11-13  5:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726525131

Comment:
​Yeah, I know. ​I agree with you.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (8 preceding siblings ...)
  2020-11-13  5:26 ` smorimoto
@ 2020-11-13  6:04 ` smorimoto
  2020-11-13  6:05 ` smorimoto
  10 siblings, 0 replies; 12+ messages in thread
From: smorimoto @ 2020-11-13  6:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726541992

Comment:
​Oh, we seem to have this:

https://github.com/void-linux/void-packages/blob/0baf47ac2fad9ca82a4bdc918e7976fa9f5824d9/common/environment/build-style/go.sh#L17-L29

So this might be enough for us:

```sh
if [ -z "$GOARM" ]; then
  make bin GOARCH="$GOARCH"
else
  make bin GOARCH="$GOARCH" GOARM="$GOARM"
fi
```

https://github.com/hashicorp/waypoint/blob/ee9443811c1ac724c24b4017dba1b97f6f1018d3/Makefile#L14

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: New package: waypoint-0.1.2
  2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
                   ` (9 preceding siblings ...)
  2020-11-13  6:04 ` smorimoto
@ 2020-11-13  6:05 ` smorimoto
  10 siblings, 0 replies; 12+ messages in thread
From: smorimoto @ 2020-11-13  6:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

New comment by smorimoto on void-packages repository

https://github.com/void-linux/void-packages/pull/25665#issuecomment-726541992

Comment:
​Oh, we seem to have this:

https://github.com/void-linux/void-packages/blob/0baf47ac2fad9ca82a4bdc918e7976fa9f5824d9/common/environment/build-style/go.sh#L17-L29

So this might be enough for us:

```sh
if [ -z "$GOARM" ]; then
  make bin GOARCH="$GOARCH"
else
  make bin GOARCH="$GOARCH" GOARM="$GOARM"
fi
```

https://github.com/hashicorp/waypoint/blob/ee9443811c1ac724c24b4017dba1b97f6f1018d3/Makefile#L14

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-11-13  6:05 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-17  3:41 [PR PATCH] New package: waypoint-0.1.2 nilium
2020-10-17  4:00 ` nilium
2020-10-17  4:29 ` [PR PATCH] [Updated] " nilium
2020-10-26 21:10 ` smorimoto
2020-10-27  0:27 ` nilium
2020-11-13  4:52 ` nilium
2020-11-13  4:52 ` [PR PATCH] [Closed]: " nilium
2020-11-13  5:19 ` smorimoto
2020-11-13  5:21 ` nilium
2020-11-13  5:26 ` smorimoto
2020-11-13  6:04 ` smorimoto
2020-11-13  6:05 ` smorimoto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).