Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] R: update to 4.0.3.
@ 2020-10-16 11:31 luhann
  2020-10-16 14:34 ` [PR REVIEW] " ahesford
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: luhann @ 2020-10-16 11:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

There is a new pull request by luhann against master on the void-packages repository

https://github.com/luhann/void-packages R
https://github.com/void-linux/void-packages/pull/25653

R: update to 4.0.3.


A patch file from https://github.com/void-linux/void-packages/pull/25653.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-R-25653.patch --]
[-- Type: text/x-diff, Size: 1487 bytes --]

From fe31dd7e8a85a4dfe34cae900ea9f9aba4f380d4 Mon Sep 17 00:00:00 2001
From: Luke Hannan <luke@lukehannan.com>
Date: Fri, 16 Oct 2020 13:29:35 +0200
Subject: [PATCH] R: update to 4.0.3.

---
 common/shlibs      | 2 +-
 srcpkgs/R/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index e50e44f1246..1a6268cde73 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -2674,7 +2674,7 @@ libsmpeg-0.4.so.0 smpeg-0.4.5_3
 libsmpeg2-2.0.so.0 smpeg2-2.0.0_1
 libedac.so.1 libedac-0.18_1
 libxlsreader.so.8 libxls-1.6.1_1
-libR.so R-4.0.2_1
+libR.so R-4.0.3_1
 libmarkdown.so.2 discount-2.2.0_3
 libkeystone.so.0 keystone-0.9_1
 libmate-slab.so.0 libmate-control-center-1.14.0_2
diff --git a/srcpkgs/R/template b/srcpkgs/R/template
index 47bee4dabe0..1a272c93bc6 100644
--- a/srcpkgs/R/template
+++ b/srcpkgs/R/template
@@ -1,6 +1,6 @@
 # Template file for 'R'
 pkgname=R
-version=4.0.2
+version=4.0.3
 revision=1
 build_style=gnu-configure
 configure_args="--docdir=/usr/share/doc/R rdocdir=/usr/share/doc/R
@@ -19,7 +19,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.r-project.org/"
 changelog="https://cran.r-project.org/doc/manuals/r-release/NEWS.html"
 distfiles="https://cran.r-project.org/src/base/R-4/${pkgname}-${version}.tar.gz"
-checksum=d3bceab364da0876625e4097808b42512395fdf41292f4915ab1fd257c1bbe75
+checksum=09983a8a78d5fb6bc45d27b1c55f9ba5265f78fa54a55c13ae691f87c5bb9e0d
 nocross=yes
 shlib_provides="libR.so"
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
@ 2020-10-16 14:34 ` ahesford
  2020-10-16 14:51 ` q66
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2020-10-16 14:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/25653#discussion_r506491327

Comment:
Is there a breaking ABI change in this version of `libR.so`? If so, all of the `xrevshlib R` dependants need to be revbumped. If not, don't update `common/shlibs` with the new package version.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
  2020-10-16 14:34 ` [PR REVIEW] " ahesford
@ 2020-10-16 14:51 ` q66
  2020-10-16 14:51 ` q66
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: q66 @ 2020-10-16 14:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25653#discussion_r506506349

Comment:
updating shlibs without revbumping is actually fine but it depends on circumstances

usually you'd bump the version in shlibs if the new version introduced some API that packages are going to use (as in that case, the packages built against the newer version will require it, while packages built against the older one will keep working just fine)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
  2020-10-16 14:34 ` [PR REVIEW] " ahesford
  2020-10-16 14:51 ` q66
@ 2020-10-16 14:51 ` q66
  2020-10-16 21:47 ` luhann
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: q66 @ 2020-10-16 14:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

New review comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25653#discussion_r506506349

Comment:
updating shlibs without revbumping is actually fine but it depends on circumstances

usually you'd bump the version in shlibs if the new version introduced some API that packages are going to use (as in that case, the packages built against the newer version will require it, while packages built against the older one will keep working just fine)

but this looks like a patch release, so it shouldn't be necessary

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
                   ` (2 preceding siblings ...)
  2020-10-16 14:51 ` q66
@ 2020-10-16 21:47 ` luhann
  2020-10-16 21:51 ` [PR PATCH] [Updated] " luhann
  2020-10-17 15:57 ` [PR PATCH] [Merged]: " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: luhann @ 2020-10-16 21:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New review comment by luhann on void-packages repository

https://github.com/void-linux/void-packages/pull/25653#discussion_r506735395

Comment:
Sure, will change it. @q66 you're right there aren't any new APIs or major changes, was just unsure about whether to update shlibs when updating a package that provides them.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
                   ` (3 preceding siblings ...)
  2020-10-16 21:47 ` luhann
@ 2020-10-16 21:51 ` luhann
  2020-10-17 15:57 ` [PR PATCH] [Merged]: " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: luhann @ 2020-10-16 21:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

There is an updated pull request by luhann against master on the void-packages repository

https://github.com/luhann/void-packages R
https://github.com/void-linux/void-packages/pull/25653

R: update to 4.0.3.


A patch file from https://github.com/void-linux/void-packages/pull/25653.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-R-25653.patch --]
[-- Type: text/x-diff, Size: 1029 bytes --]

From fe5c327c2b8d374a6a97c64c58dbcb0f532e4f15 Mon Sep 17 00:00:00 2001
From: Luke Hannan <luke@lukehannan.com>
Date: Fri, 16 Oct 2020 23:51:22 +0200
Subject: [PATCH] R: update to 4.0.3.

---
 srcpkgs/R/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/R/template b/srcpkgs/R/template
index 47bee4dabe0..1a272c93bc6 100644
--- a/srcpkgs/R/template
+++ b/srcpkgs/R/template
@@ -1,6 +1,6 @@
 # Template file for 'R'
 pkgname=R
-version=4.0.2
+version=4.0.3
 revision=1
 build_style=gnu-configure
 configure_args="--docdir=/usr/share/doc/R rdocdir=/usr/share/doc/R
@@ -19,7 +19,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.r-project.org/"
 changelog="https://cran.r-project.org/doc/manuals/r-release/NEWS.html"
 distfiles="https://cran.r-project.org/src/base/R-4/${pkgname}-${version}.tar.gz"
-checksum=d3bceab364da0876625e4097808b42512395fdf41292f4915ab1fd257c1bbe75
+checksum=09983a8a78d5fb6bc45d27b1c55f9ba5265f78fa54a55c13ae691f87c5bb9e0d
 nocross=yes
 shlib_provides="libR.so"
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: R: update to 4.0.3.
  2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
                   ` (4 preceding siblings ...)
  2020-10-16 21:51 ` [PR PATCH] [Updated] " luhann
@ 2020-10-17 15:57 ` ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2020-10-17 15:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

There's a merged pull request on the void-packages repository

R: update to 4.0.3.
https://github.com/void-linux/void-packages/pull/25653

Description:


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-10-17 15:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16 11:31 [PR PATCH] R: update to 4.0.3 luhann
2020-10-16 14:34 ` [PR REVIEW] " ahesford
2020-10-16 14:51 ` q66
2020-10-16 14:51 ` q66
2020-10-16 21:47 ` luhann
2020-10-16 21:51 ` [PR PATCH] [Updated] " luhann
2020-10-17 15:57 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).