From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] krita: update to 4.4.0.
Date: Sun, 18 Oct 2020 14:10:35 +0200 [thread overview]
Message-ID: <20201018121035.0rusrPH2zk-WnS14fz6XLvs01pt7hFyRVNVhMSJl1dI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25651@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/25651#discussion_r507119632
Comment:
No need to escape a newline in a quoted string. Also don't hard disable tests. add smth like
```
if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -DBUILD_TESTS=ON"
else
configure_args+=" -DBUILD_TESTS=OFF"
fi
```
after checksum and
```
do_check() {
cd build
# BlockTests requires llvm, we don't build it with llvm
ctest -E 'BlockTests'
}
post_install() {
[ -d "${DESTDIR}/usr/share/test/SeExpr2" ] && rm -r "${DESTDIR}/usr/share/test/SeExpr2" || true
}
```
after pre_configure
next prev parent reply other threads:[~2020-10-18 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:50 [PR PATCH] " kartikynwa
2020-10-16 9:52 ` [PR PATCH] [Updated] " kartikynwa
2020-10-18 12:10 ` [PR REVIEW] " Johnnynator
2020-10-18 12:10 ` Johnnynator
2020-10-18 12:10 ` Johnnynator [this message]
2020-10-18 18:31 ` kartikynwa
2020-10-18 18:32 ` kartikynwa
2020-10-20 14:38 ` [PR PATCH] [Updated] " kartikynwa
2020-10-20 14:42 ` kartikynwa
2020-10-22 9:55 ` [PR PATCH] [Merged]: " Johnnynator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018121035.0rusrPH2zk-WnS14fz6XLvs01pt7hFyRVNVhMSJl1dI@z \
--to=johnnynator@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).