From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] go-ipfs: add runit service.
Date: Wed, 21 Oct 2020 22:25:31 +0200 [thread overview]
Message-ID: <20201021202531.BjDGHuewQiEbMJqJK-uFNQwmP3XHMfsdCoXfEXIvrMw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25777@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
New review comment by jcgruenhage on void-packages repository
https://github.com/void-linux/void-packages/pull/25777#discussion_r509665892
Comment:
These are the default directories for the ipfs mounts, I'm not 100% happy here. We could also take the initialising apart instead of doing it idempotently in the daemon command, which would allow us configure the daemon after initialising it, which in turn enables us to use custom paths here. What would the right place here be? `/var/run/go-ipfs/<ipfs/ipns>` or `/var/lib/go-ipfs/<ipfs/ipns>` is what I'd say, but I'm not 100% sure on this.
next prev parent reply other threads:[~2020-10-21 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 20:20 [PR PATCH] " jcgruenhage
2020-10-21 20:25 ` jcgruenhage [this message]
2020-10-21 21:09 ` [PR REVIEW] " sirikid
2020-10-22 21:46 ` jcgruenhage
2020-10-22 22:36 ` [PR PATCH] [Updated] " jcgruenhage
2020-10-22 23:37 ` [PR PATCH] [Updated] go-ipfs: add runit service and use vcompletion jcgruenhage
2020-10-23 11:00 ` jcgruenhage
2020-10-23 11:10 ` [PR REVIEW] " Duncaen
2020-10-23 11:28 ` [PR PATCH] [Updated] " jcgruenhage
2020-10-23 11:28 ` [PR REVIEW] " jcgruenhage
2020-10-24 21:06 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021202531.BjDGHuewQiEbMJqJK-uFNQwmP3XHMfsdCoXfEXIvrMw@z \
--to=jcgruenhage@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).