From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: salt: update to 3002
Date: Sun, 25 Oct 2020 02:20:03 +0100 [thread overview]
Message-ID: <20201025012003.teVqSNMnFxppRlEwwbhCRBdoek993pVSG-M28ArSEy8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25860@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 981 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25860#issuecomment-716078424
Comment:
This patch hasn't been accepted upstream, but I've reviewed what's happening here and don't have a problem with it. The issue is that the custom `IPv6AddressScoped` subclass of `ipaddress.IPv6Address` in the standard library does not use the superclass initializer, and in Python 3.9, the superclass defines a read-only `scope_id` backed by a private `_scope_id` attribute created in the initializer. This private attribute is referenced when computing a hash of the `IPv6Address` object.
The proposed patch appears to set the private attribute the same way the superclass initializer would if that initializer were used. If upstream accepts the patch, we should see it folded into a future release; otherwise, I would expect upstream to refactor the subclass to avoid this issue with Python 3.9. For now, let's get the package working.
next prev parent reply other threads:[~2020-10-25 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:52 [PR PATCH] " Noah-Huppert
2020-10-25 1:20 ` ahesford [this message]
2020-10-25 1:20 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025012003.teVqSNMnFxppRlEwwbhCRBdoek993pVSG-M28ArSEy8@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).