Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] grub: build manpages.
@ 2020-10-02  5:13 ericonr
  2020-10-02  5:15 ` ericonr
                   ` (28 more replies)
  0 siblings, 29 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  5:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages grub
https://github.com/void-linux/void-packages/pull/25267

grub: build manpages.
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

A patch file from https://github.com/void-linux/void-packages/pull/25267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-25267.patch --]
[-- Type: text/x-diff, Size: 852 bytes --]

From 330833455e751dd852df13a386de7d6cad16c772 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 2 Oct 2020 02:11:45 -0300
Subject: [PATCH] grub: build manpages.

Requires help2man.
---
 srcpkgs/grub/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index 77c6cfbff2f..00d2cd5fcfe 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,8 +1,8 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=3
-hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
+revision=4
+hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
 depends="os-prober"

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
@ 2020-10-02  5:15 ` ericonr
  2020-10-02  5:39 ` [PR PATCH] [Updated] " ericonr
                   ` (27 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  5:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702529370

Comment:
Do we patch as well? https://github.com/archlinux/svntogit-packages/blob/65e61c7a5c438797a211395a9ae6fc79090b21ec/trunk/0006-BootHole.patch

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR PATCH] [Updated] grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
  2020-10-02  5:15 ` ericonr
@ 2020-10-02  5:39 ` ericonr
  2020-10-02  5:43 ` ericonr
                   ` (26 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  5:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages grub
https://github.com/void-linux/void-packages/pull/25267

grub: build manpages.
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

A patch file from https://github.com/void-linux/void-packages/pull/25267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-25267.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 10ded64be7666def85972b59e90255bb1faa3c6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 2 Oct 2020 02:11:45 -0300
Subject: [PATCH] grub: build manpages, remove noarch.

Requires help2man.
---
 etc/xbps.d/repos-remote.conf | 6 +++---
 srcpkgs/grub/template        | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/etc/xbps.d/repos-remote.conf b/etc/xbps.d/repos-remote.conf
index 47c867ecac0..5ad05c4ba76 100644
--- a/etc/xbps.d/repos-remote.conf
+++ b/etc/xbps.d/repos-remote.conf
@@ -1,4 +1,4 @@
 # voidlinux remote repositories (glibc)
-repository=https://alpha.de.repo.voidlinux.org/current
-repository=https://alpha.de.repo.voidlinux.org/current/nonfree
-repository=https://alpha.de.repo.voidlinux.org/current/debug
+repository=https://mirror.clarkson.edu/voidlinux/current
+repository=https://mirror.clarkson.edu/voidlinux/current/nonfree
+repository=https://mirror.clarkson.edu/voidlinux/current/debug
diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index 77c6cfbff2f..00d2cd5fcfe 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,8 +1,8 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=3
-hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
+revision=4
+hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
 depends="os-prober"

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR PATCH] [Updated] grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
  2020-10-02  5:15 ` ericonr
  2020-10-02  5:39 ` [PR PATCH] [Updated] " ericonr
@ 2020-10-02  5:43 ` ericonr
  2020-10-02  5:59 ` [PR REVIEW] " ericonr
                   ` (25 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  5:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages grub
https://github.com/void-linux/void-packages/pull/25267

grub: build manpages.
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

A patch file from https://github.com/void-linux/void-packages/pull/25267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-25267.patch --]
[-- Type: text/x-diff, Size: 2522 bytes --]

From 9c900dee6b586761700cfad5e7d27ffca6f9eddc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 2 Oct 2020 02:11:45 -0300
Subject: [PATCH] grub: build manpages, remove noarch.

Requires help2man.
---
 etc/xbps.d/repos-remote.conf | 6 +++---
 srcpkgs/grub/template        | 9 ++-------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/etc/xbps.d/repos-remote.conf b/etc/xbps.d/repos-remote.conf
index 47c867ecac0..5ad05c4ba76 100644
--- a/etc/xbps.d/repos-remote.conf
+++ b/etc/xbps.d/repos-remote.conf
@@ -1,4 +1,4 @@
 # voidlinux remote repositories (glibc)
-repository=https://alpha.de.repo.voidlinux.org/current
-repository=https://alpha.de.repo.voidlinux.org/current/nonfree
-repository=https://alpha.de.repo.voidlinux.org/current/debug
+repository=https://mirror.clarkson.edu/voidlinux/current
+repository=https://mirror.clarkson.edu/voidlinux/current/nonfree
+repository=https://mirror.clarkson.edu/voidlinux/current/debug
diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index 77c6cfbff2f..b73b0626b16 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,8 +1,8 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=3
-hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
+revision=4
+hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
 depends="os-prober"
@@ -162,7 +162,6 @@ grub-utils_package() {
 	}
 }
 grub-x86_64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - x86_64 EFI support"
 	pkg_install() {
@@ -170,7 +169,6 @@ grub-x86_64-efi_package() {
 	}
 }
 grub-i386-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - i386 EFI support"
 	pkg_install() {
@@ -178,7 +176,6 @@ grub-i386-efi_package() {
 	}
 }
 grub-i386-coreboot_package() {
-	archs=noarch
 	depends="grub>=$version"
 	short_desc+=" - i386 coreboot support"
 	pkg_install() {
@@ -200,7 +197,6 @@ grub-xen_package() {
 	}
 }
 grub-arm64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - arm64 EFI support"
 	pkg_install() {
@@ -208,7 +204,6 @@ grub-arm64-efi_package() {
 	}
 }
 grub-powerpc-ieee1275_package() {
-	archs=noarch
 	depends="grub>=$version powerpc-utils"
 	short_desc+=" - powerpc Open Firmware support"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR REVIEW] grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (2 preceding siblings ...)
  2020-10-02  5:43 ` ericonr
@ 2020-10-02  5:59 ` ericonr
  2020-10-02  6:00 ` [PR PATCH] [Updated] " ericonr
                   ` (24 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  5:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#discussion_r498629145

Comment:
Goddamnit

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR PATCH] [Updated] grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (3 preceding siblings ...)
  2020-10-02  5:59 ` [PR REVIEW] " ericonr
@ 2020-10-02  6:00 ` ericonr
  2020-10-02  7:24 ` pullmoll
                   ` (23 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  6:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages grub
https://github.com/void-linux/void-packages/pull/25267

grub: build manpages.
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

A patch file from https://github.com/void-linux/void-packages/pull/25267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-25267.patch --]
[-- Type: text/x-diff, Size: 1864 bytes --]

From f35dfa72b058a31d5388657c47e864584ad9d66c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 2 Oct 2020 02:11:45 -0300
Subject: [PATCH] grub: build manpages, remove noarch.

Requires help2man.
---
 srcpkgs/grub/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index 77c6cfbff2f..b73b0626b16 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,8 +1,8 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=3
-hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
+revision=4
+hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
 depends="os-prober"
@@ -162,7 +162,6 @@ grub-utils_package() {
 	}
 }
 grub-x86_64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - x86_64 EFI support"
 	pkg_install() {
@@ -170,7 +169,6 @@ grub-x86_64-efi_package() {
 	}
 }
 grub-i386-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - i386 EFI support"
 	pkg_install() {
@@ -178,7 +176,6 @@ grub-i386-efi_package() {
 	}
 }
 grub-i386-coreboot_package() {
-	archs=noarch
 	depends="grub>=$version"
 	short_desc+=" - i386 coreboot support"
 	pkg_install() {
@@ -200,7 +197,6 @@ grub-xen_package() {
 	}
 }
 grub-arm64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - arm64 EFI support"
 	pkg_install() {
@@ -208,7 +204,6 @@ grub-arm64-efi_package() {
 	}
 }
 grub-powerpc-ieee1275_package() {
-	archs=noarch
 	depends="grub>=$version powerpc-utils"
 	short_desc+=" - powerpc Open Firmware support"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (4 preceding siblings ...)
  2020-10-02  6:00 ` [PR PATCH] [Updated] " ericonr
@ 2020-10-02  7:24 ` pullmoll
  2020-10-02  7:24 ` pullmoll
                   ` (22 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: pullmoll @ 2020-10-02  7:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702572191

Comment:
Hmm.. AFAIR we need `grub-x86_64-efi` on `i686` also, but when it becomes an `x86_64` instead of a `noarch` package, you won't be able to manually add it to the `i686-repodata` any longer. I don't know whether it is wrong in the first place to expect `grub-x86_64-efi` being available for `i686`, though.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (5 preceding siblings ...)
  2020-10-02  7:24 ` pullmoll
@ 2020-10-02  7:24 ` pullmoll
  2020-10-02  7:27 ` ericonr
                   ` (21 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: pullmoll @ 2020-10-02  7:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702572191

Comment:
Hmm.. AFAIR for live ISOs we need `grub-x86_64-efi` on `i686` also, but when it becomes an `x86_64` instead of a `noarch` package, you won't be able to manually add it to the `i686-repodata` any longer. I don't know whether it is wrong in the first place to expect `grub-x86_64-efi` being available for `i686`, though.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (6 preceding siblings ...)
  2020-10-02  7:24 ` pullmoll
@ 2020-10-02  7:27 ` ericonr
  2020-10-02  7:31 ` pullmoll
                   ` (20 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  7:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702573296

Comment:
Indeed! It seems to be expected here: https://github.com/void-linux/void-mklive/blob/master/build-x86-images.sh.in#L31

Not sure how best to deal with it, then.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (7 preceding siblings ...)
  2020-10-02  7:27 ` ericonr
@ 2020-10-02  7:31 ` pullmoll
  2020-10-02  7:32 ` pullmoll
                   ` (19 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: pullmoll @ 2020-10-02  7:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702575055

Comment:
It may be required for the case when you want to boot an `i686` ISO image on `x86_64` UEFI hardware!?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (8 preceding siblings ...)
  2020-10-02  7:31 ` pullmoll
@ 2020-10-02  7:32 ` pullmoll
  2020-10-02  7:35 ` ericonr
                   ` (18 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: pullmoll @ 2020-10-02  7:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702575055

Comment:
It may be required for the case when you want to boot an `i686` ISO image on `x86_64` UEFI hardware!?
We cannot cross compile or assemble from i686 to x86_64, or do we?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (9 preceding siblings ...)
  2020-10-02  7:32 ` pullmoll
@ 2020-10-02  7:35 ` ericonr
  2020-10-02  8:43 ` fosslinux
                   ` (17 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02  7:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702576363

Comment:
> It may be required for the case when you want to boot an i686 ISO image on x86_64 UEFI hardware!?

I don't think so, that _should_ be possible with 32bit GRUB. I will try to build an ISO with only 32bit grub, tho.

> We cannot cross compile or assemble from i686 to x86_64, or do we?

I think we can, the cross toolchain should be there. No idea how easy it will be to plug it in, though.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (10 preceding siblings ...)
  2020-10-02  7:35 ` ericonr
@ 2020-10-02  8:43 ` fosslinux
  2020-10-02  8:58 ` fosslinux
                   ` (16 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-10-02  8:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702604928

Comment:
Um, how about we drop the `noarch` removal out of this PR, I have an idea of how this would work.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (11 preceding siblings ...)
  2020-10-02  8:43 ` fosslinux
@ 2020-10-02  8:58 ` fosslinux
  2020-10-02 12:28 ` ericonr
                   ` (15 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-10-02  8:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702611446

Comment:
Although if @ericonr is going to test the ISO please do :)

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (12 preceding siblings ...)
  2020-10-02  8:58 ` fosslinux
@ 2020-10-02 12:28 ` ericonr
  2020-10-25 19:38 ` ericonr
                   ` (14 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-02 12:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-702706241

Comment:
> Um, how about we drop the noarch removal out of this PR, I have an idea of how this would work.

If possible I'd like to make GRUB stuff happen at once. It's a fragile package, no need to update it multiple times.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (13 preceding siblings ...)
  2020-10-02 12:28 ` ericonr
@ 2020-10-25 19:38 ` ericonr
  2020-11-30  4:04 ` q66
                   ` (13 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-10-25 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-716200204

Comment:
I forgot to update here, I tried booting an i686 image without the 64bit GRUB, didn't work in my case.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (14 preceding siblings ...)
  2020-10-25 19:38 ` ericonr
@ 2020-11-30  4:04 ` q66
  2020-11-30  4:09 ` q66
                   ` (12 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: q66 @ 2020-11-30  4:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-735532118

Comment:
? how is this supposed to work in the first place? even in the case where `grub-x86_64-efi` is `noarch`, it won't be added into `i686` index either way, so why does it matter

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (15 preceding siblings ...)
  2020-11-30  4:04 ` q66
@ 2020-11-30  4:09 ` q66
  2020-11-30  4:10 ` ericonr
                   ` (11 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: q66 @ 2020-11-30  4:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-735533141

Comment:
i just checked and it is present in the `i686-repodata`, which sounds like something is terribly broken in our system and we've somehow been relying on it all along

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (16 preceding siblings ...)
  2020-11-30  4:09 ` q66
@ 2020-11-30  4:10 ` ericonr
  2020-12-01  9:14 ` fosslinux
                   ` (10 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-11-30  4:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-735533233

Comment:
Indeed it is present, and mklive relies on this, at the moment.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (17 preceding siblings ...)
  2020-11-30  4:10 ` ericonr
@ 2020-12-01  9:14 ` fosslinux
  2020-12-01 13:21 ` ericonr
                   ` (9 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-12-01  9:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736333449

Comment:
How exactly does mklive rely on this?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (18 preceding siblings ...)
  2020-12-01  9:14 ` fosslinux
@ 2020-12-01 13:21 ` ericonr
  2020-12-02  0:34 ` fosslinux
                   ` (8 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-12-01 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736547568

Comment:
The x86_64 and the i686 images include 32bit and 64bit GRUB for EFI. So you (currently) need to have 64bit GRUB in the i686 repo.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (19 preceding siblings ...)
  2020-12-01 13:21 ` ericonr
@ 2020-12-02  0:34 ` fosslinux
  2020-12-02  1:08 ` ericonr
                   ` (7 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-12-02  0:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736910004

Comment:
And what is the problem with just having 32 bit GRUB on i686 and 64 bit on x86_64?

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (20 preceding siblings ...)
  2020-12-02  0:34 ` fosslinux
@ 2020-12-02  1:08 ` ericonr
  2020-12-02  1:14 ` fosslinux
                   ` (6 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-12-02  1:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736920755

Comment:
Makes it somewhat impossible to boot i686 images on x86_64 systems using EFI. If you can fallback to BIOS or enter compat mode, it still works.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (21 preceding siblings ...)
  2020-12-02  1:08 ` ericonr
@ 2020-12-02  1:14 ` fosslinux
  2020-12-02  3:36 ` ericonr
                   ` (5 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-12-02  1:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736922690

Comment:
Oh, unfortunate. Is it possible to build x86_64-efi for i686? If not, maybe that's not something we should support at all, i686 on x86_64 is not a common thing and if someone has an isolated usecase for that using the BIOS instead of UEFI is probably the better bet anyway. 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (22 preceding siblings ...)
  2020-12-02  1:14 ` fosslinux
@ 2020-12-02  3:36 ` ericonr
  2020-12-02  6:28 ` fosslinux
                   ` (4 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-12-02  3:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-736968329

Comment:
> If not, maybe that's not something we should support at all, i686 on x86_64 is not a common thing and if someone has an isolated usecase for that using the BIOS instead of UEFI is probably the better bet anyway.

That's mostly what @q66 argued. I would still like to support that specific use case, but I'm not eager to do the work for it. I think we can test if that support is necessary once we release new ISOs and people start complaining (or not) about it not working for them.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (23 preceding siblings ...)
  2020-12-02  3:36 ` ericonr
@ 2020-12-02  6:28 ` fosslinux
  2020-12-02 19:24 ` [PR PATCH] [Updated] " ericonr
                   ` (3 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: fosslinux @ 2020-12-02  6:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-737022615

Comment:
How about we just drop noarch then for now and figure out if we need to put the work in later.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR PATCH] [Updated] grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (24 preceding siblings ...)
  2020-12-02  6:28 ` fosslinux
@ 2020-12-02 19:24 ` ericonr
  2020-12-02 19:25 ` ericonr
                   ` (2 subsequent siblings)
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-12-02 19:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages grub
https://github.com/void-linux/void-packages/pull/25267

grub: build manpages.
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

A patch file from https://github.com/void-linux/void-packages/pull/25267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-grub-25267.patch --]
[-- Type: text/x-diff, Size: 2262 bytes --]

From 7dcd6b75ebf81c6af8e96060432e94a2304a8315 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Fri, 2 Oct 2020 02:11:45 -0300
Subject: [PATCH] grub: remove noarch, build manpages.

This commit will make it so the i686 repository won't have
grub-x86_64-efi available, which is something that void-mklive depended
on. Seeing as the use case where that's necessary is rare (booting i686
ISOs on x86_64 machines using EFI), we are going to stop supporting it
for now. If necessary, this change can be revisited in order to allow
building grub-x86_64-efi for i686.

Building manpages requires help2man.
---
 srcpkgs/grub/template | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/grub/template b/srcpkgs/grub/template
index 77c6cfbff2f..b73b0626b16 100644
--- a/srcpkgs/grub/template
+++ b/srcpkgs/grub/template
@@ -1,8 +1,8 @@
 # Template file for 'grub'
 pkgname=grub
 version=2.04
-revision=3
-hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf"
+revision=4
+hostmakedepends="python3 pkg-config flex freetype-devel font-unifont-bdf help2man"
 makedepends="libusb-compat-devel ncurses-devel freetype-devel
  liblzma-devel device-mapper-devel fuse-devel"
 depends="os-prober"
@@ -162,7 +162,6 @@ grub-utils_package() {
 	}
 }
 grub-x86_64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - x86_64 EFI support"
 	pkg_install() {
@@ -170,7 +169,6 @@ grub-x86_64-efi_package() {
 	}
 }
 grub-i386-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - i386 EFI support"
 	pkg_install() {
@@ -178,7 +176,6 @@ grub-i386-efi_package() {
 	}
 }
 grub-i386-coreboot_package() {
-	archs=noarch
 	depends="grub>=$version"
 	short_desc+=" - i386 coreboot support"
 	pkg_install() {
@@ -200,7 +197,6 @@ grub-xen_package() {
 	}
 }
 grub-arm64-efi_package() {
-	archs=noarch
 	depends="grub>=$version dosfstools efibootmgr"
 	short_desc+=" - arm64 EFI support"
 	pkg_install() {
@@ -208,7 +204,6 @@ grub-arm64-efi_package() {
 	}
 }
 grub-powerpc-ieee1275_package() {
-	archs=noarch
 	depends="grub>=$version powerpc-utils"
 	short_desc+=" - powerpc Open Firmware support"
 	pkg_install() {

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (25 preceding siblings ...)
  2020-12-02 19:24 ` [PR PATCH] [Updated] " ericonr
@ 2020-12-02 19:25 ` ericonr
  2021-01-04  2:09 ` grub: remove noarch, " ericonr
  2021-01-04  2:09 ` [PR PATCH] [Closed]: " ericonr
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2020-12-02 19:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-737444321

Comment:
Updated commit message.

I think we should fix void-mklive first, and then I can refer to the change in it in the commit message as well.

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: grub: remove noarch, build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (26 preceding siblings ...)
  2020-12-02 19:25 ` ericonr
@ 2021-01-04  2:09 ` ericonr
  2021-01-04  2:09 ` [PR PATCH] [Closed]: " ericonr
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-04  2:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25267#issuecomment-753721055

Comment:
Closing in favor of #26895 

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PR PATCH] [Closed]: grub: remove noarch, build manpages.
  2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
                   ` (27 preceding siblings ...)
  2021-01-04  2:09 ` grub: remove noarch, " ericonr
@ 2021-01-04  2:09 ` ericonr
  28 siblings, 0 replies; 30+ messages in thread
From: ericonr @ 2021-01-04  2:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

There's a closed pull request on the void-packages repository

grub: remove noarch, build manpages.
https://github.com/void-linux/void-packages/pull/25267

Description:
Requires help2man.

I think we should have grub man pages in man.voidlinux.org, because their documentation is kinda bad overall.

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2021-01-04  2:09 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02  5:13 [PR PATCH] grub: build manpages ericonr
2020-10-02  5:15 ` ericonr
2020-10-02  5:39 ` [PR PATCH] [Updated] " ericonr
2020-10-02  5:43 ` ericonr
2020-10-02  5:59 ` [PR REVIEW] " ericonr
2020-10-02  6:00 ` [PR PATCH] [Updated] " ericonr
2020-10-02  7:24 ` pullmoll
2020-10-02  7:24 ` pullmoll
2020-10-02  7:27 ` ericonr
2020-10-02  7:31 ` pullmoll
2020-10-02  7:32 ` pullmoll
2020-10-02  7:35 ` ericonr
2020-10-02  8:43 ` fosslinux
2020-10-02  8:58 ` fosslinux
2020-10-02 12:28 ` ericonr
2020-10-25 19:38 ` ericonr
2020-11-30  4:04 ` q66
2020-11-30  4:09 ` q66
2020-11-30  4:10 ` ericonr
2020-12-01  9:14 ` fosslinux
2020-12-01 13:21 ` ericonr
2020-12-02  0:34 ` fosslinux
2020-12-02  1:08 ` ericonr
2020-12-02  1:14 ` fosslinux
2020-12-02  3:36 ` ericonr
2020-12-02  6:28 ` fosslinux
2020-12-02 19:24 ` [PR PATCH] [Updated] " ericonr
2020-12-02 19:25 ` ericonr
2021-01-04  2:09 ` grub: remove noarch, " ericonr
2021-01-04  2:09 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).