From: pullmoll <pullmoll@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ISSUE] [CLOSED] FTBFS: qt5-webkit broken since bison-3.7.3
Date: Mon, 26 Oct 2020 13:04:36 +0100 [thread overview]
Message-ID: <20201026120436.mBIwqdMGKCh33V9sEjr9W98TmFHTXLxVppMNlFDZv0Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25876@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
Closed issue by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/issues/25876
Description:
The update of `bison-3.7.3` broke the `qt5-webkit` build. It seems to be related to the automagically chosen filename for the header files with defines, i.e. the `-d` option of bison. The newer bison's choice for a name is obviously not what the perl script expects.
I tried to patch `Source/WebCore/css/makegrammar.pl` to cure that - to no avail. Here's my patch:
```
--- Source/WebCore/css/makegrammar.pl 2020-04-14 00:51:51.000000000 +0200
+++ Source/WebCore/css/makegrammar.pl 2020-10-25 14:59:39.879927464 +0100
@@ -73,7 +73,6 @@
}
my $fileBase = File::Spec->join($outputDir, $filename);
-my @bisonCommand = ($bison, "-d", "-p", $symbolsPrefix, $grammarFilePath, "-o", "$fileBase.cpp");
+my @bisonCommand = ($bison, "--no-lines", "--defines=$fileBase.hpp", "-p", $symbolsPrefix, $grammarFilePath
, "-o", $fileBase.cpp);
-push @bisonCommand, "--no-lines" if $^O eq "MSWin32"; # Work around bug in bison >= 3.0 on Windows where it
puts backslashes into #line directives.
system(@bisonCommand) == 0 or die;
--- Source/WebCore/css/CSSGrammar.y.in 2020-04-14 00:51:51.000000000 +0200
+++ Source/WebCore/css/CSSGrammar.y.in 2020-10-25 15:35:20.818799854 +0100
@@ -21,7 +21,7 @@
*
*/
-%pure-parser
+%define api.pure
%parse-param { CSSParser* parser }
%lex-param { CSSParser* parser }
```
Now the previously missing `XPathGrammar.hpp` is created yet the file `CSSGrammar.h` is still missing and the build fails with:
```
In file included from /builddir/qtwebkit-opensource-src-5.212/Source/WebCore/css/CSSAllInOne.cpp:69:
/builddir/qtwebkit-opensource-src-5.212/Source/WebCore/css/CSSParser.cpp:11161:10: fatal error: CSSGrammar.h
: No such file or directory
11161 | #include "CSSGrammar.h"
| ^~~~~~~~~~~~~~
compilation terminated.
```
Note: I also tried `--defines=$fileBase.cpp.h` which is an alternative name for the input file which is read and wrapped in `makegrammar.pl` a few lines below the patch. I also tried with and without changing the obsolete `%pure-parser` to `%define api.pure`.
If anyone has a better knowledge of bison/yacc and how to fix the perl script please help fixing this issue.
prev parent reply other threads:[~2020-10-26 12:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 15:05 [ISSUE] " pullmoll
2020-10-26 12:04 ` pullmoll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026120436.mBIwqdMGKCh33V9sEjr9W98TmFHTXLxVppMNlFDZv0Y@z \
--to=pullmoll@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).