From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] azote: update to 1.8.1
Date: Mon, 26 Oct 2020 20:15:33 +0100 [thread overview]
Message-ID: <20201026191533.TxnVjjf3Yedye_W2zzEMocCSHqjRAeh2kFA81zRfEP8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25903@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25903#discussion_r512207346
Comment:
Please drop the following packages from the dependencies:
- [ ] xrandr
- [ ] feh
- [ ] python3-send2trash
- [ ] grim
- [ ] slurp
- [ ] ImageMagick
- [ ] python3-yaml
- [ ] python3-setuptools
All but the last enable optional functionality, and the program itself provides a warning about missing packages and disabled functionality when users run without these packages installed. There is no need to pull in everything by force, especially the `xrandr` dependency for Wayland users, or the `grim` and `slurp` dependencies for Xorg users.
The last dependency is strictly wrong, as `setuptools` is not needed anywhere for runtime operation of `azote`.
next prev parent reply other threads:[~2020-10-26 19:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:00 [PR PATCH] " georgianfire
2020-10-26 19:01 ` [PR REVIEW] " georgianfire
2020-10-26 19:15 ` ahesford [this message]
2020-10-26 19:22 ` [PR PATCH] [Updated] " georgianfire
2020-10-26 19:22 ` [PR REVIEW] " georgianfire
2020-10-26 19:23 ` [PR PATCH] [Updated] " georgianfire
2020-10-26 22:14 ` [PR REVIEW] " Chocimier
2020-10-26 22:43 ` Chocimier
2020-10-26 22:43 ` Chocimier
2020-10-26 23:07 ` ahesford
2020-10-26 23:32 ` [PR PATCH] [Updated] " georgianfire
2020-10-26 23:34 ` [PR REVIEW] " georgianfire
2020-10-26 23:35 ` georgianfire
2020-10-26 23:36 ` [PR PATCH] [Updated] " georgianfire
2020-10-26 23:37 ` [PR REVIEW] " georgianfire
2020-10-26 23:37 ` georgianfire
2020-10-26 23:39 ` georgianfire
2020-10-27 15:24 ` ahesford
2020-10-27 15:36 ` [PR PATCH] [Updated] " georgianfire
2020-10-27 15:40 ` [PR REVIEW] " georgianfire
2020-10-29 14:28 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026191533.TxnVjjf3Yedye_W2zzEMocCSHqjRAeh2kFA81zRfEP8@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).