Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] perl: set stack size for musl.
Date: Tue, 27 Oct 2020 01:06:39 +0100	[thread overview]
Message-ID: <20201027000639.E9WyLedczi04iQ4jnCFgUpq7o10vyT0TQhoq8czBd7g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25899@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages perl
https://github.com/void-linux/void-packages/pull/25899

perl: set stack size for musl.
Threaded perl programs can go over musl's default stack size, so setting
a bigger one in LDFLAGS is necessary to avoid segfaults. This segfault
was observed when using gscan2pdf to open an image.

@leahneukirchen 

A patch file from https://github.com/void-linux/void-packages/pull/25899.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-25899.patch --]
[-- Type: text/x-diff, Size: 1589 bytes --]

From 99227266427e5142d691ff2f24adc10ad691e9fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Mon, 26 Oct 2020 10:33:51 -0300
Subject: [PATCH] perl: set stack size for musl.

Threaded perl programs can go over musl's default stack size, so setting
a bigger one in LDFLAGS is necessary to avoid segfaults. This segfault
was observed when using gscan2pdf to open an image.

Also xlint.
---
 srcpkgs/perl/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/perl/template b/srcpkgs/perl/template
index 00b402b1b8e..33595c5688d 100644
--- a/srcpkgs/perl/template
+++ b/srcpkgs/perl/template
@@ -1,7 +1,7 @@
 # Template file for 'perl'
 pkgname=perl
 version=5.30.3
-revision=1
+revision=2
 _perl_cross_version=1.3.1
 build_style=gnu-configure
 hostmakedepends="less"
@@ -10,7 +10,7 @@ depends="less"
 checkdepends="iana-etc perl-AnyEvent perl-Test-Pod procps-ng"
 short_desc="Practical Extraction and Report Language"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
-license="Artistic-1.0-perl, GPL-1.0-or-later"
+license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://www.perl.org"
 distfiles="https://www.cpan.org/src/5.0/perl-${version}.tar.gz
  https://github.com/arsv/perl-cross/releases/download/${_perl_cross_version}/perl-cross-${_perl_cross_version}.tar.gz"
@@ -164,7 +164,7 @@ do_configure() {
 		_args+=" --target=$XBPS_CROSS_TRIPLET"
 	fi
 
-	LDFLAGS+=" -pthread"
+	LDFLAGS+=" -Wl,-z,stack-size=2097152 -pthread"
 	export HOSTLDFLAGS+=" -pthread"
 
 	if [ "$XBPS_TARGET_LIBC" = "musl" ]; then

  parent reply	other threads:[~2020-10-27  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 13:36 [PR PATCH] " ericonr
2020-10-26 13:42 ` ericonr
2020-10-27  0:06 ` ericonr [this message]
2020-10-27  0:07 ` ericonr
2020-10-27  0:07 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027000639.E9WyLedczi04iQ4jnCFgUpq7o10vyT0TQhoq8czBd7g@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).