Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: avra-1.4.2
Date: Fri, 30 Oct 2020 14:55:56 +0100	[thread overview]
Message-ID: <20201030135556.LDbcafu2f4PjIaaKqi5auL_cu-TzB174SZchOvvEUc8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25942@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25942#issuecomment-719565697

Comment:
We don't need that patch, and that patch doesn't correctly define the version, try this:
```sh
avra --version
```

Apply this into the template instead

```diff
 srcpkgs/avra/template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/srcpkgs/avra/template b/srcpkgs/avra/template
index 9c95ef26da..40a6c9708f 100644
--- a/srcpkgs/avra/template
+++ b/srcpkgs/avra/template
@@ -9,3 +9,5 @@ license="GPL-2.0-only"
 homepage="https://github.com/Ro5bert/avra"
 distfiles="https://github.com/Ro5bert/${pkgname}/archive/${version}.tar.gz"
 checksum=cc56837be973d1a102dc6936a0b7235a1d716c0f7cd053bf77e0620577cff986
+
+CFLAGS="-DVERSION=\\\"$version\\\""
```


  parent reply	other threads:[~2020-10-30 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 17:22 [PR PATCH] " Logarithmus
2020-10-28 18:18 ` ericonr
2020-10-28 23:00 ` [PR PATCH] [Updated] " Logarithmus
2020-10-28 23:01 ` Logarithmus
2020-10-30 13:53 ` sgn
2020-10-30 13:55 ` sgn [this message]
2020-10-30 21:30 ` [PR PATCH] [Updated] " Logarithmus
2020-10-30 21:32 ` Logarithmus
2020-10-31  1:31 ` sgn
2020-11-01  2:23 ` [PR REVIEW] " ericonr
2020-11-02 16:15 ` [PR PATCH] [Updated] " Logarithmus
2020-11-11  1:43 ` Logarithmus
2020-11-11  2:13 ` Logarithmus
2020-12-16 16:53 ` [PR PATCH] [Merged]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030135556.LDbcafu2f4PjIaaKqi5auL_cu-TzB174SZchOvvEUc8@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).