From: save-buffer <save-buffer@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] verilator: create package
Date: Fri, 30 Oct 2020 19:37:13 +0100 [thread overview]
Message-ID: <20201030183713.K_nWlYk3ZvAjUkI18yy2DzF_PnlQXRsmMK65RueeZ6I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-25979@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
There is an updated pull request by save-buffer against master on the void-packages repository
https://github.com/save-buffer/void-packages master
https://github.com/void-linux/void-packages/pull/25979
verilator: create package
Creates verilator package for void linux. Verilator needs autoconf to be built, so I added autoconf as a build style.
A patch file from https://github.com/void-linux/void-packages/pull/25979.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-25979.patch --]
[-- Type: text/x-diff, Size: 4926 bytes --]
From cd49c186e560ca1308f2f9df11ddd14a8e032b69 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Thu, 29 Oct 2020 22:49:36 -0700
Subject: [PATCH 1/2] verilator: create package
---
common/build-style/autoconf.sh | 40 ++++++++++++++++++++++
common/environment/build-style/autoconf.sh | 1 +
srcpkgs/verilator/template | 12 +++++++
3 files changed, 53 insertions(+)
create mode 100644 common/build-style/autoconf.sh
create mode 100644 common/environment/build-style/autoconf.sh
create mode 100644 srcpkgs/verilator/template
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
new file mode 100644
index 00000000000..8bb4a2f5a9a
--- /dev/null
+++ b/common/build-style/autoconf.sh
@@ -0,0 +1,40 @@
+#
+# THis helper is for templates using autoconf.
+#
+do_configure() {
+ autoconf
+ ./configure ${configure_args} --prefix /usr
+}
+
+do_build() {
+ : ${make_cmd:=make}
+
+ ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
+}
+
+do_check() {
+ if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
+ if make -q check 2>/dev/null; then
+ :
+ else
+ if [ $? -eq 2 ]; then
+ msg_warn 'No target to "make check".\n'
+ return 0
+ fi
+ fi
+ fi
+
+ : ${make_cmd:=make}
+ : ${make_check_target:=check}
+
+ ${make_cmd} ${make_check_args} ${make_check_target}
+}
+
+do_install() {
+ : ${make_cmd:=make}
+ : ${make_install_target:=install}
+
+ ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
+}
+
+
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
new file mode 100644
index 00000000000..881f67e0e1f
--- /dev/null
+++ b/common/environment/build-style/autoconf.sh
@@ -0,0 +1 @@
+hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
new file mode 100644
index 00000000000..1d527973075
--- /dev/null
+++ b/srcpkgs/verilator/template
@@ -0,0 +1,12 @@
+# Template file for 'foo'
+pkgname=verilator
+version=4.102
+revision=1
+build_style=autoconf
+makedepends="flex"
+short_desc="C++ Library for RTL emulation"
+maintainer="krassovskysasha@gmail.com"
+license="GPL-3.0"
+homepage="https://veripool.org/wiki/verilator"
+distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
+checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
From a4e08fce24202f12b40317ece005d81f61654e16 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Fri, 30 Oct 2020 11:35:12 -0700
Subject: [PATCH 2/2] Change autoconf to pre_configure
---
common/build-style/autoconf.sh | 40 ----------------------
common/environment/build-style/autoconf.sh | 1 -
srcpkgs/verilator/template | 8 ++++-
3 files changed, 7 insertions(+), 42 deletions(-)
delete mode 100644 common/build-style/autoconf.sh
delete mode 100644 common/environment/build-style/autoconf.sh
diff --git a/common/build-style/autoconf.sh b/common/build-style/autoconf.sh
deleted file mode 100644
index 8bb4a2f5a9a..00000000000
--- a/common/build-style/autoconf.sh
+++ /dev/null
@@ -1,40 +0,0 @@
-#
-# THis helper is for templates using autoconf.
-#
-do_configure() {
- autoconf
- ./configure ${configure_args} --prefix /usr
-}
-
-do_build() {
- : ${make_cmd:=make}
-
- ${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}
-}
-
-do_check() {
- if [ -z "$make_cmd" ] && [ -z "$make_check_target" ]; then
- if make -q check 2>/dev/null; then
- :
- else
- if [ $? -eq 2 ]; then
- msg_warn 'No target to "make check".\n'
- return 0
- fi
- fi
- fi
-
- : ${make_cmd:=make}
- : ${make_check_target:=check}
-
- ${make_cmd} ${make_check_args} ${make_check_target}
-}
-
-do_install() {
- : ${make_cmd:=make}
- : ${make_install_target:=install}
-
- ${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}
-}
-
-
diff --git a/common/environment/build-style/autoconf.sh b/common/environment/build-style/autoconf.sh
deleted file mode 100644
index 881f67e0e1f..00000000000
--- a/common/environment/build-style/autoconf.sh
+++ /dev/null
@@ -1 +0,0 @@
-hostmakedepends+=" autoconf"
diff --git a/srcpkgs/verilator/template b/srcpkgs/verilator/template
index 1d527973075..fac09e70359 100644
--- a/srcpkgs/verilator/template
+++ b/srcpkgs/verilator/template
@@ -2,7 +2,9 @@
pkgname=verilator
version=4.102
revision=1
-build_style=autoconf
+build_style=configure
+configure_args="--prefix /usr"
+hostmakedepends="autoconf"
makedepends="flex"
short_desc="C++ Library for RTL emulation"
maintainer="krassovskysasha@gmail.com"
@@ -10,3 +12,7 @@ license="GPL-3.0"
homepage="https://veripool.org/wiki/verilator"
distfiles="https://github.com/verilator/verilator/archive/v${version}.tar.gz"
checksum="4e4f4aff00af9a15a61c94b67ed070cd6312ddcc0f0d340a6df2199480064cef"
+
+pre_configure() {
+ autoconf
+}
next prev parent reply other threads:[~2020-10-30 18:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 5:50 [PR PATCH] " save-buffer
2020-10-30 11:59 ` ericonr
2020-10-30 18:35 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 18:36 ` save-buffer
2020-10-30 18:37 ` save-buffer [this message]
2020-10-30 18:37 ` save-buffer
2020-10-30 18:39 ` save-buffer
2020-10-30 19:12 ` abenson
2020-10-30 19:14 ` [PR REVIEW] " abenson
2020-10-30 19:14 ` abenson
2020-10-30 19:15 ` abenson
2020-10-30 19:16 ` abenson
2020-10-30 19:17 ` abenson
2020-10-30 19:17 ` abenson
2020-10-30 19:22 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 20:42 ` [PR REVIEW] " abenson
2020-10-30 20:42 ` abenson
2020-10-30 21:08 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 21:12 ` [PR REVIEW] " abenson
2020-10-30 21:20 ` [PR PATCH] [Updated] " save-buffer
2020-10-30 23:22 ` jnbr
2020-10-30 23:22 ` [PR PATCH] [Merged]: " jnbr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030183713.K_nWlYk3ZvAjUkI18yy2DzF_PnlQXRsmMK65RueeZ6I@z \
--to=save-buffer@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).