From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] ccache: build manpage, enable tests
Date: Sun, 01 Nov 2020 02:21:12 +0100 [thread overview]
Message-ID: <20201101012112.lix2AjmyIG9kQfhi9esOP00sNA5Lo7v7c9G5ZiCq7Rc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26035@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
New review comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/26035#discussion_r515561459
Comment:
please, just don't
messing with xbps-src variables from template is terrible, keep the nested ifs
next prev parent reply other threads:[~2020-11-01 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 1:09 [PR PATCH] " Piraty
2020-11-01 1:18 ` [PR REVIEW] " sgn
2020-11-01 1:21 ` q66 [this message]
2020-11-01 1:21 ` q66
2020-11-01 1:24 ` ericonr
2020-11-01 1:25 ` Piraty
2020-11-01 1:25 ` [PR PATCH] [Updated] " Piraty
2020-11-01 1:34 ` Piraty
2020-11-01 1:42 ` Piraty
2020-11-01 8:48 ` [PR REVIEW] " fosslinux
2020-11-02 19:33 ` [PR PATCH] [Closed]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101012112.lix2AjmyIG9kQfhi9esOP00sNA5Lo7v7c9G5ZiCq7Rc@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).