From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: phalcon 4.1.0 requires psr
Date: Mon, 02 Nov 2020 17:34:15 +0100 [thread overview]
Message-ID: <20201102163415.FJv89Ok7JYwtH5p7gsm0Cpt8D0yFqtk-WmTAdwVjbrE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26038@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/26038#issuecomment-720582460
Comment:
Please make them more like `php-ast`: build_style instead of calling make in template, `php-devel` in both makedepends contexts for cross build. Setting build_wrksrc instead of srcpath may be needed.
Fix issues found by xlint. You can run it locally or look at travis job logs.
Fix typo in homepage.
Make one commit per template, titled as in contributing.md.
Declare variables in one block.
next prev parent reply other threads:[~2020-11-02 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 12:20 [PR PATCH] " betrixed
2020-11-02 16:34 ` Chocimier [this message]
2020-11-06 3:56 ` [PR PATCH] [Updated] " betrixed
2020-11-06 7:56 ` betrixed
2020-11-06 8:03 ` betrixed
2020-11-06 8:06 ` [PR PATCH] [Closed]: " betrixed
2020-11-06 11:41 ` betrixed
2020-11-06 11:41 ` [PR PATCH] [Updated] " betrixed
2020-11-06 11:50 ` [PR PATCH] [Closed]: " betrixed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102163415.FJv89Ok7JYwtH5p7gsm0Cpt8D0yFqtk-WmTAdwVjbrE@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).