Github messages for voidlinux
 help / color / mirror / Atom feed
From: reback00 <reback00@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: lbry-desktop-0.45.1
Date: Mon, 02 Nov 2020 18:34:33 +0100	[thread overview]
Message-ID: <20201102173433.LM8N1PdZtXGTlu0mWPVSBRO730s1QUwSRH_yPbKKXX4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15206@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2657 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/pull/15206#issuecomment-720618382

Comment:
It's been a year already since the first submit. I almost forgot it existed! Thanks for your interest.

Unfortunately, I'm not sure. It seems to rely on `electron-builder`:

```
  • loaded configuration  file=/builddir/lbry-desktop-0.48.1/electron-builder.json
  • loaded parent configuration  file=/builddir/lbry-desktop-0.48.1/node_modules/electron-webpack/out/electron-builder.js
  • packaging       platform=linux arch=x64 electron=9.3.1 appOutDir=dist/electron/linux-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v9.3.1/electron-v9.3.1-linux-x64.zip size=73 MB parts=4
  • downloaded      url=https://github.com/electron/electron/releases/download/v9.3.1/electron-v9.3.1-linux-x64.zip duration=4m11.854s
  • building        target=AppImage arch=x64 file=dist/electron/LBRY_0.48.1.AppImage
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z size=1.6 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/appimage-12.0.1/appimage-12.0.1.7z duration=40.45s
  • building        target=deb arch=x64 file=dist/electron/LBRY_0.48.1.deb
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/fpm-1.9.3-2.3.1-linux-x86_64/fpm-1.9.3-2.3.1-linux-x86_64.7z size=5.0 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/fpm-1.9.3-2.3.1-linux-x86_64/fpm-1.9.3-2.3.1-linux-x86_64.7z duration=3m22.283s
Done in 954.99s.
```

[electron-builder](https://github.com/electron-userland/electron-builder) seems to be:

> A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box

It can build for `AppImage, snap, debian package (deb), rpm, freebsd, pacman, p5p, apk`. These files mention "electron-builder":
```
./package.json
./CHANGELOG.md
./yarn.lock
./build/afterSignHook.js
./.travis.yml
./README.md
./flow-typed/npm/electron-webpack_vx.x.x.js
./flow-typed/npm/electron-builder_vx.x.x.js
```

Also, there is a `electron-builder.json` file on source tree. Maybe if we can remove electron-builder it will be possible to use system electron. But I'm not sure if the package will play nice with the system electron. I've also checked `atom` and `slack-desktop`. They don't use system electron either.

  parent reply	other threads:[~2020-11-02 17:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  8:25 [PR PATCH] New package: lbry-desktop-0.36.0 voidlinux-github
2020-04-04 10:31 ` [PR PATCH] [Updated] " reback00
2020-05-06 17:30 ` [PR PATCH] [Updated] New package: lbry-desktop-0.44.0 reback00
2020-10-16  7:24 ` [PR PATCH] [Updated] New package: lbry-desktop-0.45.1 reback00
2020-11-01  2:18 ` ericonr
2020-11-02 17:34 ` reback00 [this message]
2020-11-02 17:50 ` ericonr
2020-11-03 18:15 ` reback00
2021-11-06 22:15 ` [PR PATCH] [Closed]: " abenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102173433.LM8N1PdZtXGTlu0mWPVSBRO730s1QUwSRH_yPbKKXX4@z \
    --to=reback00@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).