Re: [PR PATCH] [Updated] nodejs build style

[selfisekai <selfisekai@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

There is an updated pull request by selfisekai against master on the void-packages repository

https://github.com/selfisekai/void-packages node-build-style
https://github.com/void-linux/void-packages/pull/23947

nodejs build style
intended mostly for (bleh) electron packages

A patch file from https://github.com/void-linux/void-packages/pull/23947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-node-build-style-23947.patch --]
[-- Type: text/x-diff, Size: 2413 bytes --]

From cf172217b1ea17856a70f669733a411fe0daf6f1 Mon Sep 17 00:00:00 2001
From: selfisekai <laura@selfisekai.rocks>
Date: Thu, 30 Jul 2020 11:19:10 +0200
Subject: [PATCH 1/2] nodejs build style

---
 common/build-style/nodejs.sh | 37 ++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 common/build-style/nodejs.sh

diff --git a/common/build-style/nodejs.sh b/common/build-style/nodejs.sh
new file mode 100644
index 00000000000..c9e749d3342
--- /dev/null
+++ b/common/build-style/nodejs.sh
@@ -0,0 +1,37 @@
+#
+# This helper is for templates for Node.js packages (including Electron.js)
+#
+
+do_configure() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    $nodejs_packager install
+}
+
+do_build() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    : ${nodejs_build_script:=build}
+
+    $nodejs_packager run $nodejs_build_script
+}
+
+do_install() {
+    if [ -f "yarn.lock" ]; then
+        : ${nodejs_packager:=yarn}
+    else
+        : ${nodejs_packager:=npm}
+    fi
+
+    : ${nodejs_install_script:=pack}  # name suggested by https://github.com/electron-userland/electron-builder#quick-setup-guide
+
+    $nodejs_packager run $nodejs_install_script
+}

From 90627422b037395cb64b2dbca67363248f767585 Mon Sep 17 00:00:00 2001
From: selfisekai <laura@selfisekai.rocks>
Date: Thu, 5 Nov 2020 19:04:58 +0100
Subject: [PATCH 2/2] node build_style: set NODE_ENV

---
 common/build-style/nodejs.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/common/build-style/nodejs.sh b/common/build-style/nodejs.sh
index c9e749d3342..98268b33de0 100644
--- a/common/build-style/nodejs.sh
+++ b/common/build-style/nodejs.sh
@@ -3,6 +3,7 @@
 #
 
 do_configure() {
+    : ${NODE_ENV:=production}
     if [ -f "yarn.lock" ]; then
         : ${nodejs_packager:=yarn}
     else
@@ -13,6 +14,7 @@ do_configure() {
 }
 
 do_build() {
+    : ${NODE_ENV:=production}
     if [ -f "yarn.lock" ]; then
         : ${nodejs_packager:=yarn}
     else
@@ -24,7 +26,9 @@ do_build() {
     $nodejs_packager run $nodejs_build_script
 }
 
+# it's really likely that it won't suit anybody's needs but whatever
 do_install() {
+    : ${NODE_ENV:=production}
     if [ -f "yarn.lock" ]; then
         : ${nodejs_packager:=yarn}
     else