From: amak79 <amak79@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] rpi-base: don't install snd_bcm2835.conf module file, move udev rules to separate file
Date: Tue, 10 Nov 2020 04:50:44 +0100 [thread overview]
Message-ID: <20201110035044.c13g1b4zjfTAuCldxHX02mCbz6oHgPQJyt_OIOXeFww@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24844@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
There is an updated pull request by amak79 against master on the void-packages repository
https://github.com/amak79/void-packages rpibase
https://github.com/void-linux/void-packages/pull/24844
rpi-base: don't install snd_bcm2835.conf module file, move udev rules to separate file
- Don't install the `snd_bcm2835.conf` module file. The current template only installs this file for `armv6l` (rpi 1, zero). RPi audio should instead be enabled via the device tree parameter `dtparam=audio=on` in `/boot/config.txt`. RPi audio is disabled by default.
- Move udev rules from template to `files/71-raspberrypi.rules` file.
- Fix xlint warnings.
- Add `dtparam=audio=on` to `rpi-frmware/files/config.txt`
Built for armv6l, armv7l, aarch64.
Tested on armv6l, armv7l.
A patch file from https://github.com/void-linux/void-packages/pull/24844.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpibase-24844.patch --]
[-- Type: text/x-diff, Size: 3004 bytes --]
From 6bb6dab502dd7d2ae147775b2b3132f5e4cd52ea Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Thu, 1 Oct 2020 09:01:59 +1000
Subject: [PATCH 1/2] rpi-firmware: add option for enabling audio
---
srcpkgs/rpi-firmware/files/config.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/srcpkgs/rpi-firmware/files/config.txt b/srcpkgs/rpi-firmware/files/config.txt
index a5b8eb245bb..ea6233326d6 100755
--- a/srcpkgs/rpi-firmware/files/config.txt
+++ b/srcpkgs/rpi-firmware/files/config.txt
@@ -81,3 +81,6 @@
## with fake kms
#dtoverlay=vc4-fkms-v3d
+
+## Enable the BCM2835 audio driver
+#dtparam=audio=on
From 28418e11052bc32ec253e1f61a3f10ee8768f09a Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Thu, 1 Oct 2020 09:02:27 +1000
Subject: [PATCH 2/2] rpi-base: don't install snd_bcm2835.conf module file,
move udev rules to separate file
---
srcpkgs/rpi-base/files/71-raspberrypi.rules | 4 +++
srcpkgs/rpi-base/template | 29 +++++----------------
2 files changed, 11 insertions(+), 22 deletions(-)
create mode 100644 srcpkgs/rpi-base/files/71-raspberrypi.rules
diff --git a/srcpkgs/rpi-base/files/71-raspberrypi.rules b/srcpkgs/rpi-base/files/71-raspberrypi.rules
new file mode 100644
index 00000000000..5d3c596547c
--- /dev/null
+++ b/srcpkgs/rpi-base/files/71-raspberrypi.rules
@@ -0,0 +1,4 @@
+# Fix permissions for the vchiq, vcio, vcsm devices.
+SUBSYSTEM=="vchiq", GROUP="video", MODE="0660"
+SUBSYSTEM=="bcm2708_vcio", GROUP="video", MODE="0660"
+SUBSYSTEM=="vc-sm", GROUP="video", MODE="0660"
diff --git a/srcpkgs/rpi-base/template b/srcpkgs/rpi-base/template
index a1e15b06280..8fcf3581efd 100644
--- a/srcpkgs/rpi-base/template
+++ b/srcpkgs/rpi-base/template
@@ -1,29 +1,14 @@
# Template file for 'rpi-base'
pkgname=rpi-base
-version=2.5
-revision=4
-homepage="http://www.voidlinux.org"
-short_desc="Void Linux RaspberryPi base files"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="Public Domain"
-
+version=2.6
+revision=1
archs="armv6l* armv7l* aarch64*"
depends="virtual?ntp-daemon rpi-firmware rpi-kernel"
+short_desc="Void Linux Raspberry Pi base files"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="Public Domain"
+homepage="https://www.voidlinux.org"
do_install() {
- case "$XBPS_TARGET_MACHINE" in
- armv6l*)
- # Load the audio module by default on RPi.
- vmkdir usr/lib/modules-load.d
- echo snd-bcm2835 > ${DESTDIR}/usr/lib/modules-load.d/snd_bcm2835.conf
- ;;
- esac
- # Fix permissions for the vchiq, vcio, vcsm devices.
- vmkdir usr/lib/udev/rules.d
- echo 'SUBSYSTEM=="vchiq", GROUP="video", MODE="0660"' > \
- ${DESTDIR}/usr/lib/udev/rules.d/71-raspberrypi.rules
- echo 'SUBSYSTEM=="bcm2708_vcio", GROUP="video", MODE="0660"' >> \
- ${DESTDIR}/usr/lib/udev/rules.d/71-raspberrypi.rules
- echo 'SUBSYSTEM=="vc-sm", GROUP="video", MODE="0660"' >> \
- ${DESTDIR}/usr/lib/udev/rules.d/71-raspberrypi.rules
+ vinstall "${FILESDIR}/71-raspberrypi.rules" 644 usr/lib/udev/rules.d
}
next prev parent reply other threads:[~2020-11-10 3:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 4:38 [PR PATCH] [RFC] rpi-base: don't install snd_bcm2835.conf module file, move udev rules to separate file, add gpio udev rules amak79
2020-09-13 0:46 ` [PR PATCH] [Updated] " amak79
2020-09-13 2:25 ` amak79
2020-09-29 2:30 ` rpi-base: don't install snd_bcm2835.conf module file, move udev rules to separate file ericonr
2020-09-30 0:05 ` fosslinux
2020-09-30 0:05 ` fosslinux
2020-09-30 0:47 ` pbui
2020-09-30 1:23 ` amak79
2020-09-30 1:56 ` [PR PATCH] [Updated] " amak79
2020-09-30 2:05 ` amak79
2020-09-30 2:35 ` amak79
2020-09-30 2:36 ` amak79
2020-09-30 10:33 ` fosslinux
2020-09-30 20:17 ` Johnnynator
2020-09-30 22:42 ` [PR PATCH] [Updated] " amak79
2020-09-30 23:03 ` amak79
2020-10-01 0:06 ` amak79
2020-10-21 23:33 ` [PR PATCH] [Updated] " amak79
2020-11-10 3:50 ` amak79 [this message]
2020-11-10 6:43 ` amak79
2020-11-10 6:47 ` amak79
2020-11-12 0:39 ` amak79
2020-12-30 7:12 ` the-maldridge
2020-12-30 7:41 ` [PR PATCH] [Updated] " amak79
2020-12-30 8:16 ` amak79
2020-12-30 8:24 ` [PR PATCH] [Merged]: " the-maldridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110035044.c13g1b4zjfTAuCldxHX02mCbz6oHgPQJyt_OIOXeFww@z \
--to=amak79@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).