From: sham1 <sham1@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: fcitx-m17n-0.2.4
Date: Wed, 11 Nov 2020 18:34:22 +0100 [thread overview]
Message-ID: <20201111173422.EMQBAjd4d3T0AHkZPGd-x-6jdIsE8eIN6AoJxdpBQ_A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26289@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
New review comment by sham1 on void-packages repository
https://github.com/void-linux/void-packages/pull/26289#discussion_r521523657
Comment:
Well the dependency on `m17n-db` is there since M17n is not very useful if one doesn't also have the database, so might as well depend on it since the user would probably install it anyway. Besides, similar thing is done by `ibus-m17n` so it seemed like a good idea.
As for depending on `fcitx` explicitly, other packages that also add these sorts of IM engines to it also tend to do that, so that's what I'm basing it upon.
Should I remove those dependencies?
next prev parent reply other threads:[~2020-11-11 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 14:47 [PR PATCH] " sham1
2020-11-11 15:12 ` [PR REVIEW] " ericonr
2020-11-11 17:34 ` sham1 [this message]
2020-11-11 17:55 ` ericonr
2020-11-11 18:17 ` sham1
2020-11-15 17:11 ` sgn
2020-11-15 17:22 ` sgn
2020-11-15 21:04 ` [PR PATCH] [Updated] " sham1
2020-11-16 1:12 ` [PR PATCH] [Closed]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111173422.EMQBAjd4d3T0AHkZPGd-x-6jdIsE8eIN6AoJxdpBQ_A@z \
--to=sham1@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).