From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gmsh: update to 4.7.0
Date: Fri, 13 Nov 2020 21:22:19 +0100 [thread overview]
Message-ID: <20201113202219.vUNpjjH1F3xV2If-0oz5T60S4NW6sbmolC_OI_o2ngk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26298@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/26298#discussion_r523202825
Comment:
I don't believe the `numpy` build option is functional. Looking at `CMakeLists.txt`, setting `-DENABLE_NUMPY=ON` is only functional with both `-DENABLE_PRIVATE_API=ON` and `-DENABLE_WRAP_PYTHON=ON`. In addition, this requires `swig`, `python3-numpy` and probably `python3-devel`. You will also probably have to set `NUMPY_INC` to make this work properly for cross builds.
If you don't want to sort out the details, I suggest you just drop the `numpy` build option because it isn't on by default anyway.
next prev parent reply other threads:[~2020-11-13 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 20:24 [PR PATCH] " ndowens
2020-11-13 20:22 ` ahesford [this message]
2020-11-13 23:33 ` [PR PATCH] [Updated] " ndowens
2020-11-14 0:01 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113202219.vUNpjjH1F3xV2If-0oz5T60S4NW6sbmolC_OI_o2ngk@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).