From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Fixed i2pd for older processors
Date: Mon, 16 Nov 2020 19:30:21 +0100 [thread overview]
Message-ID: <20201116183021.RC9iP_65vfI3VMDFlTy6dO_BY8ojGmmmZPwfhvbeX-M@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26436@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/26436#discussion_r524484647
Comment:
This only affects archs other than `x86_64` and `i686`. You should instead make a separate case for `i686`. If you test the package you just created, you'll see that you still get that error.
Furthermore, the current template has `USE_AESNI=no`, not `USE_AESNI=1`. And that should be left as it, otherwise it breaks the build for arm targets.
next prev parent reply other threads:[~2020-11-16 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 16:53 [PR PATCH] " qorg11
2020-11-16 17:17 ` ericonr
2020-11-16 18:23 ` qorg11
2020-11-16 18:24 ` [PR PATCH] [Updated] " qorg11
2020-11-16 18:30 ` ericonr [this message]
2020-11-16 18:51 ` qorg11
2020-11-16 20:02 ` ericonr
2020-11-17 23:52 ` [PR REVIEW] " sgn
2020-11-17 23:53 ` sgn
2020-11-17 23:53 ` sgn
2020-11-18 0:13 ` ericonr
2021-01-07 0:20 ` sgn
2021-01-07 0:21 ` sgn
2021-01-07 0:46 ` [PR PATCH] [Closed]: " qorg11
2021-01-07 0:47 ` [PR REVIEW] " qorg11
2021-04-18 4:40 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116183021.RC9iP_65vfI3VMDFlTy6dO_BY8ojGmmmZPwfhvbeX-M@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).