Github messages for voidlinux
 help / color / mirror / Atom feed
From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] pinebookpro-base: update to 0.3
Date: Sat, 21 Nov 2020 20:40:03 +0100
Message-ID: <20201121194003.QXQxRpZzliAGmETSuLBAuwEYnMP0iC0sgL4kkcVSpmc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26565@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages pbp-base
https://github.com/void-linux/void-packages/pull/26565

pinebookpro-base: update to 0.3
Mark asound.state file as mutable.

Rename udev hwdb to denote pinebookpro specificity.

Rather than using an evdev hwdb match, set up a custom match via a udev
rule so that only the keyboard (and not other devices are matched).

Without the custom rule, lines like the following appear in dmesg:

udevd[...]: Error calling EVIOCSKEYCODE on device node [...]: Invalid argument

A patch file from https://github.com/void-linux/void-packages/pull/26565.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pbp-base-26565.patch --]
[-- Type: text/x-diff, Size: 2966 bytes --]

From 3e71c3cc9d6e562a3701db886a611736e98cdc53 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 21 Nov 2020 09:55:58 -0800
Subject: [PATCH] pinebookpro-base: update to 0.3

Mark asound.state file as mutable.

Rename udev hwdb to denote pinebookpro specificity.

Rather than using an evdev hwdb match, set up a custom match via a udev
rule so that only the keyboard (and not other devices are matched).

Without the custom rule, lines like the following appear in dmesg:

udevd[...]: Error calling EVIOCSKEYCODE on device node [...]: Invalid argument
---
 .../files/{10-usb-kbd.hwdb => 10-pinebookpro.hwdb}         | 2 +-
 srcpkgs/pinebookpro-base/files/60-pinebookpro.rules        | 7 +++++++
 srcpkgs/pinebookpro-base/template                          | 6 ++++--
 3 files changed, 12 insertions(+), 3 deletions(-)
 rename srcpkgs/pinebookpro-base/files/{10-usb-kbd.hwdb => 10-pinebookpro.hwdb} (76%)
 create mode 100644 srcpkgs/pinebookpro-base/files/60-pinebookpro.rules

diff --git a/srcpkgs/pinebookpro-base/files/10-usb-kbd.hwdb b/srcpkgs/pinebookpro-base/files/10-pinebookpro.hwdb
similarity index 76%
rename from srcpkgs/pinebookpro-base/files/10-usb-kbd.hwdb
rename to srcpkgs/pinebookpro-base/files/10-pinebookpro.hwdb
index f8348e6fb3e..65f4b3ed317 100644
--- a/srcpkgs/pinebookpro-base/files/10-usb-kbd.hwdb
+++ b/srcpkgs/pinebookpro-base/files/10-pinebookpro.hwdb
@@ -1,4 +1,4 @@
-evdev:input:b0003v258Ap001E*
+pinebookpro:keyboard
   KEYBOARD_KEY_700a5=brightnessdown
   KEYBOARD_KEY_700a6=brightnessup
   KEYBOARD_KEY_70066=sleep
diff --git a/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
new file mode 100644
index 00000000000..63d3e9ea21f
--- /dev/null
+++ b/srcpkgs/pinebookpro-base/files/60-pinebookpro.rules
@@ -0,0 +1,7 @@
+ACTION=="remove", GOTO="pinebookpro_end"
+KERNEL!="event*", GOTO="pinebookpro_end"
+
+ENV{idVendor}=="258a", ENV{idProduct}=="001e", ENV{ID_INPUT_KEYBOARD}=="1", \
+  IMPORT{builtin}="hwdb 'pinebookpro:keyboard'", RUN{builtin}+="keyboard"
+
+LABEL="pinebookpro_end"
diff --git a/srcpkgs/pinebookpro-base/template b/srcpkgs/pinebookpro-base/template
index 9b4a41eb9a6..fce0a329b98 100644
--- a/srcpkgs/pinebookpro-base/template
+++ b/srcpkgs/pinebookpro-base/template
@@ -1,6 +1,6 @@
 # Template file for 'pinebookpro-base'
 pkgname=pinebookpro-base
-version=0.2
+version=0.3
 revision=1
 archs="aarch64*"
 build_style=meta
@@ -9,8 +9,10 @@ short_desc="Void Linux Pinebook Pro platform package"
 maintainer="Renato Aguiar <renato@renatoaguiar.net>"
 license="Public Domain"
 homepage="https://www.voidlinux.org"
+mutable_files="/var/lib/alsa/asound.state"
 
 do_install() {
-	vinstall "${FILESDIR}/10-usb-kbd.hwdb" 644 usr/lib/udev/hwdb.d
+	vinstall "${FILESDIR}/60-pinebookpro.rules" 644 usr/lib/udev/rules.d
+	vinstall "${FILESDIR}/10-pinebookpro.hwdb" 644 usr/lib/udev/hwdb.d
 	vinstall "${FILESDIR}/asound.state" 644 var/lib/alsa
 }

  reply	other threads:[~2020-11-21 19:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21 18:10 [PR PATCH] " CameronNemo
2020-11-21 19:40 ` CameronNemo [this message]
2020-11-21 20:29 ` [PR PATCH] [Merged]: " the-maldridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201121194003.QXQxRpZzliAGmETSuLBAuwEYnMP0iC0sgL4kkcVSpmc@z \
    --to=cameronnemo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git