Github messages for voidlinux
 help / color / mirror / Atom feed
* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
@ 2020-07-09 15:59 ` sgn
  2020-07-09 16:00 ` sgn
                   ` (31 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-09 15:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452324119

Comment:
not changed

---
I meant please not press resolve until you changed the line.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
  2020-07-09 15:59 ` [PR REVIEW] New package: nagios-4.4.6 sgn
@ 2020-07-09 16:00 ` sgn
  2020-07-09 16:02 ` sgn
                   ` (30 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-09 16:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452325271

Comment:
Why `prefix` to `/usr/share/....`

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
  2020-07-09 15:59 ` [PR REVIEW] New package: nagios-4.4.6 sgn
  2020-07-09 16:00 ` sgn
@ 2020-07-09 16:02 ` sgn
  2020-07-09 16:03 ` sgn
                   ` (29 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-09 16:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452326189

Comment:
Doesn't those flags set by `gnu-configure`?

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (2 preceding siblings ...)
  2020-07-09 16:02 ` sgn
@ 2020-07-09 16:03 ` sgn
  2020-07-09 16:03 ` sgn
                   ` (28 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-09 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452326757

Comment:
I don't like `chown -R` in run file.
On a big directory and slow filesystem, it will take a lot of time.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (3 preceding siblings ...)
  2020-07-09 16:03 ` sgn
@ 2020-07-09 16:03 ` sgn
  2020-07-09 18:12 ` bahamas10
                   ` (27 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-09 16:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452327052

Comment:
What happens if we don't set this?

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (4 preceding siblings ...)
  2020-07-09 16:03 ` sgn
@ 2020-07-09 18:12 ` bahamas10
  2020-07-09 18:16 ` bahamas10
                   ` (26 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 18:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452401512

Comment:
It is changed.

It's in a separate commit pushed 10 days ago to this same branch.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (5 preceding siblings ...)
  2020-07-09 18:12 ` bahamas10
@ 2020-07-09 18:16 ` bahamas10
  2020-07-09 18:16 ` bahamas10
                   ` (25 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 18:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452403464

Comment:
I based this on the Arch Linux AUR (https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=nagios)

I'll look into this - now that you've pointed it out it doesn't look proper.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (6 preceding siblings ...)
  2020-07-09 18:16 ` bahamas10
@ 2020-07-09 18:16 ` bahamas10
  2020-07-09 18:17 ` bahamas10
                   ` (24 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 18:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452403745

Comment:
Which flags specifically? I can test omitting `--prefix` and seeing what happens.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (7 preceding siblings ...)
  2020-07-09 18:16 ` bahamas10
@ 2020-07-09 18:17 ` bahamas10
  2020-07-09 18:17 ` bahamas10
                   ` (23 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452403959

Comment:
This is an outdated commit - it has been replaced with `make_dirs` to specifically affect certain directories.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (8 preceding siblings ...)
  2020-07-09 18:17 ` bahamas10
@ 2020-07-09 18:17 ` bahamas10
  2020-07-09 21:27 ` bahamas10
                   ` (22 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452404106

Comment:
I don't know.  I can test it and report back.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (9 preceding siblings ...)
  2020-07-09 18:17 ` bahamas10
@ 2020-07-09 21:27 ` bahamas10
  2020-07-09 21:27 ` bahamas10
                   ` (21 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452499979

Comment:
This is outdated and has been removed in my latest commit from 10 days ago

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (10 preceding siblings ...)
  2020-07-09 21:27 ` bahamas10
@ 2020-07-09 21:27 ` bahamas10
  2020-07-09 21:41 ` bahamas10
                   ` (20 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 21:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452500156

Comment:
Tested - the installation portion of the install fails.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (11 preceding siblings ...)
  2020-07-09 21:27 ` bahamas10
@ 2020-07-09 21:41 ` bahamas10
  2020-07-10  0:06 ` sgn
                   ` (19 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-09 21:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452506091

Comment:
I tested with `--prefix` removed from `configure_args` and it appears to work as expected!

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (12 preceding siblings ...)
  2020-07-09 21:41 ` bahamas10
@ 2020-07-10  0:06 ` sgn
  2020-07-10  0:12 ` sgn
                   ` (18 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10  0:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452554495

Comment:
Those flags are set by `gnu-configure`:

https://github.com/void-linux/void-packages/blob/ab8ff2e758d8d8d9314c296596ad86dca4e417a7/common/environment/configure/gnu-configure-args.sh#L7-L17
https://github.com/void-linux/void-packages/blob/ab8ff2e758d8d8d9314c296596ad86dca4e417a7/common/environment/configure/gnu-configure-args.sh#L37

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (13 preceding siblings ...)
  2020-07-10  0:06 ` sgn
@ 2020-07-10  0:12 ` sgn
  2020-07-10  0:14 ` sgn
                   ` (17 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10  0:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452556262

Comment:
If they set it to `770`, they should have a reason. Allow your user by adding to `_nagios` group is better.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (14 preceding siblings ...)
  2020-07-10  0:12 ` sgn
@ 2020-07-10  0:14 ` sgn
  2020-07-10  0:15 ` sgn
                   ` (16 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10  0:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452556712

Comment:
`/etc/nagios/...` is shipped, don't `mkdir` it.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (15 preceding siblings ...)
  2020-07-10  0:14 ` sgn
@ 2020-07-10  0:15 ` sgn
  2020-07-10  0:21 ` sgn
                   ` (15 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10  0:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452556923

Comment:
Does it need to start as root?
If yes, does it drop permission after starting?
If no, `chpst` to approriate user.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (16 preceding siblings ...)
  2020-07-10  0:15 ` sgn
@ 2020-07-10  0:21 ` sgn
  2020-07-10 17:00 ` bahamas10
                   ` (14 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10  0:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452558684

Comment:
Can `nagios` `mkdir` its subdir itself?
I think the permission should be 770 as the same with nagios default.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (17 preceding siblings ...)
  2020-07-10  0:21 ` sgn
@ 2020-07-10 17:00 ` bahamas10
  2020-07-10 17:00 ` bahamas10
                   ` (13 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-10 17:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452963819

Comment:
Understood. will update to remove these commands.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (18 preceding siblings ...)
  2020-07-10 17:00 ` bahamas10
@ 2020-07-10 17:00 ` bahamas10
  2020-07-10 17:03 ` bahamas10
                   ` (12 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-10 17:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452963951

Comment:
gotcha

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (19 preceding siblings ...)
  2020-07-10 17:00 ` bahamas10
@ 2020-07-10 17:03 ` bahamas10
  2020-07-10 17:04 ` bahamas10
                   ` (11 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-10 17:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452965280

Comment:
As of right now, the config that gets shipped after compiling will have the `nagios_user` and `nagios_parameter` set to `_nagios` and will `setgid`/`setuid` after starting to drop its privileges. 

However, I don't know if there is anything that requires root in the startup process - i'll test it using `chpst` and report back.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (20 preceding siblings ...)
  2020-07-10 17:03 ` bahamas10
@ 2020-07-10 17:04 ` bahamas10
  2020-07-10 17:06 ` bahamas10
                   ` (10 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-10 17:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r452965796

Comment:
I will update the permissions.

Nagios creates some of these directories during the installation process (though not all of them), however the void package hooks delete the directories since they are empty.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (21 preceding siblings ...)
  2020-07-10 17:04 ` bahamas10
@ 2020-07-10 17:06 ` bahamas10
  2020-07-10 23:12 ` [PR REVIEW] " sgn
                   ` (9 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-10 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

New comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#issuecomment-651273455

Comment:
I tested this with:

#### disable and cleanup

```
sudo sv down nagios
sudo rm /var/service/nagios
sudo xbps-remove -y nagios
sudo rm -rf /var/nagios /etc/nagios /etc/sv/nagios
```

#### create and install new package

```
./xbps-src clean nagios
./xbps-src -f pkg nagios
xi nagios
```

#### verify installation

```
$ tree -ug /var/nagios
/var/nagios
├── [_nagios  _nagios ]  rw
└── [_nagios  _nagios ]  spool
    └── [_nagios  _nagios ]  checkresults

3 directories, 0 files
```

#### enable the service

```
sudo ln -s /etc/sv/nagios
```

#### ensure working

```
$ sudo vsv status nagios

   SERVICE              STATE   ENABLED   PID      COMMAND           TIME
 ✔ nagios               run     true      17828    nagios            31 seconds

$ nagiostats | grep PID
Nagios PID:                             17828
```

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (22 preceding siblings ...)
  2020-07-10 17:06 ` bahamas10
@ 2020-07-10 23:12 ` sgn
  2020-07-10 23:15 ` sgn
                   ` (8 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r453116242

Comment:
I think a bit more, and think it requires root priviledges for network binding.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (23 preceding siblings ...)
  2020-07-10 23:12 ` [PR REVIEW] " sgn
@ 2020-07-10 23:15 ` sgn
  2020-07-12  0:29 ` bahamas10
                   ` (7 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-07-10 23:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r453117176

Comment:
I meant can nagios create those directories upon startup.
The current `make_dir` trigger doesn't delete the directories (upon removal) in reverse orders so ...

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (24 preceding siblings ...)
  2020-07-10 23:15 ` sgn
@ 2020-07-12  0:29 ` bahamas10
  2020-07-12  0:36 ` bahamas10
                   ` (6 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-12  0:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r453249626

Comment:
These files are owned by `root:root` by default, so only the root user or anyone in the root group will be able to execute `nagios` or `nagiostats`... this has issues using `chpst` to run the `nagios` executable (i'll detail more in the `chpst` comment).

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (25 preceding siblings ...)
  2020-07-12  0:29 ` bahamas10
@ 2020-07-12  0:36 ` bahamas10
  2020-07-12  0:39 ` bahamas10
                   ` (5 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-12  0:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r453250094

Comment:
I did some testing into this, and `chpst -u _nagios ...` is possible with modifications to change 2 things:.

1. files in `/etc/nagios` are `660` owned by `root:root`.
2. `nagios` executable is `770` owned by `root:root`.

Both of these things make it so running `chpst -u _nagios nagios ...` fails because 1. it cannot execute the nagios executable.  If i manually `chmod 755` the executable, then it fails again because it cannot read the configuration files.  If I run a find command to change all of the config files to have `644` permissions *then* nagios is able to run under `chpst -u _nagios`.

`nagios` the core executable does not bind to any network port - it simply ships the CGI and HTML files and requires an external web server to host them.  `nagios` instead creates a named pipe at `/var/nagios/rw/nagios.cmd` for communication with the daemon.

I like the idea of running with `chpst` but that'll require the permissions of the executables and the configuration files be opened up to be readable by all, or to modify them to be in the `_nagios` group.  I personally like the idea of the configs and executables being *readable* (not writable) by all, but I understand that that goes against the spirit of how nagios is compiled.  Having it start as root is probably *ok* because it does drop privileges after it starts up.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (26 preceding siblings ...)
  2020-07-12  0:36 ` bahamas10
@ 2020-07-12  0:39 ` bahamas10
  2020-10-31  5:26 ` sgn
                   ` (4 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-07-12  0:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

New review comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#discussion_r453250236

Comment:
I looked through the configuration parameters and the CLI args to `nagios` and cannot see any way for it to create the directories it needs.

It would be possible to move this directory creation logic into the runit `run` script.  It would be a couple of `mkdir` commands followed by `chown` commands.  Would this be preferred? I'm personally ok with any methodology for creating these directories.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (27 preceding siblings ...)
  2020-07-12  0:39 ` bahamas10
@ 2020-10-31  5:26 ` sgn
  2020-11-22  1:01 ` [PR PATCH] [Updated] " bahamas10
                   ` (3 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: sgn @ 2020-10-31  5:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#issuecomment-719887279

Comment:
Is there any change required? Or this is good enough? beside squashing commits??

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Updated] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (28 preceding siblings ...)
  2020-10-31  5:26 ` sgn
@ 2020-11-22  1:01 ` bahamas10
  2020-11-22  1:02 ` bahamas10
                   ` (2 subsequent siblings)
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-11-22  1:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

There is an updated pull request by bahamas10 against master on the void-packages repository

https://github.com/bahamas10/void-packages nagios
https://github.com/void-linux/void-packages/pull/23249

New package: nagios-4.4.6
`nrpe` and `monitoring-plugins` are already available as packages... this changes adds the nagios core itself into the set of available packages.

4.4.6 is the latest release available.

### Testing

I built the package and installed it with:

```
./xbps-src -f pkg nagios
xi nagios
```

I then enabled the service:

```
ln -s /etc/sv/nagios /var/service
```

And verified it was running with:

```
$ sudo cat /var/service/nagios/supervise/pid
30982
$ nagiostats 

Nagios Stats 4.4.6
Copyright (c) 2003-2008 Ethan Galstad (www.nagios.org)
Last Modified: 2020-04-28
License: GPL

CURRENT STATUS DATA
------------------------------------------------------
Status File:                            /var/nagios/status.dat
Status File Age:                        0d 0h 0m 3s
Status File Version:                    4.4.6

Program Running Time:                   0d 0h 0m 3s
Nagios PID:                             30982

```

Notice the PID in the `nagiostats` output matches the PID according to runit.

A patch file from https://github.com/void-linux/void-packages/pull/23249.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nagios-23249.patch --]
[-- Type: text/x-diff, Size: 7694 bytes --]

From 1edd4f11bf73ecc96bc55eb709e3a1982125a330 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Fri, 26 Jun 2020 16:12:12 -0400
Subject: [PATCH 1/3] New package: nagios-4.4.6

---
 srcpkgs/nagios/files/nagios/run |  3 ++
 srcpkgs/nagios/template         | 64 +++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 srcpkgs/nagios/files/nagios/run
 create mode 100644 srcpkgs/nagios/template

diff --git a/srcpkgs/nagios/files/nagios/run b/srcpkgs/nagios/files/nagios/run
new file mode 100644
index 00000000000..9ac567a9028
--- /dev/null
+++ b/srcpkgs/nagios/files/nagios/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+chown -R _nagios:_nagios /var/nagios
+exec nagios /etc/nagios/nagios.cfg 2>&1
diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
new file mode 100644
index 00000000000..d63cef9bb23
--- /dev/null
+++ b/srcpkgs/nagios/template
@@ -0,0 +1,64 @@
+# Template file for 'nagios'
+pkgname=nagios
+version=4.4.6
+revision=1
+build_style=gnu-configure
+
+_nagios_user="_nagios"
+_nagios_group="_nagios"
+_instdir="/usr/share/nagios"
+_bindir="/usr/bin"
+_vardir="/var/nagios"
+_confdir="/etc/nagios"
+_httpdconfdir="/etc/webapps/$pkgname/"
+_checkresultdir="/var/nagios/spool/checkresults"
+_cgibindir="/usr/libexec/nagios/cgi"
+
+configure_args="
+	--with-nagios-user=$_nagios_user
+	--with-nagios-group=$_nagios_group
+	--prefix=$_instdir
+	--bindir=$_bindir
+	--localstatedir=$_vardir
+	--sysconfdir=$_confdir
+	--with-httpd-conf=$_httpdconfdir
+	--with-checkresultdir=$_checkresultdir
+	--with-cgibindir=$_cgibindir
+	--enable-embedded-perl"
+make_build_args="all"
+make_install_args="
+	prefix=$_instdir
+	BINDIR=$_bindir
+	LOGDIR=$_vardir
+	CFGDIR=$_confdir
+	HTTPD_CONF=$_httpdconfdir
+	CHECKRESULTDIR=$_checkresultdir
+	CGIDIR=$_cgibindir
+	install install-config"
+
+makedepends="perl unzip"
+make_dirs="/etc/nagios 0775 _nagios _nagios"
+conf_files="/etc/nagios/nagios.cfg"
+
+short_desc="Nagios Core"
+maintainer="Dave Eddy <dave@daveeddy.com>"
+license="GPL-2.0-or-later"
+
+homepage="https://github.com/NagiosEnterprises/nagioscore"
+changelog="${homepage}/blob/master/Changelog"
+distfiles="${homepage}/releases/download/${pkgname}-${version}/${pkgname}-${version}.tar.gz"
+
+checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
+system_accounts="${_nagios_user}"
+
+post_install() {
+	# these dirs are wiped away by the void post install hooks since they are empty
+	vmkdir "$_vardir/rw"
+	vmkdir "$_vardir/spool/check/results"
+
+	# nagios has these set as 770 by default
+	chmod 755 "$DESTDIR/$_bindir/nagios"
+	chmod 755 "$DESTDIR/$_bindir/nagiostats"
+
+	vsv nagios
+}

From 6529f6464ede402bf633c6e307225f77e82e0d31 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Mon, 29 Jun 2020 13:53:40 -0400
Subject: [PATCH 2/3] updates based on review

---
 srcpkgs/nagios/files/nagios/run |  1 -
 srcpkgs/nagios/template         | 49 ++++++++++++++-------------------
 2 files changed, 21 insertions(+), 29 deletions(-)

diff --git a/srcpkgs/nagios/files/nagios/run b/srcpkgs/nagios/files/nagios/run
index 9ac567a9028..4d0c73dfaf0 100644
--- a/srcpkgs/nagios/files/nagios/run
+++ b/srcpkgs/nagios/files/nagios/run
@@ -1,3 +1,2 @@
 #!/bin/sh
-chown -R _nagios:_nagios /var/nagios
 exec nagios /etc/nagios/nagios.cfg 2>&1
diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
index d63cef9bb23..62be55d1578 100644
--- a/srcpkgs/nagios/template
+++ b/srcpkgs/nagios/template
@@ -10,37 +10,34 @@ _instdir="/usr/share/nagios"
 _bindir="/usr/bin"
 _vardir="/var/nagios"
 _confdir="/etc/nagios"
-_httpdconfdir="/etc/webapps/$pkgname/"
+_httpdconfdir="/etc/webapps/nagios/"
 _checkresultdir="/var/nagios/spool/checkresults"
 _cgibindir="/usr/libexec/nagios/cgi"
 
 configure_args="
-	--with-nagios-user=$_nagios_user
-	--with-nagios-group=$_nagios_group
-	--prefix=$_instdir
-	--bindir=$_bindir
-	--localstatedir=$_vardir
-	--sysconfdir=$_confdir
-	--with-httpd-conf=$_httpdconfdir
-	--with-checkresultdir=$_checkresultdir
-	--with-cgibindir=$_cgibindir
-	--enable-embedded-perl"
+ --with-nagios-user=$_nagios_user
+ --with-nagios-group=$_nagios_group
+ --prefix=$_instdir
+ --bindir=$_bindir
+ --localstatedir=$_vardir
+ --sysconfdir=$_confdir
+ --with-httpd-conf=$_httpdconfdir
+ --with-checkresultdir=$_checkresultdir
+ --with-cgibindir=$_cgibindir
+ --enable-embedded-perl"
 make_build_args="all"
-make_install_args="
-	prefix=$_instdir
-	BINDIR=$_bindir
-	LOGDIR=$_vardir
-	CFGDIR=$_confdir
-	HTTPD_CONF=$_httpdconfdir
-	CHECKRESULTDIR=$_checkresultdir
-	CGIDIR=$_cgibindir
-	install install-config"
-
-makedepends="perl unzip"
-make_dirs="/etc/nagios 0775 _nagios _nagios"
+make_install_args="install install-config"
+
+hostmakedepends="perl unzip"
+make_dirs="
+$_confdir 0775 _nagios _nagios
+$_vardir 0755 _nagios _nagios
+$_vardir/rw 0755 _nagios _nagios
+$_vardir/spool 0755 _nagios _nagios
+$_vardir/spool/checkresults 0755 _nagios _nagios"
 conf_files="/etc/nagios/nagios.cfg"
 
-short_desc="Nagios Core"
+short_desc="Nagios Core monitoring and alerting engine"
 maintainer="Dave Eddy <dave@daveeddy.com>"
 license="GPL-2.0-or-later"
 
@@ -52,10 +49,6 @@ checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
 system_accounts="${_nagios_user}"
 
 post_install() {
-	# these dirs are wiped away by the void post install hooks since they are empty
-	vmkdir "$_vardir/rw"
-	vmkdir "$_vardir/spool/check/results"
-
 	# nagios has these set as 770 by default
 	chmod 755 "$DESTDIR/$_bindir/nagios"
 	chmod 755 "$DESTDIR/$_bindir/nagiostats"

From 1fcb7bb49a539998318d401f79ca60a4f159eec5 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Sat, 21 Nov 2020 20:01:50 -0500
Subject: [PATCH 3/3] round of changes

---
 srcpkgs/nagios/template | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
index 62be55d1578..9726fd19150 100644
--- a/srcpkgs/nagios/template
+++ b/srcpkgs/nagios/template
@@ -6,35 +6,31 @@ build_style=gnu-configure
 
 _nagios_user="_nagios"
 _nagios_group="_nagios"
-_instdir="/usr/share/nagios"
-_bindir="/usr/bin"
 _vardir="/var/nagios"
 _confdir="/etc/nagios"
-_httpdconfdir="/etc/webapps/nagios/"
+_webdir="/usr/share/nagios"
 _checkresultdir="/var/nagios/spool/checkresults"
 _cgibindir="/usr/libexec/nagios/cgi"
 
 configure_args="
  --with-nagios-user=$_nagios_user
  --with-nagios-group=$_nagios_group
- --prefix=$_instdir
- --bindir=$_bindir
  --localstatedir=$_vardir
  --sysconfdir=$_confdir
  --with-httpd-conf=$_httpdconfdir
  --with-checkresultdir=$_checkresultdir
  --with-cgibindir=$_cgibindir
+ --with-webdir=$_webdir
  --enable-embedded-perl"
 make_build_args="all"
 make_install_args="install install-config"
 
 hostmakedepends="perl unzip"
 make_dirs="
-$_confdir 0775 _nagios _nagios
-$_vardir 0755 _nagios _nagios
-$_vardir/rw 0755 _nagios _nagios
-$_vardir/spool 0755 _nagios _nagios
-$_vardir/spool/checkresults 0755 _nagios _nagios"
+$_vardir 0770 _nagios _nagios
+$_vardir/rw 0770 _nagios _nagios
+$_vardir/spool 0770 _nagios _nagios
+$_vardir/spool/checkresults 0770 _nagios _nagios"
 conf_files="/etc/nagios/nagios.cfg"
 
 short_desc="Nagios Core monitoring and alerting engine"
@@ -49,7 +45,9 @@ checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
 system_accounts="${_nagios_user}"
 
 post_install() {
-	# nagios has these set as 770 by default
+	# nagios has these set as 770 by default (owner and group are both
+	# "root").  Leaving these as 770 and executing nagios as root results
+	# in an error.
 	chmod 755 "$DESTDIR/$_bindir/nagios"
 	chmod 755 "$DESTDIR/$_bindir/nagiostats"
 

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (29 preceding siblings ...)
  2020-11-22  1:01 ` [PR PATCH] [Updated] " bahamas10
@ 2020-11-22  1:02 ` bahamas10
  2020-11-22  1:24 ` ericonr
  2020-11-22  1:38 ` [PR PATCH] [Updated] " bahamas10
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-11-22  1:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New comment by bahamas10 on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#issuecomment-731660458

Comment:
I don't know what is left to do with this PR.  It works in its current form, but I know there have been a lot of comments - some resolved, some not etc.

I'm happy to make whatever changes are still left to make for this PR to get it accepted.

I have pushed a small round of changes based on the comments and what I have tested.  Any eyes on this would be appreciated.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (30 preceding siblings ...)
  2020-11-22  1:02 ` bahamas10
@ 2020-11-22  1:24 ` ericonr
  2020-11-22  1:38 ` [PR PATCH] [Updated] " bahamas10
  32 siblings, 0 replies; 33+ messages in thread
From: ericonr @ 2020-11-22  1:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23249#issuecomment-731662202

Comment:
Your template has some small issue which is leading it to fail in `post_install`...

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Updated] New package: nagios-4.4.6
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
                   ` (31 preceding siblings ...)
  2020-11-22  1:24 ` ericonr
@ 2020-11-22  1:38 ` bahamas10
  32 siblings, 0 replies; 33+ messages in thread
From: bahamas10 @ 2020-11-22  1:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

There is an updated pull request by bahamas10 against master on the void-packages repository

https://github.com/bahamas10/void-packages nagios
https://github.com/void-linux/void-packages/pull/23249

New package: nagios-4.4.6
`nrpe` and `monitoring-plugins` are already available as packages... this changes adds the nagios core itself into the set of available packages.

4.4.6 is the latest release available.

### Testing

I built the package and installed it with:

```
./xbps-src -f pkg nagios
xi nagios
```

I then enabled the service:

```
ln -s /etc/sv/nagios /var/service
```

And verified it was running with:

```
$ sudo cat /var/service/nagios/supervise/pid
30982
$ nagiostats 

Nagios Stats 4.4.6
Copyright (c) 2003-2008 Ethan Galstad (www.nagios.org)
Last Modified: 2020-04-28
License: GPL

CURRENT STATUS DATA
------------------------------------------------------
Status File:                            /var/nagios/status.dat
Status File Age:                        0d 0h 0m 3s
Status File Version:                    4.4.6

Program Running Time:                   0d 0h 0m 3s
Nagios PID:                             30982

```

Notice the PID in the `nagiostats` output matches the PID according to runit.

A patch file from https://github.com/void-linux/void-packages/pull/23249.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nagios-23249.patch --]
[-- Type: text/x-diff, Size: 8323 bytes --]

From 1edd4f11bf73ecc96bc55eb709e3a1982125a330 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Fri, 26 Jun 2020 16:12:12 -0400
Subject: [PATCH 1/4] New package: nagios-4.4.6

---
 srcpkgs/nagios/files/nagios/run |  3 ++
 srcpkgs/nagios/template         | 64 +++++++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+)
 create mode 100644 srcpkgs/nagios/files/nagios/run
 create mode 100644 srcpkgs/nagios/template

diff --git a/srcpkgs/nagios/files/nagios/run b/srcpkgs/nagios/files/nagios/run
new file mode 100644
index 00000000000..9ac567a9028
--- /dev/null
+++ b/srcpkgs/nagios/files/nagios/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+chown -R _nagios:_nagios /var/nagios
+exec nagios /etc/nagios/nagios.cfg 2>&1
diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
new file mode 100644
index 00000000000..d63cef9bb23
--- /dev/null
+++ b/srcpkgs/nagios/template
@@ -0,0 +1,64 @@
+# Template file for 'nagios'
+pkgname=nagios
+version=4.4.6
+revision=1
+build_style=gnu-configure
+
+_nagios_user="_nagios"
+_nagios_group="_nagios"
+_instdir="/usr/share/nagios"
+_bindir="/usr/bin"
+_vardir="/var/nagios"
+_confdir="/etc/nagios"
+_httpdconfdir="/etc/webapps/$pkgname/"
+_checkresultdir="/var/nagios/spool/checkresults"
+_cgibindir="/usr/libexec/nagios/cgi"
+
+configure_args="
+	--with-nagios-user=$_nagios_user
+	--with-nagios-group=$_nagios_group
+	--prefix=$_instdir
+	--bindir=$_bindir
+	--localstatedir=$_vardir
+	--sysconfdir=$_confdir
+	--with-httpd-conf=$_httpdconfdir
+	--with-checkresultdir=$_checkresultdir
+	--with-cgibindir=$_cgibindir
+	--enable-embedded-perl"
+make_build_args="all"
+make_install_args="
+	prefix=$_instdir
+	BINDIR=$_bindir
+	LOGDIR=$_vardir
+	CFGDIR=$_confdir
+	HTTPD_CONF=$_httpdconfdir
+	CHECKRESULTDIR=$_checkresultdir
+	CGIDIR=$_cgibindir
+	install install-config"
+
+makedepends="perl unzip"
+make_dirs="/etc/nagios 0775 _nagios _nagios"
+conf_files="/etc/nagios/nagios.cfg"
+
+short_desc="Nagios Core"
+maintainer="Dave Eddy <dave@daveeddy.com>"
+license="GPL-2.0-or-later"
+
+homepage="https://github.com/NagiosEnterprises/nagioscore"
+changelog="${homepage}/blob/master/Changelog"
+distfiles="${homepage}/releases/download/${pkgname}-${version}/${pkgname}-${version}.tar.gz"
+
+checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
+system_accounts="${_nagios_user}"
+
+post_install() {
+	# these dirs are wiped away by the void post install hooks since they are empty
+	vmkdir "$_vardir/rw"
+	vmkdir "$_vardir/spool/check/results"
+
+	# nagios has these set as 770 by default
+	chmod 755 "$DESTDIR/$_bindir/nagios"
+	chmod 755 "$DESTDIR/$_bindir/nagiostats"
+
+	vsv nagios
+}

From 6529f6464ede402bf633c6e307225f77e82e0d31 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Mon, 29 Jun 2020 13:53:40 -0400
Subject: [PATCH 2/4] updates based on review

---
 srcpkgs/nagios/files/nagios/run |  1 -
 srcpkgs/nagios/template         | 49 ++++++++++++++-------------------
 2 files changed, 21 insertions(+), 29 deletions(-)

diff --git a/srcpkgs/nagios/files/nagios/run b/srcpkgs/nagios/files/nagios/run
index 9ac567a9028..4d0c73dfaf0 100644
--- a/srcpkgs/nagios/files/nagios/run
+++ b/srcpkgs/nagios/files/nagios/run
@@ -1,3 +1,2 @@
 #!/bin/sh
-chown -R _nagios:_nagios /var/nagios
 exec nagios /etc/nagios/nagios.cfg 2>&1
diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
index d63cef9bb23..62be55d1578 100644
--- a/srcpkgs/nagios/template
+++ b/srcpkgs/nagios/template
@@ -10,37 +10,34 @@ _instdir="/usr/share/nagios"
 _bindir="/usr/bin"
 _vardir="/var/nagios"
 _confdir="/etc/nagios"
-_httpdconfdir="/etc/webapps/$pkgname/"
+_httpdconfdir="/etc/webapps/nagios/"
 _checkresultdir="/var/nagios/spool/checkresults"
 _cgibindir="/usr/libexec/nagios/cgi"
 
 configure_args="
-	--with-nagios-user=$_nagios_user
-	--with-nagios-group=$_nagios_group
-	--prefix=$_instdir
-	--bindir=$_bindir
-	--localstatedir=$_vardir
-	--sysconfdir=$_confdir
-	--with-httpd-conf=$_httpdconfdir
-	--with-checkresultdir=$_checkresultdir
-	--with-cgibindir=$_cgibindir
-	--enable-embedded-perl"
+ --with-nagios-user=$_nagios_user
+ --with-nagios-group=$_nagios_group
+ --prefix=$_instdir
+ --bindir=$_bindir
+ --localstatedir=$_vardir
+ --sysconfdir=$_confdir
+ --with-httpd-conf=$_httpdconfdir
+ --with-checkresultdir=$_checkresultdir
+ --with-cgibindir=$_cgibindir
+ --enable-embedded-perl"
 make_build_args="all"
-make_install_args="
-	prefix=$_instdir
-	BINDIR=$_bindir
-	LOGDIR=$_vardir
-	CFGDIR=$_confdir
-	HTTPD_CONF=$_httpdconfdir
-	CHECKRESULTDIR=$_checkresultdir
-	CGIDIR=$_cgibindir
-	install install-config"
-
-makedepends="perl unzip"
-make_dirs="/etc/nagios 0775 _nagios _nagios"
+make_install_args="install install-config"
+
+hostmakedepends="perl unzip"
+make_dirs="
+$_confdir 0775 _nagios _nagios
+$_vardir 0755 _nagios _nagios
+$_vardir/rw 0755 _nagios _nagios
+$_vardir/spool 0755 _nagios _nagios
+$_vardir/spool/checkresults 0755 _nagios _nagios"
 conf_files="/etc/nagios/nagios.cfg"
 
-short_desc="Nagios Core"
+short_desc="Nagios Core monitoring and alerting engine"
 maintainer="Dave Eddy <dave@daveeddy.com>"
 license="GPL-2.0-or-later"
 
@@ -52,10 +49,6 @@ checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
 system_accounts="${_nagios_user}"
 
 post_install() {
-	# these dirs are wiped away by the void post install hooks since they are empty
-	vmkdir "$_vardir/rw"
-	vmkdir "$_vardir/spool/check/results"
-
 	# nagios has these set as 770 by default
 	chmod 755 "$DESTDIR/$_bindir/nagios"
 	chmod 755 "$DESTDIR/$_bindir/nagiostats"

From 1fcb7bb49a539998318d401f79ca60a4f159eec5 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Sat, 21 Nov 2020 20:01:50 -0500
Subject: [PATCH 3/4] round of changes

---
 srcpkgs/nagios/template | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
index 62be55d1578..9726fd19150 100644
--- a/srcpkgs/nagios/template
+++ b/srcpkgs/nagios/template
@@ -6,35 +6,31 @@ build_style=gnu-configure
 
 _nagios_user="_nagios"
 _nagios_group="_nagios"
-_instdir="/usr/share/nagios"
-_bindir="/usr/bin"
 _vardir="/var/nagios"
 _confdir="/etc/nagios"
-_httpdconfdir="/etc/webapps/nagios/"
+_webdir="/usr/share/nagios"
 _checkresultdir="/var/nagios/spool/checkresults"
 _cgibindir="/usr/libexec/nagios/cgi"
 
 configure_args="
  --with-nagios-user=$_nagios_user
  --with-nagios-group=$_nagios_group
- --prefix=$_instdir
- --bindir=$_bindir
  --localstatedir=$_vardir
  --sysconfdir=$_confdir
  --with-httpd-conf=$_httpdconfdir
  --with-checkresultdir=$_checkresultdir
  --with-cgibindir=$_cgibindir
+ --with-webdir=$_webdir
  --enable-embedded-perl"
 make_build_args="all"
 make_install_args="install install-config"
 
 hostmakedepends="perl unzip"
 make_dirs="
-$_confdir 0775 _nagios _nagios
-$_vardir 0755 _nagios _nagios
-$_vardir/rw 0755 _nagios _nagios
-$_vardir/spool 0755 _nagios _nagios
-$_vardir/spool/checkresults 0755 _nagios _nagios"
+$_vardir 0770 _nagios _nagios
+$_vardir/rw 0770 _nagios _nagios
+$_vardir/spool 0770 _nagios _nagios
+$_vardir/spool/checkresults 0770 _nagios _nagios"
 conf_files="/etc/nagios/nagios.cfg"
 
 short_desc="Nagios Core monitoring and alerting engine"
@@ -49,7 +45,9 @@ checksum=ab0d5a52caf01e6f4dcd84252c4eb5df5a24f90bb7f951f03875eef54f5ab0f4
 system_accounts="${_nagios_user}"
 
 post_install() {
-	# nagios has these set as 770 by default
+	# nagios has these set as 770 by default (owner and group are both
+	# "root").  Leaving these as 770 and executing nagios as root results
+	# in an error.
 	chmod 755 "$DESTDIR/$_bindir/nagios"
 	chmod 755 "$DESTDIR/$_bindir/nagiostats"
 

From b9cd083402d819ece31d97fa14e20e9afe69f2a8 Mon Sep 17 00:00:00 2001
From: Dave Eddy <dave@daveeddy.com>
Date: Sat, 21 Nov 2020 20:37:08 -0500
Subject: [PATCH 4/4] _bindir required for chmod in post_install

---
 srcpkgs/nagios/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/nagios/template b/srcpkgs/nagios/template
index 9726fd19150..569b9ab7074 100644
--- a/srcpkgs/nagios/template
+++ b/srcpkgs/nagios/template
@@ -6,6 +6,7 @@ build_style=gnu-configure
 
 _nagios_user="_nagios"
 _nagios_group="_nagios"
+_bindir="/usr/bin"
 _vardir="/var/nagios"
 _confdir="/etc/nagios"
 _webdir="/usr/share/nagios"

^ permalink raw reply	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2020-11-22  1:38 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23249@inbox.vuxu.org>
2020-07-09 15:59 ` [PR REVIEW] New package: nagios-4.4.6 sgn
2020-07-09 16:00 ` sgn
2020-07-09 16:02 ` sgn
2020-07-09 16:03 ` sgn
2020-07-09 16:03 ` sgn
2020-07-09 18:12 ` bahamas10
2020-07-09 18:16 ` bahamas10
2020-07-09 18:16 ` bahamas10
2020-07-09 18:17 ` bahamas10
2020-07-09 18:17 ` bahamas10
2020-07-09 21:27 ` bahamas10
2020-07-09 21:27 ` bahamas10
2020-07-09 21:41 ` bahamas10
2020-07-10  0:06 ` sgn
2020-07-10  0:12 ` sgn
2020-07-10  0:14 ` sgn
2020-07-10  0:15 ` sgn
2020-07-10  0:21 ` sgn
2020-07-10 17:00 ` bahamas10
2020-07-10 17:00 ` bahamas10
2020-07-10 17:03 ` bahamas10
2020-07-10 17:04 ` bahamas10
2020-07-10 17:06 ` bahamas10
2020-07-10 23:12 ` [PR REVIEW] " sgn
2020-07-10 23:15 ` sgn
2020-07-12  0:29 ` bahamas10
2020-07-12  0:36 ` bahamas10
2020-07-12  0:39 ` bahamas10
2020-10-31  5:26 ` sgn
2020-11-22  1:01 ` [PR PATCH] [Updated] " bahamas10
2020-11-22  1:02 ` bahamas10
2020-11-22  1:24 ` ericonr
2020-11-22  1:38 ` [PR PATCH] [Updated] " bahamas10

Github messages for voidlinux

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/voidlinux-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 voidlinux-github voidlinux-github/ http://inbox.vuxu.org/voidlinux-github \
		voidlinux-github@inbox.vuxu.org
	public-inbox-index voidlinux-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git