Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rpm: update to 4.16.0.
@ 2020-11-22 21:54 glaulher
  2020-11-22 22:12 ` [PR REVIEW] " ericonr
                   ` (13 more replies)
  0 siblings, 14 replies; 22+ messages in thread
From: glaulher @ 2020-11-22 21:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

There is a new pull request by glaulher against master on the void-packages repository

https://github.com/glaulher/void-packages rpm
https://github.com/void-linux/void-packages/pull/26612

rpm: update to 4.16.0.


A patch file from https://github.com/void-linux/void-packages/pull/26612.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpm-26612.patch --]
[-- Type: text/x-diff, Size: 1645 bytes --]

From 1f70b5bdca9473ec70979ce6efde370852d9fb1f Mon Sep 17 00:00:00 2001
From: glaulher <glaulher.developer@gmail.com>
Date: Sun, 22 Nov 2020 18:50:13 -0300
Subject: [PATCH] rpm: update to 4.16.0.

---
 srcpkgs/rpm/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/rpm/template b/srcpkgs/rpm/template
index d39c3746781..ad99758ac14 100644
--- a/srcpkgs/rpm/template
+++ b/srcpkgs/rpm/template
@@ -1,21 +1,21 @@
 # Template file for 'rpm'
 pkgname=rpm
-version=4.15.1
-revision=4
+version=4.16.0
+revision=1
 build_style=gnu-configure
 configure_args="--with-lua --with-cap --with-acl --with-external-db
  --enable-python PYTHON=python3 --sharedstatedir=/var/lib"
 hostmakedepends="automake gettext-devel libtool nss-devel pkg-config
  python3-setuptools"
-makedepends="binutils-devel db-devel elfutils-devel file-devel libarchive-devel
+makedepends="libgcrypt-devel binutils-devel db-devel elfutils-devel file-devel libarchive-devel
  libcap-devel lua52-devel nss-devel popt-devel python3-devel libgomp-devel"
 short_desc="Red Hat Package Management Utils"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://rpm.org"
 changelog="https://rpm.org/wiki/Releases/${version}.html"
-distfiles="http://ftp.rpm.org/releases/rpm-4.15.x/rpm-${version}.tar.bz2"
-checksum=ddef45f9601cd12042edfc9b6e37efcca32814e1e0f4bb8682d08144a3e2d230
+distfiles="http://ftp.rpm.org/releases/rpm-4.16.x/rpm-${version}.tar.bz2"
+checksum=ca5974e9da2939afb422598818ef187385061889ba766166c4a3829c5ef8d411
 python_version=2 #unverified
 conflicts="rpmextract>=0" # Both provide rpm2cpio
 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
@ 2020-11-22 22:12 ` ericonr
  2020-11-22 22:15 ` ericonr
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-22 22:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#discussion_r528412628

Comment:
`rpm-${version%.*}.x` could work?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
  2020-11-22 22:12 ` [PR REVIEW] " ericonr
@ 2020-11-22 22:15 ` ericonr
  2020-11-22 22:15 ` ericonr
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-22 22:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-731855890

Comment:
Please fix the `xlint` error as well, and I think the musl build is missing `#include <fcntl.h>` from the `rpmdb.c` file.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
  2020-11-22 22:12 ` [PR REVIEW] " ericonr
  2020-11-22 22:15 ` ericonr
@ 2020-11-22 22:15 ` ericonr
  2020-11-23  4:22 ` [PR PATCH] [Closed]: " glaulher
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-22 22:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-731855890

Comment:
Please fix the `xlint` error as well, and I think the musl build is missing `#include <fcntl.h>` in the `rpmdb.c` file.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR PATCH] [Closed]: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (2 preceding siblings ...)
  2020-11-22 22:15 ` ericonr
@ 2020-11-23  4:22 ` glaulher
  2020-11-23  5:02 ` glaulher
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23  4:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

There's a closed pull request on the void-packages repository

rpm: update to 4.16.0.
https://github.com/void-linux/void-packages/pull/26612

Description:


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (3 preceding siblings ...)
  2020-11-23  4:22 ` [PR PATCH] [Closed]: " glaulher
@ 2020-11-23  5:02 ` glaulher
  2020-11-23  5:53 ` ericonr
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23  5:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-731927251

Comment:
I accidentally deleted the branch I was testing on, and I can't reset the pr, the xlint fix, how can I include the #include <fcntl.h> in the rpmdb.c file?

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (4 preceding siblings ...)
  2020-11-23  5:02 ` glaulher
@ 2020-11-23  5:53 ` ericonr
  2020-11-23 12:52 ` glaulher
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23  5:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-731943030

Comment:
You will probably need to open a new PR.

- For xlint, check the python version is indeed correct and remove the comment
- For fcntl, create a patch that adds the `#include <fcntl.h>` line to the include block in the file; I can try and get you a patch to do that.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (5 preceding siblings ...)
  2020-11-23  5:53 ` ericonr
@ 2020-11-23 12:52 ` glaulher
  2020-11-23 13:00 ` glaulher
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 12:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732142983

Comment:
yesterday I can fix the xlint it's ok now, but I can't solve the question of the path

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (6 preceding siblings ...)
  2020-11-23 12:52 ` glaulher
@ 2020-11-23 13:00 ` glaulher
  2020-11-23 13:01 ` ericonr
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 13:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732146605

Comment:

yesterday trying to put the lines in the patch I don't know if it's correct, but it continued with an error:

---rpmdb.c
+++rpmdb.c 
@@ -1,7 +1,9 @@
#include "system.h"

+#include <fcntl.h>
+#include <sys/stat.h>
#include <popt.h>
#include <rpm/rpmcli.h>
#include <rpm/rpmdb.h>
#include "cliutils.h"
#include "debug.h"


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (7 preceding siblings ...)
  2020-11-23 13:00 ` glaulher
@ 2020-11-23 13:01 ` ericonr
  2020-11-23 13:33 ` glaulher
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 13:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732147363

Comment:
Can you show the error messages this time? Remember you have to clean the build `./xbps-src clean rpm` for the patch to be applied.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (8 preceding siblings ...)
  2020-11-23 13:01 ` ericonr
@ 2020-11-23 13:33 ` glaulher
  2020-11-23 13:40 ` ericonr
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 13:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732164844

Comment:
=> rpm-4.16.0_1: verifying checksum for distfile 'rpm-4.16.0.tar.bz2'... OK.
=> rpm-4.16.0_1: running do-extract hook: 00-distfiles ...
=> rpm-4.16.0_1: extracting distfile(s), please wait...
=> rpm-4.16.0_1: running do-patch hook: 00-patches ...
=> rpm-4.16.0_1: patching: fix-musl-rpmdb.patch.
=> ERROR: rpm-4.16.0_1: do-patch_00-patches: 'patch -sl ${_args} -i ${_patch} 2> /dev/null' exited with 2
=> ERROR:   in _process_patch() at common/hooks/do-patch/00-patches.sh:34
=> ERROR:   in hook() at common/hooks/do-patch/00-patches.sh:51
=> ERROR:   in run_func() at common/xbps-src/shutils/common.sh:21
=> ERROR:   in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245
=> ERROR:   in run_step() at common/xbps-src/shutils/common.sh:71
=> ERROR:   in main() at common/xbps-src/libexec/xbps-src-dopatch.sh:33


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (9 preceding siblings ...)
  2020-11-23 13:33 ` glaulher
@ 2020-11-23 13:40 ` ericonr
  2020-11-23 13:49 ` glaulher
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 13:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732168235

Comment:
Take a look at the other patch, you might be missing part of the path... It has:

```
--- rpmio/digest_nss.c
+++ rpmio/digest_nss.c
```

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (10 preceding siblings ...)
  2020-11-23 13:40 ` ericonr
@ 2020-11-23 13:49 ` glaulher
  2020-11-23 13:49 ` ericonr
  2020-11-23 13:52 ` glaulher
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 13:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732173192

Comment:
unfortunately I don't know how to go about correcting the error. help-me 

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (11 preceding siblings ...)
  2020-11-23 13:49 ` glaulher
@ 2020-11-23 13:49 ` ericonr
  2020-11-23 13:52 ` glaulher
  13 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 13:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732173527

Comment:
Open a new PR with your current attempt, I can help you better from there.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: rpm: update to 4.16.0.
  2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
                   ` (12 preceding siblings ...)
  2020-11-23 13:49 ` ericonr
@ 2020-11-23 13:52 ` glaulher
  13 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 13:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26612#issuecomment-732175283

Comment:
ok, thanks


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
                   ` (5 preceding siblings ...)
  2020-11-25 14:27 ` ahesford
@ 2020-11-29 23:56 ` glaulher
  6 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-29 23:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r532289350

Comment:
the version has been fixed, thanks.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
                   ` (4 preceding siblings ...)
  2020-11-25 13:39 ` ericonr
@ 2020-11-25 14:27 ` ahesford
  2020-11-29 23:56 ` glaulher
  6 siblings, 0 replies; 22+ messages in thread
From: ahesford @ 2020-11-25 14:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r530413177

Comment:
It seems that there is exactly one Python script installed by `rpm`, and it works with Python 3 (I can at least get the help text to display). Please change to `python_version=3` as @ericonr recommends.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
                   ` (3 preceding siblings ...)
  2020-11-23 14:53 ` ericonr
@ 2020-11-25 13:39 ` ericonr
  2020-11-25 14:27 ` ahesford
  2020-11-29 23:56 ` glaulher
  6 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-25 13:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r530380462

Comment:
ping here

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
                   ` (2 preceding siblings ...)
  2020-11-23 14:43 ` glaulher
@ 2020-11-23 14:53 ` ericonr
  2020-11-25 13:39 ` ericonr
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 14:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r528759316

Comment:
No, I think you should be using `python_version=3`

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
  2020-11-23 14:38 ` [PR REVIEW] " ericonr
  2020-11-23 14:39 ` ericonr
@ 2020-11-23 14:43 ` glaulher
  2020-11-23 14:53 ` ericonr
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 22+ messages in thread
From: glaulher @ 2020-11-23 14:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by glaulher on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r528752343

Comment:

deleting this line, the package does not compile.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
  2020-11-23 14:38 ` [PR REVIEW] " ericonr
@ 2020-11-23 14:39 ` ericonr
  2020-11-23 14:43 ` glaulher
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 14:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r528749135

Comment:
Is 2 correct? It's linked against python3...

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PR REVIEW] rpm: update to 4.16.0
  2020-11-23 14:36 [PR PATCH] " glaulher
@ 2020-11-23 14:38 ` ericonr
  2020-11-23 14:39 ` ericonr
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 22+ messages in thread
From: ericonr @ 2020-11-23 14:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26642#discussion_r528748953

Comment:
Remove this newline

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2020-11-29 23:56 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 21:54 [PR PATCH] rpm: update to 4.16.0 glaulher
2020-11-22 22:12 ` [PR REVIEW] " ericonr
2020-11-22 22:15 ` ericonr
2020-11-22 22:15 ` ericonr
2020-11-23  4:22 ` [PR PATCH] [Closed]: " glaulher
2020-11-23  5:02 ` glaulher
2020-11-23  5:53 ` ericonr
2020-11-23 12:52 ` glaulher
2020-11-23 13:00 ` glaulher
2020-11-23 13:01 ` ericonr
2020-11-23 13:33 ` glaulher
2020-11-23 13:40 ` ericonr
2020-11-23 13:49 ` glaulher
2020-11-23 13:49 ` ericonr
2020-11-23 13:52 ` glaulher
2020-11-23 14:36 [PR PATCH] " glaulher
2020-11-23 14:38 ` [PR REVIEW] " ericonr
2020-11-23 14:39 ` ericonr
2020-11-23 14:43 ` glaulher
2020-11-23 14:53 ` ericonr
2020-11-25 13:39 ` ericonr
2020-11-25 14:27 ` ahesford
2020-11-29 23:56 ` glaulher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).