Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] .github/workflows/build: don't skip CI when PR is a draft.
@ 2020-11-22 21:37 ericonr
  2020-11-23  0:56 ` [PR PATCH] [Merged]: " ericonr
  0 siblings, 1 reply; 2+ messages in thread
From: ericonr @ 2020-11-22 21:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages ci
https://github.com/void-linux/void-packages/pull/26611

.github/workflows/build: don't skip CI when PR is a draft.
When a PR is marked as ready for review (no longer a draft), CI isn't
re-run automatically, so no tests are run until the PR is updated. Even
trying to manually re-run the jobs doesn't fix this, since GH appears to
remember the PR state instead of using the current one.

A patch file from https://github.com/void-linux/void-packages/pull/26611.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ci-26611.patch --]
[-- Type: text/x-diff, Size: 1257 bytes --]

From a02c44b08080db482ee2b7c83f953aadebf48644 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sun, 22 Nov 2020 18:31:03 -0300
Subject: [PATCH] .github/workflows/build: don't skip CI when PR is a draft.

When a PR is marked as ready for review (no longer a draft), CI isn't
re-run automatically, so no tests are run until the PR is updated. Even
trying to manually re-run the jobs doesn't fix this, since GH appears to
remember the PR state instead of using the current one.
---
 .github/workflows/build.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 8c0cdccf5d4..33186037f8d 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -26,7 +26,7 @@ jobs:
   build:
     name: Build packages
     runs-on: ubuntu-18.04
-    if: "!github.event.pull_request.draft && !contains(github.event.pull_request.title, '[ci skip]') && !contains(github.event.pull_request.body, '[ci skip]')"
+    if: "!contains(github.event.pull_request.title, '[ci skip]') && !contains(github.event.pull_request.body, '[ci skip]')"
 
     container:
       image: 'voidlinux/masterdir-${{ matrix.config.bootstrap }}:20200607RC01'

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: .github/workflows/build: don't skip CI when PR is a draft.
  2020-11-22 21:37 [PR PATCH] .github/workflows/build: don't skip CI when PR is a draft ericonr
@ 2020-11-23  0:56 ` ericonr
  0 siblings, 0 replies; 2+ messages in thread
From: ericonr @ 2020-11-23  0:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

There's a merged pull request on the void-packages repository

.github/workflows/build: don't skip CI when PR is a draft.
https://github.com/void-linux/void-packages/pull/26611

Description:
When a PR is marked as ready for review (no longer a draft), CI isn't
re-run automatically, so no tests are run until the PR is updated. Even
trying to manually re-run the jobs doesn't fix this, since GH appears to
remember the PR state instead of using the current one.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-23  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 21:37 [PR PATCH] .github/workflows/build: don't skip CI when PR is a draft ericonr
2020-11-23  0:56 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).