[PR PATCH] jrnl: update to 2.5.

[PR PATCH] jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

There is a new pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages jrnl
https://github.com/void-linux/void-packages/pull/26398

jrnl: update to 2.5.


A patch file from https://github.com/void-linux/void-packages/pull/26398.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jrnl-26398.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

From 219ef6fea07182b6e7ba70d348eeccc38b6d74ee Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Sun, 15 Nov 2020 13:58:54 +0300
Subject: [PATCH] jrnl: update to 2.5.

---
 srcpkgs/jrnl/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jrnl/template b/srcpkgs/jrnl/template
index c5c03dd9805..447fa23011b 100644
--- a/srcpkgs/jrnl/template
+++ b/srcpkgs/jrnl/template
@@ -1,7 +1,7 @@
 # Template file for 'jrnl'
 pkgname=jrnl
-version=2.4.5
-revision=2
+version=2.5
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-ansiwrap python3-asteval python3-colorama python3-cryptography
@@ -13,4 +13,4 @@ license="GPL-3.0-only"
 homepage="https://jrnl.sh"
 changelog="https://raw.githubusercontent.com/jrnl-org/jrnl/develop/CHANGELOG.md"
 distfiles="${PYPI_SITE}/j/jrnl/jrnl-${version}.tar.gz"
-checksum=a5f069efcaa3f5d95cc7712178b3f92915f67eed4034e5f257cc063c6b0e74d9
+checksum=3984d402feb18538fca6bbba3e0b9900b2f78af0a800fffa735ab9b08896ffda

Re: jrnl: update to 2.5.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730118857

Comment:
Do you think you could add all the necessary `checkdepends` so we don't get any warnings like the one below:

```
WARNING: The pip package is not available, falling back to EasyInstall for handling setup_requires/test_requires; this is deprecated and will be removed in a future version. 
```

Build with `./xbps-src -Q pkg jrnl` to check.

Re: jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730399675

Comment:
@ericonr Apparently the `checkdepends` in this case would be the same as `depends`. Should I copy-paste the whole list or is `checkdepends="${depends}"` acceptable? Either way this fixes the warnings your mentioned.

When I run `./xbps-src -Q pkg jrnl`, however, I get [this output](http://sprunge.us/DkhQC0) with an error from `unittest`. Methinks this way of testing this particular package is not supported or is broken, so we shouldn't be worrying about it.

Re: jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730399675

Comment:
@ericonr Apparently the `checkdepends` in this case would be the same as `depends`. Should I copy-paste the whole list or is `checkdepends="${depends}"` acceptable? Either way this fixes the warnings you mentioned.

When I run `./xbps-src -Q pkg jrnl`, however, I get [this output](http://sprunge.us/DkhQC0) with an error from `unittest`. Methinks this way of testing this particular package is not supported or is broken, so we shouldn't be worrying about it.

Re: jrnl: update to 2.5.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730434146

Comment:
> checkdepends="${depends}" acceptable

Acceptable and preferred :)

Re: jrnl: update to 2.5.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730435530

Comment:
I can't open the paste, but I can guess at the output. Might be best to use upstream's suggested method: https://github.com/jrnl-org/jrnl/blob/develop/CONTRIBUTING.md#common-development-commands

`do_check() { make test }`

Re: [PR PATCH] [Updated] jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

There is an updated pull request by ashpooljh against master on the void-packages repository

https://github.com/ashpooljh/void-packages jrnl
https://github.com/void-linux/void-packages/pull/26398

jrnl: update to 2.5.


A patch file from https://github.com/void-linux/void-packages/pull/26398.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jrnl-26398.patch --]
[-- Type: text/x-diff, Size: 1332 bytes --]

From 43be5954e58252c3c9b643f06e688a99b5cf6a31 Mon Sep 17 00:00:00 2001
From: Artem Zhurikhin <ashpool@xecut.net>
Date: Sun, 15 Nov 2020 13:58:54 +0300
Subject: [PATCH] jrnl: update to 2.5, add checkdepends

---
 srcpkgs/jrnl/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/jrnl/template b/srcpkgs/jrnl/template
index c5c03dd9805..3ebf0e7898b 100644
--- a/srcpkgs/jrnl/template
+++ b/srcpkgs/jrnl/template
@@ -1,16 +1,17 @@
 # Template file for 'jrnl'
 pkgname=jrnl
-version=2.4.5
-revision=2
+version=2.5
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-ansiwrap python3-asteval python3-colorama python3-cryptography
  python3-dateutil python3-keyring python3-parsedatetime python3-passlib
  python3-pytz python3-tzlocal python3-xdg python3-yaml python3-packaging"
+checkdepends="${depends}"
 short_desc="Simple journal application for your command line"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-only"
 homepage="https://jrnl.sh"
 changelog="https://raw.githubusercontent.com/jrnl-org/jrnl/develop/CHANGELOG.md"
 distfiles="${PYPI_SITE}/j/jrnl/jrnl-${version}.tar.gz"
-checksum=a5f069efcaa3f5d95cc7712178b3f92915f67eed4034e5f257cc063c6b0e74d9
+checksum=3984d402feb18538fca6bbba3e0b9900b2f78af0a800fffa735ab9b08896ffda

Re: jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730727935

Comment:
Sorry, I haven't yet found a way to make this work. There's no `Makefile` bundled with the Python module on PyPI.

Things we can try:
- change the upstream to GitHub and build it using the `gnu-makefile` style, not `python3-module`, and use `make test` for checking, or
- figure out why `python3-module`-style `do_check()` fails and patch the package to pass it.

For now, I added the `checkdepends` to fix the warnings, but the check phase remains broken. For anyone who'd like to try fix it, I'll paste the full output of this phase below.

Re: jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 3028 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730728083

Comment:
```
=> jrnl-2.5_1: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
creating jrnl.egg-info
writing jrnl.egg-info/PKG-INFO
writing dependency_links to jrnl.egg-info/dependency_links.txt
writing entry points to jrnl.egg-info/entry_points.txt
writing requirements to jrnl.egg-info/requires.txt
writing top-level names to jrnl.egg-info/top_level.txt
writing manifest file 'jrnl.egg-info/SOURCES.txt'
reading manifest file 'jrnl.egg-info/SOURCES.txt'
writing manifest file 'jrnl.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
  File "/builddir/jrnl-2.5/setup.py", line 46, in <module>
    setup(**setup_kwargs)
  File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 153, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python3.9/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib/python3.9/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python3.9/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 232, in run
    self.run_tests()
  File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 250, in run_tests
    test = unittest.main(
  File "/usr/lib/python3.9/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python3.9/unittest/main.py", line 124, in parseArgs
    self._do_discovery(argv[2:])
  File "/usr/lib/python3.9/unittest/main.py", line 244, in _do_discovery
    self.createTests(from_discovery=True, Loader=Loader)
  File "/usr/lib/python3.9/unittest/main.py", line 154, in createTests
    self.test = loader.discover(self.start, self.pattern, self.top)
  File "/usr/lib/python3.9/unittest/loader.py", line 349, in discover
    tests = list(self._find_tests(start_dir, pattern))
  File "/usr/lib/python3.9/unittest/loader.py", line 405, in _find_tests
    tests, should_recurse = self._find_test_path(
  File "/usr/lib/python3.9/unittest/loader.py", line 483, in _find_test_path
    tests = self.loadTestsFromModule(package, pattern=pattern)
  File "/usr/lib/python3.9/site-packages/setuptools/command/test.py", line 50, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/usr/lib/python3.9/unittest/loader.py", line 214, in loadTestsFromName
    raise TypeError("don't know how to make test from: %s" % obj)
TypeError: don't know how to make test from: v2.5
=> ERROR: jrnl-2.5_1: do_check: 'python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:35
```

Re: jrnl: update to 2.5.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730727935

Comment:
Sorry, I haven't yet found a way to make this work. There's no `Makefile` bundled with the Python module on PyPI.

Things we can try:
- change the upstream to GitHub and build it using the `gnu-makefile` style, not `python3-module`, and use `make test` for checking, or
- figure out why `python3-module`-style `do_check()` fails and patch the package to pass it.

For now, I added the `checkdepends` to fix the warnings, but the check phase remains broken. For anyone who'd like to try to fix it, I'll paste the full output of this phase below.

Re: jrnl: update to 2.5, add checkdepends.

[ashpooljh]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

New comment by ashpooljh on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-730727935

Comment:
Sorry, I haven't yet found a way to make this work. There's no `Makefile` bundled with the Python module on PyPI.

Things we can try:
- change the upstream to GitHub and build it using the `gnu-makefile` style, not `python3-module`, and use `make test` for checking, or
- figure out why `python3-module`-style `do_check()` fails and patch the package to pass it.

For now, I added the `checkdepends` to fix the warnings, but the check phase remains broken. For anyone who'd like to try to fix it, I'll paste the full output of this phase below. Notice the deprecation warning in the beginning.

Re: jrnl: update to 2.5, add checkdepends.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/26398#issuecomment-731929405

Comment:
You can use the tarball from GH and keep the `python3-module`, just redefining the `do_check` function itself.

Re: [PR PATCH] [Closed]: jrnl: update to 2.5, add checkdepends.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

There's a closed pull request on the void-packages repository

jrnl: update to 2.5, add checkdepends.
https://github.com/void-linux/void-packages/pull/26398

Description: