* Re: [PR PATCH] [Updated] xbps-src: fix do_clean
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23015@inbox.vuxu.org>
@ 2020-11-23 19:29 ` Chocimier
2020-11-23 19:30 ` Chocimier
2020-12-01 19:26 ` Chocimier
2 siblings, 0 replies; 3+ messages in thread
From: Chocimier @ 2020-11-23 19:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
There is an updated pull request by Chocimier against master on the void-packages repository
https://github.com/gt7-void/void-packages do_clean
https://github.com/void-linux/void-packages/pull/23015
xbps-src: fix do_clean
It has to be run _before_ remove_pkg_statedir.
Fixes the following bug:
```
$ ./xbps-src extract zfs
...
$ ./xbps-src clean zfs
=> zfs-0.8.4_2: cleaning build directory...
=> zfs-0.8.4_2: running do_clean ...
mkfifo: cannot create fifo '/builddir/.xbps-zfs/zfs__0DLLrI5V.logpipe': No such file or directory
=> ERROR: zfs-0.8.4_2: do_clean: 'mkfifo "$logpipe"' exited with 1
=> ERROR: in run_func() at common/xbps-src/shutils/common.sh:17
=> ERROR: in main() at xbps-src:760
```
A patch file from https://github.com/void-linux/void-packages/pull/23015.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-do_clean-23015.patch --]
[-- Type: text/x-diff, Size: 1007 bytes --]
From 06c153de8dd33a970a1846f2e42a7769c3d86c2d Mon Sep 17 00:00:00 2001
From: gt7-void <gt7@mail.com>
Date: Wed, 17 Jun 2020 18:22:23 -0300
Subject: [PATCH] xbps-src: fix do_clean
It has to be run before remove_pkg_statedir.
Also, run remove_pkg_autodeps as well.
---
xbps-src | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xbps-src b/xbps-src
index ad999439d3a..20c12336439 100755
--- a/xbps-src
+++ b/xbps-src
@@ -753,11 +753,12 @@ case "$XBPS_TARGET" in
if [ -n "$CHROOT_READY" -a -z "$IN_CHROOT" ]; then
chroot_handler $XBPS_TARGET $XBPS_TARGET_PKG || exit $?
else
- remove_pkg_wrksrc
- remove_pkg_statedir
if declare -f do_clean >/dev/null; then
run_func do_clean
fi
+ remove_pkg_autodeps
+ remove_pkg_wrksrc
+ remove_pkg_statedir
fi
remove_pkg $XBPS_CROSS_BUILD
fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xbps-src: fix do_clean
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23015@inbox.vuxu.org>
2020-11-23 19:29 ` [PR PATCH] [Updated] xbps-src: fix do_clean Chocimier
@ 2020-11-23 19:30 ` Chocimier
2020-12-01 19:26 ` Chocimier
2 siblings, 0 replies; 3+ messages in thread
From: Chocimier @ 2020-11-23 19:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23015#issuecomment-732377955
Comment:
Good to merge. I resolved conflicts.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xbps-src: fix do_clean
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23015@inbox.vuxu.org>
2020-11-23 19:29 ` [PR PATCH] [Updated] xbps-src: fix do_clean Chocimier
2020-11-23 19:30 ` Chocimier
@ 2020-12-01 19:26 ` Chocimier
2 siblings, 0 replies; 3+ messages in thread
From: Chocimier @ 2020-12-01 19:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23015#issuecomment-736766874
Comment:
I should have check documentation, it says preserving dependencies is intended.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23015@inbox.vuxu.org>
2020-11-23 19:29 ` [PR PATCH] [Updated] xbps-src: fix do_clean Chocimier
2020-11-23 19:30 ` Chocimier
2020-12-01 19:26 ` Chocimier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).