Github messages for voidlinux
 help / color / mirror / Atom feed
From: Sarkasper <Sarkasper@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] [PATCH] Fix rmlint bug #438.
Date: Wed, 25 Nov 2020 15:55:52 +0100	[thread overview]
Message-ID: <20201125145552.JnI4IDH1hggK_E-rI7dPdK_P3zfU-fyCTRbc6BVwzQY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26697@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

There is an updated pull request by Sarkasper against master on the void-packages repository

https://github.com/Sarkasper/void-packages rmlint
https://github.com/void-linux/void-packages/pull/26697

[PATCH] Fix rmlint bug #438.
https://github.com/sahib/rmlint/issues/438
https://github.com/sahib/rmlint/pull/444

A patch file from https://github.com/void-linux/void-packages/pull/26697.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rmlint-26697.patch --]
[-- Type: text/x-diff, Size: 2422 bytes --]

From dfb2b82dc9d6d3c452af66172fec77ff437eaa71 Mon Sep 17 00:00:00 2001
From: K M J <Sarkasper@users.noreply.github.com>
Date: Fri, 13 Nov 2020 15:24:42 +0100
Subject: [PATCH] [PATCH] Fix rmlint bug #438.

---
 srcpkgs/rmlint/patches/444.patch | 23 +++++++++++++++++++++++
 srcpkgs/rmlint/template          |  3 ++-
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/rmlint/patches/444.patch

diff --git a/srcpkgs/rmlint/patches/444.patch b/srcpkgs/rmlint/patches/444.patch
new file mode 100644
index 00000000000..1937ae2ca24
--- /dev/null
+++ b/srcpkgs/rmlint/patches/444.patch
@@ -0,0 +1,23 @@
+From fc26e889e42602d96226514b65c33c06c47ecd99 Mon Sep 17 00:00:00 2001
+From: Chris Baker <ChrisBaker97@users.noreply.github.com>
+Date: Thu, 12 Nov 2020 13:54:17 -0500
+Subject: [PATCH] cfg.c: fix bug introduced in 2.10.0
+
+This reversion back to the code from version `2.9.0` addresses #438. Obviously there is some functionality here that's being implemented that I'm not familiar enough with the project to understand, but hopefully this gives someone a head start in trying to track down the bug, while still keeping the intended new behavior.
+---
+ lib/cfg.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/cfg.c b/lib/cfg.c
+index 92b02136..e46756e2 100644
+--- a/lib/cfg.c
++++ b/lib/cfg.c
+@@ -109,7 +109,7 @@ guint rm_cfg_add_path(RmCfg *cfg, bool is_prefd, const char *path) {
+     int rc = 0;
+ 
+ #if HAVE_FACCESSAT
+-    rc = faccessat(AT_FDCWD, path, R_OK, AT_EACCESS|AT_SYMLINK_NOFOLLOW);
++    rc = faccessat(AT_FDCWD, path, R_OK, AT_EACCESS);
+ #else
+     rc = access(path, R_OK);
+ #endif
diff --git a/srcpkgs/rmlint/template b/srcpkgs/rmlint/template
index b77f20b805a..c4ffb0bdb9f 100644
--- a/srcpkgs/rmlint/template
+++ b/srcpkgs/rmlint/template
@@ -1,7 +1,7 @@
 # Template file for 'rmlint'
 pkgname=rmlint
 version=2.10.1
-revision=2
+revision=4
 build_style=scons
 hostmakedepends="pkg-config python3-Sphinx glib-devel"
 makedepends="libblkid-devel elfutils-devel json-glib-devel"
@@ -12,6 +12,7 @@ homepage="http://rmlint.rtfd.org/"
 changelog="https://raw.githubusercontent.com/sahib/rmlint/master/CHANGELOG.md"
 distfiles="https://github.com/sahib/${pkgname}/archive/v${version}.tar.gz"
 checksum=10e72ba4dd9672d1b6519c0c94eae647c5069c7d11f1409a46e7011dd0c6b883
+patch_args="-Np1"
 
 do_install() {
 	scons install --prefix=${DESTDIR}/usr

  reply	other threads:[~2020-11-25 14:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 14:42 [PR PATCH] " Sarkasper
2020-11-25 14:55 ` Sarkasper [this message]
2020-11-25 15:12 ` [PR REVIEW] " ericonr
2020-11-25 15:12 ` ericonr
2020-11-25 15:12 ` ericonr
2020-11-25 15:13 ` ericonr
2020-11-25 17:08 ` Sarkasper
2020-11-25 17:10 ` Sarkasper
2020-11-25 17:11 ` ericonr
2020-11-25 17:11 ` [PR REVIEW] " Sarkasper
2020-11-25 17:17 ` Sarkasper
2020-11-25 17:19 ` [PR PATCH] [Updated] " Sarkasper
2020-11-25 17:21 ` Sarkasper
2020-11-25 17:21 ` ericonr
2020-11-25 17:35 ` [NOMERGE] rmlint: backport bugfix #438 Sarkasper
2020-11-25 17:36 ` Sarkasper
2020-11-25 17:39 ` ericonr
2020-11-25 17:44 ` Sarkasper
2020-11-25 17:44 ` Sarkasper
2020-11-25 18:10 ` ericonr
2020-12-06 22:09 ` ericonr
2020-12-06 23:55 ` Sarkasper
2020-12-06 23:55 ` [PR PATCH] [Closed]: " Sarkasper
2020-12-08  9:30 ` Sarkasper
2020-12-08 15:04 ` ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125145552.JnI4IDH1hggK_E-rI7dPdK_P3zfU-fyCTRbc6BVwzQY@z \
    --to=sarkasper@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).