From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] Support for PEP517 build systems in python3-module
Date: Wed, 02 Dec 2020 20:06:25 +0100 [thread overview]
Message-ID: <20201202190625.AMBLc5eMkdFC1ujtzi7-K67IoHSkIT1Qf2pea5lg6r8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26883@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/26883#discussion_r534413104
Comment:
Not a bad idea, but I've gone one step further. Running `python setup.py test` complains about deprectation and suggests `tox` instead. Because that is the official recommendation, I try `tox` first if possible, otherwise try `pytest` if possible, and finally fall back to the old behavior for non-PEP517 builds.
I've modified a few templates as an example of how the change eliminates some redundancy.
If there is not significant debate about the PEP517 changes, I'll squash the two `build-style/python3-module` commits before merging. For now, I'll keep them apart so we can separate the two issues if need be.
next prev parent reply other threads:[~2020-12-02 19:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 16:00 [PR PATCH] " ahesford
2020-12-02 17:45 ` [PR REVIEW] " ericonr
2020-12-02 19:02 ` [PR PATCH] [Updated] " ahesford
2020-12-02 19:06 ` ahesford [this message]
2020-12-02 19:10 ` [PR REVIEW] " ericonr
2020-12-02 19:11 ` ericonr
2020-12-02 19:14 ` ericonr
2020-12-02 19:27 ` [PR PATCH] [Updated] " ahesford
2020-12-02 19:28 ` [PR REVIEW] " ahesford
2020-12-02 19:30 ` [PR PATCH] [Updated] " ahesford
2020-12-02 19:42 ` Johnnynator
2020-12-02 19:59 ` ahesford
2020-12-02 20:21 ` [PR REVIEW] " Chocimier
2020-12-02 23:37 ` fosslinux
2020-12-03 3:43 ` [PR PATCH] [Updated] " ahesford
2020-12-03 3:52 ` ahesford
2020-12-05 16:29 ` [RFC] Support for PEP517 build systems with new build style Chocimier
2020-12-06 5:48 ` [PR PATCH] [Updated] " ahesford
2020-12-06 5:53 ` ahesford
2020-12-06 5:56 ` ahesford
2020-12-06 5:56 ` ahesford
2020-12-08 20:57 ` ahesford
2020-12-08 20:57 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202190625.AMBLc5eMkdFC1ujtzi7-K67IoHSkIT1Qf2pea5lg6r8@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).