Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Cinnamon: update to 4.8.
Date: Sun, 06 Dec 2020 01:09:19 +0100	[thread overview]
Message-ID: <20201206000919.B7yr_G5JHALNyOT3ltyX-68-2rYvZzAzO32zObQzGnM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26965@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/26965#discussion_r536918511

Comment:
I don't care if you decide to use helper or not, but sed to delete with 2 numbers is NOT cool.

EDIT: And I wrote down how to delete it without 2 magic numbers.

  parent reply	other threads:[~2020-12-06  0:09 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05 14:33 [PR PATCH] " mobinmob
2020-12-05 14:41 ` [PR PATCH] [Updated] " mobinmob
2020-12-05 20:05 ` [PR REVIEW] " ericonr
2020-12-05 20:06 ` ericonr
2020-12-05 20:06 ` ericonr
2020-12-05 20:06 ` ericonr
2020-12-05 23:38 ` mobinmob
2020-12-05 23:38 ` mobinmob
2020-12-05 23:40 ` mobinmob
2020-12-05 23:42 ` mobinmob
2020-12-05 23:44 ` mobinmob
2020-12-05 23:51 ` sgn
2020-12-05 23:53 ` ericonr
2020-12-05 23:54 ` [PR PATCH] [Updated] " mobinmob
2020-12-05 23:55 ` [PR REVIEW] " mobinmob
2020-12-05 23:55 ` mobinmob
2020-12-06  0:04 ` mobinmob
2020-12-06  0:08 ` sgn
2020-12-06  0:09 ` sgn [this message]
2020-12-09 18:27 ` ericonr
2020-12-09 18:27 ` ericonr
2020-12-18 22:11 ` mobinmob
2020-12-21 19:06 ` [PR PATCH] [Updated] " mobinmob
2020-12-21 19:07 ` [PR REVIEW] " mobinmob
2020-12-21 19:08 ` mobinmob
2020-12-21 19:21 ` [PR PATCH] [Updated] " mobinmob
2020-12-21 20:05 ` mobinmob
2020-12-24  4:42 ` ericonr
2020-12-24  5:49 ` ericonr
2020-12-26 11:12 ` mobinmob
2020-12-26 11:18 ` mobinmob
2020-12-27 23:47 ` [PR PATCH] [Updated] " mobinmob
2020-12-28  8:01 ` mobinmob
2020-12-28 16:36 ` ericonr
2020-12-28 19:13 ` mobinmob
2021-01-19 19:30 ` ericonr
2021-01-19 19:30 ` [PR PATCH] [Closed]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206000919.B7yr_G5JHALNyOT3ltyX-68-2rYvZzAzO32zObQzGnM@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).