From: firasuke <firasuke@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] dhcp: No need to specify /dev/random
Date: Sun, 06 Dec 2020 23:18:27 +0100 [thread overview]
Message-ID: <20201206221827.Y6pbdyQaZeKt90sgzWCON_QxkhlQsJkPFUGtNNFh2RA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26961@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
New review comment by firasuke on void-packages repository
https://github.com/void-linux/void-packages/pull/26961#discussion_r537136305
Comment:
> Please follow the commit style: `dhcp: ....`
Done
> I'm not sure what this gets us. Would it be a guarantee so an upstream change to randomdev is propagated?
A tiny bit cleaner template file, and of course it doesn't guarantee what upstream does or doesn't do, but it's unlikely that the default value will change anytime soon (a better value would be `/dev/urandom` but then again we're not debating that).
next prev parent reply other threads:[~2020-12-06 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 13:14 [PR PATCH] " firasuke
2020-12-05 19:44 ` [PR REVIEW] " ericonr
2020-12-06 22:18 ` firasuke [this message]
2020-12-06 22:56 ` dhcp: " Duncaen
2020-12-06 22:56 ` Duncaen
2020-12-07 17:59 ` firasuke
2020-12-07 17:59 ` [PR PATCH] [Closed]: " firasuke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206221827.Y6pbdyQaZeKt90sgzWCON_QxkhlQsJkPFUGtNNFh2RA@z \
--to=firasuke@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).