From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gtk+3: update to 3.24.24.
Date: Tue, 08 Dec 2020 15:22:01 +0100 [thread overview]
Message-ID: <20201208142201.gx7KGmt8wGAe5TsppfSCKLgFqxIDfmM0lIiwFloGS60@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-27032@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/27032#discussion_r538426621
Comment:
```bash
if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=true"
fi
```
is probably a better bet, so we only enable tests when somebody is actually running them.
next prev parent reply other threads:[~2020-12-08 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:48 [PR PATCH] Bump gtk ifreund
2020-12-08 13:48 ` [PR REVIEW] " ifreund
2020-12-08 13:49 ` ifreund
2020-12-08 14:22 ` ahesford [this message]
2020-12-08 14:48 ` [PR PATCH] [Updated] gtk+3: update to 3.24.24 ifreund
2020-12-08 14:48 ` [PR REVIEW] " ifreund
2020-12-12 6:01 ` ericonr
2020-12-12 6:01 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208142201.gx7KGmt8wGAe5TsppfSCKLgFqxIDfmM0lIiwFloGS60@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).