From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] build-style/python3-module: prefer pytest in do_check
Date: Tue, 08 Dec 2020 16:19:10 +0100 [thread overview]
Message-ID: <20201208151910.-QNtdLWV6nxR4n4LMxygu6mb3MaIKpqwmhs87pIMJdM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26901@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/26901#discussion_r538488456
Comment:
Setting `PYTHONPATH` this way might improve support for testing compiled extensions, but I'm not sure it should be the default. If tests break because they can't be run with the default path (plus `.`, which is automatically added in the `python3 -m pytest` form of invocation), maybe that should be a manual override situation.
next prev parent reply other threads:[~2020-12-08 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 3:46 [PR PATCH] " ahesford
2020-12-03 4:09 ` ericonr
2020-12-04 3:23 ` fosslinux
2020-12-04 3:24 ` fosslinux
2020-12-04 21:12 ` [PR REVIEW] " ericonr
2020-12-05 5:32 ` sgn
2020-12-08 15:19 ` ahesford [this message]
2020-12-09 20:55 ` ahesford
2020-12-09 20:55 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208151910.-QNtdLWV6nxR4n4LMxygu6mb3MaIKpqwmhs87pIMJdM@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).