From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] enable tests in CI and introduce XBPS_CHECK_PKGS=full
Date: Tue, 08 Dec 2020 18:35:08 +0100 [thread overview]
Message-ID: <20201208173508.G-CfJiREjnRM2fWrdxw4IBLVbD6hyk5y7kQf6Ap5ZHI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26773@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/26773#issuecomment-740786669
Comment:
Not cleaning masterdir will break build of packages that use same source from different templates, like `avahi-discover` - `avahi`. Not sure should it just fail if any test fail or add mode where xbps proceeds to install, but return special exit code that is tracked then to mark job as failed.
With 3 arguments to build.sh, they can be given names, like `arch=$1` ...
FTP_RETRIES was way to fetch from ftp in travis network, it has no use now. Could you remove from build.sh while touching that?
Would be also nice to change XBPS_{,ARG_}CHECK_PKGS=1 to yes since value matters now.
next prev parent reply other threads:[~2020-12-08 17:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-26773@inbox.vuxu.org>
2020-12-02 18:14 ` [PR PATCH] [Updated] [RFC] enable tests in CI ericonr
2020-12-02 18:20 ` ericonr
2020-12-02 18:32 ` ericonr
2020-12-02 18:38 ` ericonr
2020-12-02 18:44 ` ericonr
2020-12-07 22:19 ` ericonr
2020-12-07 23:23 ` ericonr
2020-12-07 23:24 ` [RFC] enable tests in CI and introduce XBPS_CHECK_PKGS=full ericonr
2020-12-07 23:27 ` [PR PATCH] [Updated] " ericonr
2020-12-07 23:29 ` ericonr
2020-12-07 23:30 ` ericonr
2020-12-08 15:27 ` ericonr
2020-12-08 15:37 ` ericonr
2020-12-08 17:35 ` Chocimier [this message]
2020-12-08 18:19 ` ericonr
2020-12-12 6:54 ` [PR PATCH] [Updated] " ericonr
2020-12-14 2:20 ` ericonr
2020-12-14 2:22 ` [PR REVIEW] " sgn
2020-12-14 2:25 ` ericonr
2020-12-14 2:36 ` [PR PATCH] [Updated] " ericonr
2020-12-14 2:49 ` ericonr
2020-12-14 2:51 ` ericonr
2020-12-14 3:18 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208173508.G-CfJiREjnRM2fWrdxw4IBLVbD6hyk5y7kQf6Ap5ZHI@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).